)]}'
{"id":"openocd~master~I964886d5b1d0269497c343811ee4dcd5c31953db","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-06-22 13:05:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-06-29 07:41:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I964886d5b1d0269497c343811ee4dcd5c31953db","subject":"flash/nor/rp2xxx: save ACCESSCTRL over ROM API calls","status":"MERGED","created":"2025-06-19 07:08:53.000000000","updated":"2025-06-29 07:41:27.000000000","submitted":"2025-06-29 07:41:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8961","meta_rev_id":"31606fdee467ab637d0f61f1cc51e0798c01fe79","_number":8961,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:41:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-29 07:41:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-19 07:32:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-06-19 08:03:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-06-20 16:43:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-06-22 13:05:32.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"9077576691eafbb8115018b2b9906700d6ee046e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-19 07:08:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e3ba528105b9b01bf3ff20f97c46c848703b479","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-19 08:03:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20488/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21351/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b58a3c5a53bc9d126cb982483dc1045aa888f93f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-20 16:43:23.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"fdd31975c69cc6ca8daa172eee7ab60fe98f9d73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-22 11:30:15.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"229e49ad33549f56dc214c1457926fc813d1c95c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-22 11:34:03.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a6041655fddd00c43c3e616609e400f1062643d6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-22 11:55:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20516/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21379/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b9994e8c4b6cfa0af9348e123b379c9dcc98d74c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-22 13:05:32.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a232e1df84ab4052fb04946c474beb1def2afc80","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:41:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"31606fdee467ab637d0f61f1cc51e0798c01fe79","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:41:27.000000000","message":"Change has been successfully cherry-picked as f9077f302658eaf5d114d3f84f838a45481af0ac","accounts_in_message":[],"_revision_number":3}],"current_revision":"f9077f302658eaf5d114d3f84f838a45481af0ac","revisions":{"770a06534392ac66134581eff0fe6f683fdcf306":{"kind":"REWORK","_number":1,"created":"2025-06-19 07:08:53.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/8961/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/8961/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/1 \u0026\u0026 git checkout -b change-8961 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/8961/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"baae57625afd9410204ab2ab338849230e650106","subject":"flash/nor/rp2xxx: save security state over target algo"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-18 10:01:08.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-19 07:08:30.000000000","tz":120},"subject":"flash/nor/rp2xxx: save ACCESSCTRL over ROM API calls","message":"flash/nor/rp2xxx: save ACCESSCTRL over ROM API calls\n\nEspecially after the flash probe (used in gdb-attach event)\nwe need to completely restore the original security state to allow\n\u0027resume\u0027 or gdb \u0027continue\u0027 without injecting strange errors\nto application code.\n\nSave all ACCESSCTRL registers potentially changed by triggering CFGRESET.\nRestore them at cleanup.\n\nFixes: commit ea775d49fc71 (\"flash/nor/rp2040: add RP2350 support\")\nChange-Id: I964886d5b1d0269497c343811ee4dcd5c31953db\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"f9077f302658eaf5d114d3f84f838a45481af0ac":{"kind":"REWORK","_number":3,"created":"2025-06-29 07:41:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/61/8961/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/8961/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/3 \u0026\u0026 git checkout -b change-8961 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/8961/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c4fb64e76c526799fc43f72fe2cdd4606c8b9b52","subject":"flash/nor/rp2xxx: save security state over target algo"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-18 10:01:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 07:41:27.000000000","tz":0},"subject":"flash/nor/rp2xxx: save ACCESSCTRL over ROM API calls","message":"flash/nor/rp2xxx: save ACCESSCTRL over ROM API calls\n\nEspecially after the flash probe (used in gdb-attach event)\nwe need to completely restore the original security state to allow\n\u0027resume\u0027 or gdb \u0027continue\u0027 without injecting strange errors\nto application code.\n\nSave all ACCESSCTRL registers potentially changed by triggering CFGRESET.\nRestore them at cleanup.\n\nFixes: commit ea775d49fc71 (\"flash/nor/rp2040: add RP2350 support\")\nChange-Id: I964886d5b1d0269497c343811ee4dcd5c31953db\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8961\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0b38e8bd0bc1fa54b7b2adbde97e6ec9c89ba09b":{"kind":"REWORK","_number":2,"created":"2025-06-22 11:30:15.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/8961/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/8961/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/2 \u0026\u0026 git checkout -b change-8961 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/8961/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/8961/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0c3fde69ed27c99e23cfdd30b6178cb9ee6b8608","subject":"flash/nor/rp2xxx: save security state over target algo"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-18 10:01:08.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-06-22 11:29:59.000000000","tz":120},"subject":"flash/nor/rp2xxx: save ACCESSCTRL over ROM API calls","message":"flash/nor/rp2xxx: save ACCESSCTRL over ROM API calls\n\nEspecially after the flash probe (used in gdb-attach event)\nwe need to completely restore the original security state to allow\n\u0027resume\u0027 or gdb \u0027continue\u0027 without injecting strange errors\nto application code.\n\nSave all ACCESSCTRL registers potentially changed by triggering CFGRESET.\nRestore them at cleanup.\n\nFixes: commit ea775d49fc71 (\"flash/nor/rp2040: add RP2350 support\")\nChange-Id: I964886d5b1d0269497c343811ee4dcd5c31953db\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}