)]}'
{"id":"openocd~v0.6.1~I791cc7fc4faf056623ad5a6c7e860315306098a1","project":"openocd","branch":"v0.6.1","hashtags":[],"change_id":"I791cc7fc4faf056623ad5a6c7e860315306098a1","subject":"Modified Sector Erase for AT91SAM4S","status":"MERGED","created":"2012-10-04 16:22:46.000000000","updated":"2012-10-07 07:23:12.000000000","submitted":"2012-10-07 07:23:12.000000000","submitter":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7717419d6c338407a7b14a4ef10e363a74181baa","_number":897,"owner":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000055,"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","username":"olivier.schonken"},{"value":0,"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":1,"date":"2012-10-07 07:23:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"all":[{"value":1,"date":"2012-10-07 07:23:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000055,"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","username":"olivier.schonken"},{"value":2,"date":"2012-10-07 07:23:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"value":0,"date":"2012-10-07 07:23:12.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},{"_account_id":1000055,"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","username":"olivier.schonken"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-04 16:38:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-10-04 17:57:43.000000000","updated_by":{"_account_id":1000055,"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","username":"olivier.schonken"},"reviewer":{"_account_id":1000055,"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","username":"olivier.schonken"},"state":"REVIEWER"}],"messages":[{"id":"5a41e49e5d5bf1a2c78420b25b7327d4624acf9b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2012-10-04 16:38:28.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit/1510/ : SUCCESS\n\nhttp://openocd.zylin.com/jenkins/job/openocd-gerrit-build/977/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f6e2bf8eb386f45c6f49f948c32c6b4c028edb8d","author":{"_account_id":1000055,"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","username":"olivier.schonken"},"real_author":{"_account_id":1000055,"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","username":"olivier.schonken"},"date":"2012-10-04 17:57:43.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nThanks for the include in the 0.6.1 build","accounts_in_message":[],"_revision_number":1},{"id":"59bb483089036e74e4b6bb80506324e5cf618844","author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"real_author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"date":"2012-10-07 07:23:12.000000000","message":"Patch Set 1: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"7717419d6c338407a7b14a4ef10e363a74181baa","author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"real_author":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"date":"2012-10-07 07:23:12.000000000","message":"Change has been successfully cherry-picked as e69b94295ead882a2c3588249985a6d1215096c8","accounts_in_message":[],"_revision_number":1}],"current_revision":"e69b94295ead882a2c3588249985a6d1215096c8","revisions":{"942915f6553eae54e0b879d2fc5a2ce8e70cc62f":{"kind":"REWORK","_number":1,"created":"2012-10-04 16:22:46.000000000","uploader":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"ref":"refs/changes/97/897/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/897/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/897/1 \u0026\u0026 git checkout -b change-897 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/897/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/897/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/897/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/897/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/897/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d1ea5a7a9e2158f5937af66cf0f642a05cd99d1","subject":"ftdi: fix adapter_init rclk fallback"}],"author":{"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","date":"2012-09-12 19:56:50.000000000","tz":120},"committer":{"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","date":"2012-10-04 16:22:11.000000000","tz":120},"subject":"Modified Sector Erase for AT91SAM4S","message":"Modified Sector Erase for AT91SAM4S\n\nIn FLASHD_ErasePages AT91C_EFC_FCMD_EPA is used to erase sectors.\nAccording to the datasheet FARG[15:2] defines the page from which\nthe erase will start.This page must be modulo 4, 8, 16 or 32\naccording to the number of pages to erase. FARG[1:0] defines the\nnumber of pages to be erased. Previously (firstpage \u003c\u003c 2) was used\nto conform to this, seems it should not be shifted... Changed it\nto (firstPage) | erasePages.\n\nChange-Id: I791cc7fc4faf056623ad5a6c7e860315306098a1\nSigned-off-by: Olivier Schonken \u003colivier.schonken@gmail.com\u003e\n"}},"e69b94295ead882a2c3588249985a6d1215096c8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2012-10-07 07:23:12.000000000","uploader":{"_account_id":1000015,"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","username":"freddiechopin"},"ref":"refs/changes/97/897/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/897/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/897/2 \u0026\u0026 git checkout -b change-897 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/897/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/897/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/897/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/897/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/897/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d1ea5a7a9e2158f5937af66cf0f642a05cd99d1","subject":"ftdi: fix adapter_init rclk fallback"}],"author":{"name":"Olivier Schonken","email":"olivier.schonken@gmail.com","date":"2012-09-12 19:56:50.000000000","tz":120},"committer":{"name":"Freddie Chopin","email":"freddie.chopin@gmail.com","date":"2012-10-07 07:23:12.000000000","tz":0},"subject":"Modified Sector Erase for AT91SAM4S","message":"Modified Sector Erase for AT91SAM4S\n\nIn FLASHD_ErasePages AT91C_EFC_FCMD_EPA is used to erase sectors.\nAccording to the datasheet FARG[15:2] defines the page from which\nthe erase will start.This page must be modulo 4, 8, 16 or 32\naccording to the number of pages to erase. FARG[1:0] defines the\nnumber of pages to be erased. Previously (firstpage \u003c\u003c 2) was used\nto conform to this, seems it should not be shifted... Changed it\nto (firstPage) | erasePages.\n\nChange-Id: I791cc7fc4faf056623ad5a6c7e860315306098a1\nSigned-off-by: Olivier Schonken \u003colivier.schonken@gmail.com\u003e\nReviewed-on: http://openocd.zylin.com/897\nTested-by: jenkins\nReviewed-by: Freddie Chopin \u003cfreddie.chopin@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}