)]}'
{"id":"openocd~master~I18c32b5328a229ab74b56dafab46a064ce5d23c5","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-06-29 07:38:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I18c32b5328a229ab74b56dafab46a064ce5d23c5","subject":"helper: types: fix proper return type in example of ARRAY_SIZE()","status":"MERGED","created":"2025-06-21 10:16:35.000000000","updated":"2025-06-29 07:38:46.000000000","submitted":"2025-06-29 07:38:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8970","meta_rev_id":"6401585a0decc526bfd38819e77f473f819d1b79","_number":8970,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-29 07:38:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-29 07:38:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-21 10:16:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-06-21 10:48:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-06-21 13:37:54.000000000","updated_by":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"7f6a72277e114ae16f41b2e7b01f73201a6bb12d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-21 10:16:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"65815e32f7b1ff53f5aee101f16a6a7b3b2eb375","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-06-21 10:48:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20505/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21368/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1273aeb42cb438d070b13091e95d8f3b9b459d16","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-06-21 13:37:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6401585a0decc526bfd38819e77f473f819d1b79","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-06-29 07:38:46.000000000","message":"Change has been successfully cherry-picked as 13b74c3fc7718d3ac639d6c382b2a4e3ec70a6d1","accounts_in_message":[],"_revision_number":2}],"current_revision":"13b74c3fc7718d3ac639d6c382b2a4e3ec70a6d1","revisions":{"439c3caf6d798661aa77b0f9cdd0631696528479":{"kind":"REWORK","_number":1,"created":"2025-06-21 10:16:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/8970/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8970/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/1 \u0026\u0026 git checkout -b change-8970 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8970/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a9015ba79d73fcc68fac7b98e679e6d4818472ee","subject":"tcl/target/lsch3_common: Remove \u0027mem2array\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-21 10:11:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-21 10:11:24.000000000","tz":120},"subject":"helper: types: fix proper return type in example of ARRAY_SIZE()","message":"helper: types: fix proper return type in example of ARRAY_SIZE()\n\nThe example in the comment above the declaration of the macro\nARRAY_SIZE() assigns the value to a variable of type \u0027unsigned\u0027\nthat is not allowed by the coding style (should be \u0027unsigned int\u0027)\nand is not correct since the macro uses \u0027sizeof()\u0027 and the type\nreturned is \u0027size_t\u0027.\n\nFix the comment.\n\nChange-Id: I18c32b5328a229ab74b56dafab46a064ce5d23c5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"13b74c3fc7718d3ac639d6c382b2a4e3ec70a6d1":{"kind":"REWORK","_number":2,"created":"2025-06-29 07:38:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/8970/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8970/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/2 \u0026\u0026 git checkout -b change-8970 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8970/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8970/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6631419beba62893075eae5e1e13ddba9062d4f5","subject":"jtag: drivers: xlnx-pcie-xvc: use correct TMS polarity during pathmove"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-21 10:11:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 07:38:46.000000000","tz":0},"subject":"helper: types: fix proper return type in example of ARRAY_SIZE()","message":"helper: types: fix proper return type in example of ARRAY_SIZE()\n\nThe example in the comment above the declaration of the macro\nARRAY_SIZE() assigns the value to a variable of type \u0027unsigned\u0027\nthat is not allowed by the coding style (should be \u0027unsigned int\u0027)\nand is not correct since the macro uses \u0027sizeof()\u0027 and the type\nreturned is \u0027size_t\u0027.\n\nFix the comment.\n\nChange-Id: I18c32b5328a229ab74b56dafab46a064ce5d23c5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8970\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}