)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b74e67399992a9b2517973fe0ef4b742614f0d7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0faf9b79_e6fb3937","updated":"2025-06-23 03:30:22.000000000","message":"Compiles on the old 32-bit Ubuntu 14","commit_id":"13cf15ffdc6b9fd5ecd52e7db3603f17f0b62dd3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b895962ba57f258cbfdc8759efa1055270e66563","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65e63a71_b96b3a2a","updated":"2025-06-22 09:53:13.000000000","message":"Hi Nishanth,\ncan you please have a look at this change?\nWe want to enable the build by default, both on 32 and 64 bits.","commit_id":"13cf15ffdc6b9fd5ecd52e7db3603f17f0b62dd3"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"be64ab62909279a583faf3b588ec3b585a3a9a87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e5f9809_4f314f8f","updated":"2025-06-22 15:02:05.000000000","message":"There is a weird mixture of size_t, long (like variable start_delta) and uint64_t in dmem.c . On 32-bit builds, the user can set a too high 64-bit value, which then gets silently truncated to 32 bits. But there is no validation anyway against 64 bit + 32 bit overflow even on 64-bit builds.\n\nHowever, I do not think it is worth improving all that now.\n\nThis patch looks fine and is a step in the right direction.","commit_id":"13cf15ffdc6b9fd5ecd52e7db3603f17f0b62dd3"},{"author":{"_account_id":1002294,"name":"Andrew Davis","email":"glneolistmail@gmail.com","username":"glneo"},"change_message_id":"3aaa37b5690e685e2e73a47f52272744f61a0c8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8999f533_ac6f7df9","updated":"2025-06-23 14:05:57.000000000","message":"Would it also make sense to change `addr` at the two call sites (dmem_emu_ap_q_read() and dmem_emu_ap_q_write()) to uint32_t? That should keep the address offset types all 32bit from start to finish here.","commit_id":"13cf15ffdc6b9fd5ecd52e7db3603f17f0b62dd3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"408062179bff0291ba82dd8c96fa8e9928d8ec93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88ffee59_4caeb588","in_reply_to":"8999f533_ac6f7df9","updated":"2025-06-23 14:16:52.000000000","message":"Sure, it makes sense.\nI\u0027m sending a v2 of the whole series to trigger the complete ACI build.","commit_id":"13cf15ffdc6b9fd5ecd52e7db3603f17f0b62dd3"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"fc64f6a38883e1e818ca515e3d47cd1e4db55ee2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"392681dd_589ff790","updated":"2025-06-23 17:45:18.000000000","message":"and tested on am625 BeaglePlay","commit_id":"3e44e4e0fc800bf1e3675b30724d848780d9f9ad"}]}
