)]}'
{"id":"openocd~master~I26b97d855e094a21540e3377f367520683af2eac","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002386":{"account":{"_account_id":1002386,"name":"Ahmed Haoues","email":"ahmed.haoues@st.com","username":"ahmed-haoues"},"last_update":"2025-07-06 04:45:29.000000000","reason":"Change was submitted"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2025-07-06 04:45:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I26b97d855e094a21540e3377f367520683af2eac","subject":"flash/nor/stm32l4x: fix permanent write protection on STM32U5","status":"MERGED","created":"2025-07-03 05:11:12.000000000","updated":"2025-07-06 04:45:29.000000000","submitted":"2025-07-06 04:45:29.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8981","meta_rev_id":"5628c35fd99b8af210b6cf0ce6635020887e758b","_number":8981,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-07-06 04:45:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-07-06 04:45:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002386,"name":"Ahmed Haoues","email":"ahmed.haoues@st.com","username":"ahmed-haoues"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1002386,"name":"Ahmed Haoues","email":"ahmed.haoues@st.com","username":"ahmed-haoues"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-03 05:11:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-03 05:16:33.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2025-07-03 05:16:33.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1002386,"name":"Ahmed Haoues","email":"ahmed.haoues@st.com","username":"ahmed-haoues"},"state":"REVIEWER"},{"updated":"2025-07-03 05:28:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"22d783a92452255649063bd46c7ce92cf0f18aac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-07-03 05:11:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9d7ae912689d8cc3d812b8b3682851addf20d725","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-07-03 05:16:33.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4696a18229f50b9e1aaa327aba616aa98d22bb12","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-03 05:28:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20550/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21414/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0f332be476d9671a4dfc1cf1f51e46dd4a62c316","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-07-03 06:40:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0298078f1a6abb8cc69afaed24313f9b2d568268","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-07-04 15:35:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5628c35fd99b8af210b6cf0ce6635020887e758b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-07-06 04:45:29.000000000","message":"Change has been successfully cherry-picked as cbc32c3831e39fd07f5fe0dc1cfb9a7be77ffa86","accounts_in_message":[],"_revision_number":2}],"current_revision":"cbc32c3831e39fd07f5fe0dc1cfb9a7be77ffa86","revisions":{"765e6e1a47c328f42856b1191c54482c204b00a7":{"kind":"REWORK","_number":1,"created":"2025-07-03 05:11:12.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/81/8981/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/8981/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/1 \u0026\u0026 git checkout -b change-8981 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/8981/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09a54c3a89af563329adf757990e0c6dd83a1095","subject":"target/arm_adi: add URLs of latest ARM ADI spec"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-07-03 04:52:29.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-07-03 05:09:24.000000000","tz":120},"subject":"flash/nor/stm32l4x: fix permanent write protection on STM32U5","message":"flash/nor/stm32l4x: fix permanent write protection on STM32U5\n\nUnlike other devices supported by this driver STM32U5 devices\nhave a new UNLOCK bit in FLASH_WRP1AR, WRP1BR, WRP2AR, WRP2BR\nregisters. Writing zero to this bit makes the write protection\nblock permanent with no way to unprotect.\n\nCommit 6554d176e926 (\"flash/stm32l4x: support STM32U59/U5Ax devices\")\nand later commits with additional U5 devices lack support for\nthe UNLOCK bit and therefore makes write protection permanent\nwithout warning.\n\nIntroduce the new bit flag F_WRP_HAS_LOCK and mark U5 devices by it.\nSet UNLOCK bit in stm32l4_write_one_wrpxy() if F_WRP_HAS_LOCK is set.\n\nChange-Id: I26b97d855e094a21540e3377f367520683af2eac\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"cbc32c3831e39fd07f5fe0dc1cfb9a7be77ffa86":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-07-06 04:45:29.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/81/8981/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/8981/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/2 \u0026\u0026 git checkout -b change-8981 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/8981/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/8981/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09a54c3a89af563329adf757990e0c6dd83a1095","subject":"target/arm_adi: add URLs of latest ARM ADI spec"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-07-03 04:52:29.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-07-06 04:45:29.000000000","tz":0},"subject":"flash/nor/stm32l4x: fix permanent write protection on STM32U5","message":"flash/nor/stm32l4x: fix permanent write protection on STM32U5\n\nUnlike other devices supported by this driver STM32U5 devices\nhave a new UNLOCK bit in FLASH_WRP1AR, WRP1BR, WRP2AR, WRP2BR\nregisters. Writing zero to this bit makes the write protection\nblock permanent with no way to unprotect.\n\nCommit 6554d176e926 (\"flash/stm32l4x: support STM32U59/U5Ax devices\")\nand later commits with additional U5 devices lack support for\nthe UNLOCK bit and therefore makes write protection permanent\nwithout warning.\n\nIntroduce the new bit flag F_WRP_HAS_LOCK and mark U5 devices by it.\nSet UNLOCK bit in stm32l4_write_one_wrpxy() if F_WRP_HAS_LOCK is set.\n\nChange-Id: I26b97d855e094a21540e3377f367520683af2eac\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8981\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}