)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3d102fb6b2c329193f100d99d4e3416b82049269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bfca5ee7_46210839","updated":"2025-07-07 18:46:38.000000000","message":"Regarding \u0027stm32mp23x-dk.cfg\u0027: we should decide how to name board configuration files. My understanding was/is that we use a single board file for each existing board with the exact name and no \u0027x\u0027 suffixes.","commit_id":"12e7e1e2bf3e5a8d9b15336012fa7a95629a3284"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ce1f12b4f56637eb5fe163dfc1a0c5c5773a2359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11f5bc01_a1eb5648","updated":"2025-07-08 07:53:31.000000000","message":"Thanks for the review!","commit_id":"12e7e1e2bf3e5a8d9b15336012fa7a95629a3284"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e4b5d3d4795aaa89fed1a43f3ee494fa30cb8b39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d1c170be_905bc76b","in_reply_to":"016496cf_dcaf5d03","updated":"2025-07-08 14:24:23.000000000","message":"Done!\nThe web link has to be updated later on","commit_id":"12e7e1e2bf3e5a8d9b15336012fa7a95629a3284"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ce1f12b4f56637eb5fe163dfc1a0c5c5773a2359","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"016496cf_dcaf5d03","in_reply_to":"bfca5ee7_46210839","updated":"2025-07-08 07:53:31.000000000","message":"Yes, I agree! I will send a v2 of this series with the complete board names.\nFor the specific \u0027stm32mp23x-dk.cfg\u0027, it is exactly the same PCB MB1605 used for \u0027stm32mp25x-dk.cfg\u0027, but it would be distributed with a different name to match the SoC.\n\nToday I cannot include the exact web link for \u0027stm32mp23x-dk.cfg\u0027, as the page is not on-line yet.\nIf you prefer, I can hold on upstreaming this board file, waiting for exact references, or I can update it later on.","commit_id":"12e7e1e2bf3e5a8d9b15336012fa7a95629a3284"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d5b3a40cfb01110757bb80bfadd4b15fd35ff7f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"07a7c964_72724520","updated":"2025-07-08 17:15:02.000000000","message":"Nice, thanks. I\u0027ll try to test the board files with actual hardware these days.","commit_id":"687949a8467083d8975617dfad58f3b14774dc17"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"95e64954d10c02b00529abe8090880c20bd03b28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a24142a_81edb3f3","updated":"2025-07-11 08:21:29.000000000","message":"Tested on the `stm32mp257f-dk`, works as expected (no exhaustive testing).","commit_id":"687949a8467083d8975617dfad58f3b14774dc17"}],"tcl/target/st/stm32mp25x.cfg":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"3d102fb6b2c329193f100d99d4e3416b82049269","unresolved":true,"context_lines":[{"line_number":188,"context_line":"\t$::_CHIPNAME.axi arp_examine"},{"line_number":189,"context_line":"\t_enable_debug"},{"line_number":190,"context_line":"\t_rcc_enable_traceclk"},{"line_number":191,"context_line":"\tif { $::EN_CA35_0 } { $::_CHIPNAME.a35_0 arp_examine;  if {$halt} {$::_CHIPNAME.a35_0 arp_halt} }"},{"line_number":192,"context_line":"\tif { $::EN_CA35_1 } { $::_CHIPNAME.a35_1 arp_examine;  if {$halt} {$::_CHIPNAME.a35_1 arp_halt} }"},{"line_number":193,"context_line":"\tif { $::EN_CM0P }   { $::_CHIPNAME.ap2 arp_examine; $::_CHIPNAME.m0p arp_examine }"},{"line_number":194,"context_line":"\tif { $::EN_CM33 }   {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"7511e452_9b291050","line":191,"updated":"2025-07-07 18:46:38.000000000","message":"What is the reason to write multiple statements in a single line? Clearness obviously not ;) There are if-statements with all combinations of multi- and single line style - there is no consistency at all.\n\nI don\u0027t see a reason why we should write Tcl code with multiple statements in a single line. The readability of this style is not only bad in C but also in Tcl code, no?","commit_id":"12e7e1e2bf3e5a8d9b15336012fa7a95629a3284"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ce1f12b4f56637eb5fe163dfc1a0c5c5773a2359","unresolved":true,"context_lines":[{"line_number":188,"context_line":"\t$::_CHIPNAME.axi arp_examine"},{"line_number":189,"context_line":"\t_enable_debug"},{"line_number":190,"context_line":"\t_rcc_enable_traceclk"},{"line_number":191,"context_line":"\tif { $::EN_CA35_0 } { $::_CHIPNAME.a35_0 arp_examine;  if {$halt} {$::_CHIPNAME.a35_0 arp_halt} }"},{"line_number":192,"context_line":"\tif { $::EN_CA35_1 } { $::_CHIPNAME.a35_1 arp_examine;  if {$halt} {$::_CHIPNAME.a35_1 arp_halt} }"},{"line_number":193,"context_line":"\tif { $::EN_CM0P }   { $::_CHIPNAME.ap2 arp_examine; $::_CHIPNAME.m0p arp_examine }"},{"line_number":194,"context_line":"\tif { $::EN_CM33 }   {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"9840e6ef_70590d51","line":191,"in_reply_to":"7511e452_9b291050","updated":"2025-07-08 07:53:31.000000000","message":"These SoC have a complicated sequence for attach and (attach after) reset.\nIt\u0027s a nightmare for me to follow and validate it...\nI try to keep this part as compact as possible to fit all the events in the PC screen so I can mentally parse them and follow the sequence.\nCause checkpatch triggers on long lines, some lines are split...\nI also don\u0027t want to move the code in too many \u0027proc\u0027 because it will make it difficult to handle two SoC in JTAG daisy-chain due to proc\u0027s name overlap.\n\nBut if you insist, I will look for a better arrangement of these lines.","commit_id":"12e7e1e2bf3e5a8d9b15336012fa7a95629a3284"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e4b5d3d4795aaa89fed1a43f3ee494fa30cb8b39","unresolved":false,"context_lines":[{"line_number":188,"context_line":"\t$::_CHIPNAME.axi arp_examine"},{"line_number":189,"context_line":"\t_enable_debug"},{"line_number":190,"context_line":"\t_rcc_enable_traceclk"},{"line_number":191,"context_line":"\tif { $::EN_CA35_0 } { $::_CHIPNAME.a35_0 arp_examine;  if {$halt} {$::_CHIPNAME.a35_0 arp_halt} }"},{"line_number":192,"context_line":"\tif { $::EN_CA35_1 } { $::_CHIPNAME.a35_1 arp_examine;  if {$halt} {$::_CHIPNAME.a35_1 arp_halt} }"},{"line_number":193,"context_line":"\tif { $::EN_CM0P }   { $::_CHIPNAME.ap2 arp_examine; $::_CHIPNAME.m0p arp_examine }"},{"line_number":194,"context_line":"\tif { $::EN_CM33 }   {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"67ba2432_143313f0","line":191,"in_reply_to":"9840e6ef_70590d51","updated":"2025-07-08 14:24:23.000000000","message":"Done, the result is not that bad","commit_id":"12e7e1e2bf3e5a8d9b15336012fa7a95629a3284"}]}