)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e03ea56b71229eee0d694c70381ffc27637182f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67e0aa5d_bf7179b4","updated":"2025-07-09 13:39:26.000000000","message":"Good catch; thanks for the patch!","commit_id":"259e2215839a557ce42ba854b883d99f818dabae"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"780dd3ac7310c0b5b21bbd1ebba9770433844b67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0bd5d7a2_39dc2e18","updated":"2025-07-09 17:38:49.000000000","message":"Looks reasonable to me.  Thanks!","commit_id":"231a26a5174d5c93b4092c4cc43897a4ff7eaaa8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f8d5d8b358d282cb63f16ec1ee5e00a0832527e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"954c02f3_d1ed5597","updated":"2025-07-27 17:03:37.000000000","message":"Thanks.\nI will merge this in a week if there are no further comments","commit_id":"231a26a5174d5c93b4092c4cc43897a4ff7eaaa8"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e03ea56b71229eee0d694c70381ffc27637182f6","unresolved":true,"context_lines":[{"line_number":2071,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1)"},{"line_number":2072,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":2073,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"},{"line_number":2074,"context_line":"\t\tif (bswap)"},{"line_number":2075,"context_line":"\t\t\tbuf_bswap32(albuff, albuff, addrend_al - addrstart_al);"},{"line_number":2076,"context_line":"\t\tmemcpy(buffer, albuff + (address \u0026 3), (size * count));"},{"line_number":2077,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4fb564ce_eb05f860","line":2074,"updated":"2025-07-09 13:39:26.000000000","message":"I think these 3 lines should be conditionalized by another \"if (res \u003d\u003d ERROR_OK)\" since the core status check on line 2070 could also fail, resulting in a double-swap/copy again?","commit_id":"259e2215839a557ce42ba854b883d99f818dabae"},{"author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"change_message_id":"90181ad5c807a80ca11c591f6d835d091be072d1","unresolved":true,"context_lines":[{"line_number":2071,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1)"},{"line_number":2072,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":2073,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"},{"line_number":2074,"context_line":"\t\tif (bswap)"},{"line_number":2075,"context_line":"\t\t\tbuf_bswap32(albuff, albuff, addrend_al - addrstart_al);"},{"line_number":2076,"context_line":"\t\tmemcpy(buffer, albuff + (address \u0026 3), (size * count));"},{"line_number":2077,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c1bc931f_ab007c59","line":2074,"in_reply_to":"4fb564ce_eb05f860","updated":"2025-07-09 14:31:06.000000000","message":"We should be fine in this case. We would copy it twice, but its the same buffer both times so the retry function just overwrites the previous results.\n\nStill probably better to only copy once, please check the new version (also removed a dead assignment pointed out by scan-build)","commit_id":"259e2215839a557ce42ba854b883d99f818dabae"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"780dd3ac7310c0b5b21bbd1ebba9770433844b67","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"\t\tif (xtensa-\u003eprobe_lsddr32p \u003d\u003d -1)"},{"line_number":2072,"context_line":"\t\t\txtensa-\u003eprobe_lsddr32p \u003d 1;"},{"line_number":2073,"context_line":"\t\txtensa-\u003esuppress_dsr_errors \u003d prev_suppress;"},{"line_number":2074,"context_line":"\t\tif (bswap)"},{"line_number":2075,"context_line":"\t\t\tbuf_bswap32(albuff, albuff, addrend_al - addrstart_al);"},{"line_number":2076,"context_line":"\t\tmemcpy(buffer, albuff + (address \u0026 3), (size * count));"},{"line_number":2077,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c51df2e0_7f46a632","line":2074,"in_reply_to":"c1bc931f_ab007c59","updated":"2025-07-09 17:38:49.000000000","message":"Done","commit_id":"259e2215839a557ce42ba854b883d99f818dabae"}]}