)]}'
{"id":"openocd~master~Ie255c367ca6a001bfe7038a76cf8a6443e398c51","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-07-27 17:03:37.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1001803":{"account":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"last_update":"2025-08-09 15:00:50.000000000","reason":"Change was submitted"},"1001982":{"account":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"last_update":"2025-07-09 17:38:49.000000000","reason":"\u003cGERRIT_ACCOUNT_1001982\u003e replied on the change","reason_account":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2025-07-08 20:37:54.000000000","reason":"\u003cGERRIT_ACCOUNT_1001964\u003e replied on the change","reason_account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}}},"hashtags":[],"change_id":"Ie255c367ca6a001bfe7038a76cf8a6443e398c51","subject":"target/xtensa: fix unaligned memory read on retry","status":"MERGED","created":"2025-07-08 20:17:03.000000000","updated":"2025-08-09 15:00:50.000000000","submitted":"2025-08-09 15:00:50.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8987","meta_rev_id":"f85ac72e345358311f3eb2fe1461f9967d588f9a","_number":8987,"owner":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-09 15:00:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-09 15:00:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-09 15:00:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-08 20:17:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-08 20:19:09.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-07-08 20:19:09.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"REVIEWER"},{"updated":"2025-07-08 20:32:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-07-08 20:37:54.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"state":"REVIEWER"}],"messages":[{"id":"9a28026e6436cc46a26396f8dc94e8702253a965","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-07-08 20:17:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"928c4a7e2e591770c91ce55f55334490fc5ba6b4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-08 20:32:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20574/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21439/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e03ea56b71229eee0d694c70381ffc27637182f6","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2025-07-09 13:39:26.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0c29051e2f3932683d1c059852ced9db93c6381d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-07-09 14:29:31.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"90181ad5c807a80ca11c591f6d835d091be072d1","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-07-09 14:31:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a74d363c927e42be365abf6a396c86578f727261","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-09 14:47:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20576/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21441/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"780dd3ac7310c0b5b21bbd1ebba9770433844b67","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2025-07-09 17:38:49.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7f8d5d8b358d282cb63f16ec1ee5e00a0832527e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-27 17:03:37.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0a022a2b737b1f9054f6c54904703c86f35effb4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-09 15:00:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f85ac72e345358311f3eb2fe1461f9967d588f9a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-09 15:00:50.000000000","message":"Change has been successfully cherry-picked as d3c25a45f6536b09917e0fc3e6e51a6adbd4f992","accounts_in_message":[],"_revision_number":3}],"current_revision":"d3c25a45f6536b09917e0fc3e6e51a6adbd4f992","revisions":{"231a26a5174d5c93b4092c4cc43897a4ff7eaaa8":{"kind":"REWORK","_number":2,"created":"2025-07-09 14:29:31.000000000","uploader":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"ref":"refs/changes/87/8987/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/8987/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/2 \u0026\u0026 git checkout -b change-8987 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/8987/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cbc32c3831e39fd07f5fe0dc1cfb9a7be77ffa86","subject":"flash/nor/stm32l4x: fix permanent write protection on STM32U5"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-07-08 20:04:08.000000000","tz":120},"committer":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-07-09 14:19:39.000000000","tz":120},"subject":"target/xtensa: fix unaligned memory read on retry","message":"target/xtensa: fix unaligned memory read on retry\n\nWhen we read unaligned memory there is an offset in the albuff buffer,\nthat we account for when copying back to original buffer. But in case\nthe first access failed, the retry call already removed the offset,\nso doing it a second time shifts the returned memory.\n\nChange-Id: Ie255c367ca6a001bfe7038a76cf8a6443e398c51\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\n"}},"d3c25a45f6536b09917e0fc3e6e51a6adbd4f992":{"kind":"REWORK","_number":3,"created":"2025-08-09 15:00:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/8987/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/8987/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/3 \u0026\u0026 git checkout -b change-8987 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/8987/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66ea461846a3a4a96687c9287c3f61ae8ce0b775","subject":"drivers/cmsis_dap: fix segfault in quirk mode setting"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-07-08 20:04:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-09 15:00:50.000000000","tz":0},"subject":"target/xtensa: fix unaligned memory read on retry","message":"target/xtensa: fix unaligned memory read on retry\n\nWhen we read unaligned memory there is an offset in the albuff buffer,\nthat we account for when copying back to original buffer. But in case\nthe first access failed, the retry call already removed the offset,\nso doing it a second time shifts the returned memory.\n\nChange-Id: Ie255c367ca6a001bfe7038a76cf8a6443e398c51\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8987\nTested-by: jenkins\nReviewed-by: Ian Thompson \u003cianst@cadence.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"259e2215839a557ce42ba854b883d99f818dabae":{"kind":"REWORK","_number":1,"created":"2025-07-08 20:17:03.000000000","uploader":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"ref":"refs/changes/87/8987/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/8987/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/1 \u0026\u0026 git checkout -b change-8987 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/8987/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/8987/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cbc32c3831e39fd07f5fe0dc1cfb9a7be77ffa86","subject":"flash/nor/stm32l4x: fix permanent write protection on STM32U5"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-07-08 20:04:08.000000000","tz":120},"committer":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-07-08 20:13:27.000000000","tz":120},"subject":"target/xtensa: fix unaligned memory read on retry","message":"target/xtensa: fix unaligned memory read on retry\n\nWhen we read unaligned memory there is an offset in the albuff buffer,\nthat we account for when copying back to original buffer. But in case\nthe first access failed, the retry call already removed the offset,\nso doing it a second time shifts the returned memory.\n\nChange-Id: Ie255c367ca6a001bfe7038a76cf8a6443e398c51\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
