)]}'
{"id":"openocd~master~I2c4955a6ed463fabf63a1dbd79145cb63bc7a99c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2025-08-02 12:55:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2c4955a6ed463fabf63a1dbd79145cb63bc7a99c","subject":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027","status":"MERGED","created":"2025-07-09 14:36:19.000000000","updated":"2025-08-02 12:55:14.000000000","submitted":"2025-08-02 12:55:14.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8988","meta_rev_id":"727c7a38c0664000d7ddefbcbbe31a522da8c3af","_number":8988,"owner":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-02 12:55:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-02 12:55:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-09 14:47:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-09 15:08:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-07-25 14:05:47.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"91e722982061d917dbf1a68cd42e37e6af2c46f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-07-09 14:36:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8048c5f23296ff2992f0cce4d128375e9a7b1d0d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-09 15:08:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20577/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21442/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ebfef1533a12a761b54719e4386fe4295d5b7cc1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-07-21 12:04:05.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a069f6e4b8cb8280e3d99c8d2936dac736da6ce7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-21 12:37:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20605/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21470/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a15fc2587921e615f0c0ed8b171d27929e85db12","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-25 14:05:47.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7de2d5deb73e01687862c1e77d4513dc2dcf3d44","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-02 12:55:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"727c7a38c0664000d7ddefbcbbe31a522da8c3af","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-02 12:55:14.000000000","message":"Change has been successfully cherry-picked as a66e6fb43f1ff976d1a38edeb83caeacd06c4b80","accounts_in_message":[],"_revision_number":3}],"current_revision":"a66e6fb43f1ff976d1a38edeb83caeacd06c4b80","revisions":{"16c3129ad613a3d069b69abc9fd2f90047b49c52":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-07-21 12:04:05.000000000","uploader":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/88/8988/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/8988/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/2 \u0026\u0026 git checkout -b change-8988 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/8988/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d48698a1028b2d554f5439b94f244a7d6b6fa381","subject":"helper: Add string_choices.h"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 11:31:37.000000000","tz":0},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-21 12:00:25.000000000","tz":120},"subject":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027","message":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027\n\nThe variables are already used in some parts of the code as boolean\nvalue but have the wrong data type.\n\nChange-Id: I2c4955a6ed463fabf63a1dbd79145cb63bc7a99c\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"a66e6fb43f1ff976d1a38edeb83caeacd06c4b80":{"kind":"REWORK","_number":3,"created":"2025-08-02 12:55:14.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/88/8988/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/8988/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/3 \u0026\u0026 git checkout -b change-8988 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/8988/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"caf7ffc7ebb257b589d88aec4c3958ab2e6897f7","subject":"helper: Add string_choices.h"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 11:31:37.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-02 12:55:14.000000000","tz":0},"subject":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027","message":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027\n\nThe variables are already used in some parts of the code as boolean\nvalue but have the wrong data type.\n\nChange-Id: I2c4955a6ed463fabf63a1dbd79145cb63bc7a99c\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8988\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"6f89bd4b49ff68297ade78b191ec95b32725c223":{"kind":"REWORK","_number":1,"created":"2025-07-09 14:36:19.000000000","uploader":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/88/8988/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/8988/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/1 \u0026\u0026 git checkout -b change-8988 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/8988/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/8988/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cbc32c3831e39fd07f5fe0dc1cfb9a7be77ffa86","subject":"flash/nor/stm32l4x: fix permanent write protection on STM32U5"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 11:31:37.000000000","tz":0},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 14:33:38.000000000","tz":120},"subject":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027","message":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027\n\nThe variables are already used in some parts of the code as boolean\nvalue but have the wrong data type.\n\nChange-Id: I2c4955a6ed463fabf63a1dbd79145cb63bc7a99c\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}