)]}'
{"id":"openocd~master~I50ccbf84c6f33a3034de989789c6b17312458ea8","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2025-08-02 12:55:31.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I50ccbf84c6f33a3034de989789c6b17312458ea8","subject":"target: Use \u0027bool\u0027 data type in mmu()","status":"MERGED","created":"2025-07-09 14:36:19.000000000","updated":"2025-08-02 12:55:31.000000000","submitted":"2025-08-02 12:55:31.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8989","meta_rev_id":"77cdd19093497be664442320882505c0241ba671","_number":8989,"owner":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-02 12:55:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-02 12:55:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-09 14:52:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-09 15:33:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-07-25 14:07:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"167b295bb9d0c167737e939e32736788d7d076f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-07-09 14:36:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"628702ab1211c4a1b480a01c90151c4009d68e55","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-09 15:33:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20578/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21443/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"86aab63a68c3f6293221aad4f6f25e269f6e0739","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-07-21 12:04:05.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"1e5e9357437031421a4a8858b4334414b163eb4a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-21 12:21:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20604/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21469/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4d240a3053570d6abfb186743d2d4dc302cec711","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-25 14:07:38.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8ff22fa4bbe308f02d225478f8b3b4d2be799417","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-02 12:55:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"77cdd19093497be664442320882505c0241ba671","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-02 12:55:31.000000000","message":"Change has been successfully cherry-picked as 325e6d38b5d3edb3563481b96c897c3dc6f84bd8","accounts_in_message":[],"_revision_number":3}],"current_revision":"325e6d38b5d3edb3563481b96c897c3dc6f84bd8","revisions":{"8ae7613924a47202856b634f7c3472358b1f2774":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-07-21 12:04:05.000000000","uploader":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/89/8989/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/8989/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/2 \u0026\u0026 git checkout -b change-8989 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/8989/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"16c3129ad613a3d069b69abc9fd2f90047b49c52","subject":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 11:37:30.000000000","tz":0},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-21 12:00:32.000000000","tz":120},"subject":"target: Use \u0027bool\u0027 data type in mmu()","message":"target: Use \u0027bool\u0027 data type in mmu()\n\nThe variable is already used in some parts of the code as boolean value\nbut have the wrong data type.\n\nChange-Id: I50ccbf84c6f33a3034de989789c6b17312458ea8\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"325e6d38b5d3edb3563481b96c897c3dc6f84bd8":{"kind":"REWORK","_number":3,"created":"2025-08-02 12:55:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/89/8989/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/8989/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/3 \u0026\u0026 git checkout -b change-8989 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/8989/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a66e6fb43f1ff976d1a38edeb83caeacd06c4b80","subject":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 11:37:30.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-02 12:55:31.000000000","tz":0},"subject":"target: Use \u0027bool\u0027 data type in mmu()","message":"target: Use \u0027bool\u0027 data type in mmu()\n\nThe variable is already used in some parts of the code as boolean value\nbut have the wrong data type.\n\nChange-Id: I50ccbf84c6f33a3034de989789c6b17312458ea8\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8989\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"becb3dbcaa0ab528593866fa5014e1bcd1acb40c":{"kind":"REWORK","_number":1,"created":"2025-07-09 14:36:19.000000000","uploader":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/89/8989/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/8989/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/1 \u0026\u0026 git checkout -b change-8989 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/8989/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/8989/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f89bd4b49ff68297ade78b191ec95b32725c223","subject":"target: Use \u0027bool\u0027 data type for \u0027mmu_enabled\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 11:37:30.000000000","tz":0},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-07-09 14:33:50.000000000","tz":120},"subject":"target: Use \u0027bool\u0027 data type in mmu()","message":"target: Use \u0027bool\u0027 data type in mmu()\n\nThe variable is already used in some parts of the code as boolean value\nbut have the wrong data type.\n\nChange-Id: I50ccbf84c6f33a3034de989789c6b17312458ea8\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
