)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dc63d97036b85d54e8e109c6b42ae4f259487fcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f461e5ec_3960abc3","updated":"2025-07-09 15:06:48.000000000","message":"I\u0027m working at adding cache support on Cortex-m, and I already noticed this. Thanks for fixing it.\nThere are other two variables that could be converted to boolean, either here or in a separate patch.","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6f1858dd69cba5decbf67d1cf2d43b2afa46b9f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"309999ea_dbed1dd1","updated":"2025-07-09 23:17:23.000000000","message":"also here, as in 8988, there are places where the bool gets implicitly converted to int and becomes the index of an array.\nIt should be fixed","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e7cb756b88e35cc364c61ebfc73de7b1676383db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c364b1bb_170272fa","in_reply_to":"309999ea_dbed1dd1","updated":"2025-07-10 07:19:47.000000000","message":"Yes, I\u0027m aware of this implicit cast. My understanding is that it is perfectly fine and safe to do this. I assume it\u0027s more a coding style issue for you? How would you change it? Explicit cast to `int` like `foo[(int)bar]`? We could also introduce a function that returns `enabled` / `disabled` strings. Other files could also benefit from such a function.","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c2b9307a60be8608fb89bdfe6687a02150748306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cdc24391_a18cf0f6","in_reply_to":"c364b1bb_170272fa","updated":"2025-07-10 13:35:52.000000000","message":"I think adding the function is the cleaner way.\nMaybe taking the idea from Linux file\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/string_choices.h\nbut without copying it completely due to GPLv2.0-only license.\n\nToday in OpenOCD we have at least:\n32 ? \"enabled\" : \"disabled\"\n3 ? \"disabled\" : \"enabled\"\n20 ? \"read\" : \"write\"\n1 ? \"READ\" : \"WRITE\"\n3 ? \"write\" : \"read\"\n11 ? \"AP\" : \"DP\"\n11 ? \"FAULT\" : \"JUNK\"\n2 ? \"ir\" : \"dr\"\n8 ? \"IR\" : \"DR\"\n5 ? \"yes\" : \"no\"\n...","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"7fcccc63e1f12b03ad4d8385c4a05579c58e926a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"090a7826_4eeb3dc8","in_reply_to":"cdc24391_a18cf0f6","updated":"2025-07-21 12:07:19.000000000","message":"It was easier to fix it in a separate patch, see https://review.openocd.org/c/openocd/+/9007. Since the patches do not break anything I think this is appropriate.","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"8b30ac723a57d9b85fcb3b066fc24ae67c00a6ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec1e596d_2929f9e9","in_reply_to":"f461e5ec_3960abc3","updated":"2025-07-09 17:48:10.000000000","message":"Yep, I will change the variables in a separate patch.","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"}],"src/target/armv7a.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dc63d97036b85d54e8e109c6b42ae4f259487fcf","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"/* common cache information */"},{"line_number":60,"context_line":"struct armv7a_cache_common {"},{"line_number":61,"context_line":"\tint info;\t\t\t\t/* -1 invalid, else valid */"},{"line_number":62,"context_line":"\tint loc;\t\t\t\t/* level of coherency */"},{"line_number":63,"context_line":"\tuint32_t dminline;\t\t\t/* minimum d-cache linelen */"},{"line_number":64,"context_line":"\tuint32_t iminline;\t\t\t/* minimum i-cache linelen */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e4c14a28_814b12ce","line":61,"updated":"2025-07-09 15:06:48.000000000","message":"This is also badly used as a boolean.\nMaybe it can even be renamed as `bool valid` or `info_valid`","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"8b30ac723a57d9b85fcb3b066fc24ae67c00a6ae","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"/* common cache information */"},{"line_number":60,"context_line":"struct armv7a_cache_common {"},{"line_number":61,"context_line":"\tint info;\t\t\t\t/* -1 invalid, else valid */"},{"line_number":62,"context_line":"\tint loc;\t\t\t\t/* level of coherency */"},{"line_number":63,"context_line":"\tuint32_t dminline;\t\t\t/* minimum d-cache linelen */"},{"line_number":64,"context_line":"\tuint32_t iminline;\t\t\t/* minimum i-cache linelen */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"adc7a963_6b2b8b2b","line":61,"in_reply_to":"e4c14a28_814b12ce","updated":"2025-07-09 17:48:10.000000000","message":"Ack","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"}],"src/target/armv8.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dc63d97036b85d54e8e109c6b42ae4f259487fcf","unresolved":true,"context_lines":[{"line_number":151,"context_line":"};"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"struct armv8_cache_common {"},{"line_number":154,"context_line":"\tint info;"},{"line_number":155,"context_line":"\tint loc;"},{"line_number":156,"context_line":"\tuint32_t iminline;"},{"line_number":157,"context_line":"\tuint32_t dminline;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b96819f6_a01f2f5e","line":154,"updated":"2025-07-09 15:06:48.000000000","message":"Same here, this can be boolean and the name could be more representative.","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"8b30ac723a57d9b85fcb3b066fc24ae67c00a6ae","unresolved":false,"context_lines":[{"line_number":151,"context_line":"};"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"struct armv8_cache_common {"},{"line_number":154,"context_line":"\tint info;"},{"line_number":155,"context_line":"\tint loc;"},{"line_number":156,"context_line":"\tuint32_t iminline;"},{"line_number":157,"context_line":"\tuint32_t dminline;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2da6f162_346c8d90","line":154,"in_reply_to":"b96819f6_a01f2f5e","updated":"2025-07-09 17:48:10.000000000","message":"Ack","commit_id":"4867b41059001a2ab9724a84de7efd07796868c0"}]}