)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"a1f3c88c8906fa1fa390a741a38cb04a5aa3304a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure.ac: Remove useless --enable-verbose-usb-io"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"_DEBUG_USB_IO_ was not actually used anywhere."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1a98db7c7b03a89cc9347c0a66ec2106d2168c3f"},{"line_number":12,"context_line":"Signed-off-by: R. Diez \u003crdiez-2006@rd10.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fe10ea2b_64e250e5","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":18},"updated":"2025-07-20 09:11:32.000000000","message":"It was, in ft2232 driver (deprecated adapter driver that could use d2xx proprietary backend or libftdi), removed in cc2d4f015f72d7c30d613b50572eb9f31fac515a in Feb 2016.","commit_id":"304f475773cba241daaf6c44a54658a11c471495"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"87b964900f6b44b94d842c1a9c5b740ce4023c18","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure.ac: Remove useless --enable-verbose-usb-io"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"_DEBUG_USB_IO_ was not actually used anywhere."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1a98db7c7b03a89cc9347c0a66ec2106d2168c3f"},{"line_number":12,"context_line":"Signed-off-by: R. Diez \u003crdiez-2006@rd10.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"48fd621e_7d6861ea","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":18},"in_reply_to":"b1d40073_4119f294","updated":"2025-07-27 11:00:10.000000000","message":"Done","commit_id":"304f475773cba241daaf6c44a54658a11c471495"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d0324821799f734c690fabe2a23f56a64f806bcb","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure.ac: Remove useless --enable-verbose-usb-io"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"_DEBUG_USB_IO_ was not actually used anywhere."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1a98db7c7b03a89cc9347c0a66ec2106d2168c3f"},{"line_number":12,"context_line":"Signed-off-by: R. Diez \u003crdiez-2006@rd10.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b1d40073_4119f294","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":18},"in_reply_to":"fe10ea2b_64e250e5","updated":"2025-07-25 18:52:36.000000000","message":"Thanks Paul.\nRDiez, can you please update the commit message reporting that the config option is not used anymore?","commit_id":"304f475773cba241daaf6c44a54658a11c471495"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f286241c99a6290dc59b111595bb97771552751","unresolved":true,"context_lines":[{"line_number":7,"context_line":"configure.ac: Remove useless --enable-verbose-usb-io"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"_DEBUG_USB_IO_ was not actually used anywhere."},{"line_number":10,"context_line":"Its last user was the old ft2232 driver removed in Feb 2016 in:"},{"line_number":11,"context_line":"https://review.openocd.org/q/cc2d4f015f72d7c30d613b50572eb9f31fac515a"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1a98db7c7b03a89cc9347c0a66ec2106d2168c3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0f7adea2_56210ab1","line":10,"updated":"2025-07-27 14:39:17.000000000","message":"Don\u0027t put the link, but use this common format. Plus, the patch was merged in November:\n\nIts last user was the old ft2232 driver removed in Nov 2016 with commit cc2d4f015f72 (\"Remove since long deprecated ft2232 driver\").","commit_id":"7d95cdf25e71c8faeced2ed0f3cf435bd593545a"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"a024020e766bbe8a827ba98b9dfd5793549cc17e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"configure.ac: Remove useless --enable-verbose-usb-io"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"_DEBUG_USB_IO_ was not actually used anywhere."},{"line_number":10,"context_line":"Its last user was the old ft2232 driver removed in Feb 2016 in:"},{"line_number":11,"context_line":"https://review.openocd.org/q/cc2d4f015f72d7c30d613b50572eb9f31fac515a"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1a98db7c7b03a89cc9347c0a66ec2106d2168c3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"72e76ea9_777fd926","line":10,"in_reply_to":"0f7adea2_56210ab1","updated":"2025-07-27 15:53:34.000000000","message":"\u003e Don\u0027t put the link, but use this common format. Plus, the patch was merged in November:\n\u003e \n\u003e Its last user was the old ft2232 driver removed in Nov 2016 with commit cc2d4f015f72 (\"Remove since long deprecated ft2232 driver\").","commit_id":"7d95cdf25e71c8faeced2ed0f3cf435bd593545a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"9d5db44e6bb715ccd06ae8af09e9a99289a19a21","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"abd77b03_186eb63a","updated":"2025-07-20 08:44:45.000000000","message":"Configuration option --enable-verbose-usb-io sets _DEBUG_USB_IO_, which does not seem to be used anywhere, or am I missing something?\n\nI would also remove --enable-verbose, as after this patch, it is now the same as --enable-verbose-usb-comms.\n\nFurthermore, I would remove --enable-verbose-usb-comms from configure.ac and make it an OpenOCD command-line argument. The reason is, you shouldn\u0027t need to rebuild OpenOCD to turn some tracing on.\n\nThe same would also apply to --enable-malloc-logging / _DEBUG_FREE_SPACE_.","commit_id":"304f475773cba241daaf6c44a54658a11c471495"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f286241c99a6290dc59b111595bb97771552751","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2cd5634_94c7f050","in_reply_to":"abd77b03_186eb63a","updated":"2025-07-27 14:39:17.000000000","message":"`--enable-malloc-logging` / `_DEBUG_FREE_SPACE_` use `mallinfo2()`. I don\u0027t know if it is present in all the possible libc. Eventually we need to check in `configure.ac` if the libc supports it.\n\n`--enable-verbose-usb-comms` / `_DEBUG_USB_COMMS_` is not used by every driver, probably not used in a consistent way among them.\nIt could be interesting to move it in `src/jtag/drivers/libusb_helper.c` and convert every USB driver to use it... output consistent among drivers, but probably big rework!","commit_id":"304f475773cba241daaf6c44a54658a11c471495"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"a024020e766bbe8a827ba98b9dfd5793549cc17e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f14712a_fa53ae0c","in_reply_to":"d2cd5634_94c7f050","updated":"2025-07-27 15:53:34.000000000","message":"Done","commit_id":"304f475773cba241daaf6c44a54658a11c471495"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"a024020e766bbe8a827ba98b9dfd5793549cc17e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab9889d8_39240c6f","updated":"2025-07-27 15:53:34.000000000","message":"Commit message reworked as requested.","commit_id":"a6553be6ad352df62a8967e248c6df7a6d63f17b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f1e941d98aa6f85fe4cac58d55625bec69cb84c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"954de932_25bcfcde","updated":"2025-07-27 16:58:09.000000000","message":"Thanks!","commit_id":"a6553be6ad352df62a8967e248c6df7a6d63f17b"}]}
