)]}'
{"id":"openocd~master~Ia5da403054b6c9aa41184a4e092a74aa882a267d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002433":{"account":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"last_update":"2025-08-24 11:16:01.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-08-17 13:22:45.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Ia5da403054b6c9aa41184a4e092a74aa882a267d","subject":"tcl/target: add Rockchip RK3588 target","status":"MERGED","created":"2025-08-17 05:43:42.000000000","updated":"2025-08-24 11:16:01.000000000","submitted":"2025-08-24 11:16:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9013","meta_rev_id":"cc0090ec9824741c0f48d16c64e2a0f28e9609ba","_number":9013,"owner":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-24 11:16:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-24 11:16:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-17 05:43:52.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-08-17 05:44:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-17 08:39:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"e1fec66e792807e78f7c885a229629eb5293c7fb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"real_author":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"date":"2025-08-17 05:43:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ca9059b5d85a9948c1d3dbdb9d82601fb17fc003","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-17 05:44:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20784/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21651/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"d1b98994321911bf8dc8b39dd6bf209489e30957","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"real_author":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"date":"2025-08-17 06:00:21.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"70b8e0d285b2422eafe6c2c5e1ab10c8f9f60812","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-17 06:15:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20785/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21652/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"6c5116389a5dabc51198eb8a52e969958f000911","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-17 08:39:55.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d1aca8e40292f3c850d50258f0b27dfe91cf7d2c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"real_author":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"date":"2025-08-17 12:31:06.000000000","message":"Patch Set 3: Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"66e3eb2d7f7991f4897f46fa7313f46a35bcb087","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-17 12:46:18.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20788/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21655/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"2c6bded6a26b37b99f31d48be41e03fc70226822","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-17 13:22:45.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"11b47ecc9fdd49da1731cf2d470607cc26e48cd6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-24 11:15:57.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"cc0090ec9824741c0f48d16c64e2a0f28e9609ba","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-24 11:16:01.000000000","message":"Change has been successfully cherry-picked as 7e403d9d3be58b1965f230831ac7bf84d5371189","accounts_in_message":[],"_revision_number":4}],"current_revision":"7e403d9d3be58b1965f230831ac7bf84d5371189","revisions":{"4e106cb3ab1d9a1f50a2ada695d978194122985c":{"kind":"REWORK","_number":1,"created":"2025-08-17 05:43:42.000000000","uploader":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"ref":"refs/changes/13/9013/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/9013/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/1 \u0026\u0026 git checkout -b change-9013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/9013/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"Andreas Dannenberg","email":"andre@miauco.com","date":"2025-08-13 12:22:11.000000000","tz":540},"committer":{"name":"Andreas Dannenberg","email":"andre@miauco.com","date":"2025-08-17 05:43:26.000000000","tz":540},"subject":"tcl/target: add Rockchip RK3588 target","message":"tcl/target: add Rockchip RK3588 target\n\nChange-Id: Ia5da403054b6c9aa41184a4e092a74aa882a267d\nSigned-off-by: Andreas Dannenberg \u003candre@miauco.com\u003e\n"}},"c295b6f23d820f6ec4aadfb9316753584b89f7e5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-08-17 06:00:21.000000000","uploader":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"ref":"refs/changes/13/9013/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/9013/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/2 \u0026\u0026 git checkout -b change-9013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/9013/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"Andreas Dannenberg","email":"andre@miauco.com","date":"2025-08-13 12:22:11.000000000","tz":540},"committer":{"name":"Andreas Dannenberg","email":"andre@miauco.com","date":"2025-08-17 05:45:51.000000000","tz":540},"subject":"tcl/target: add Rockchip RK3588 target","message":"tcl/target: add Rockchip RK3588 target\n\nThe Rockchip RK3588 SoC is used in systems such as the GenBook RK3588\nopen-hardware laptop and the Coolpi CM5 compute module. This patch adds\nsupport for debbugging those. Tested using the ST-LINK/V2 debug adapter\nin SWD mode connected to the SDMMC_D2 (SWCLK) and SDMMC_D3 (SWDIO) pins\non the 50-pin J17 connector inside the GenBook RK3588 laptop.\n\nChange-Id: Ia5da403054b6c9aa41184a4e092a74aa882a267d\nSigned-off-by: Andreas Dannenberg \u003candre@miauco.com\u003e\n"}},"027e79f2d403abc3ab3d038ab049df731c01492d":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-08-17 12:31:06.000000000","uploader":{"_account_id":1002433,"name":"Andreas Dannenberg","display_name":"Andreas Dannenberg","email":"andre@miauco.com","username":"adannenb"},"ref":"refs/changes/13/9013/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/9013/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/3 \u0026\u0026 git checkout -b change-9013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/9013/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"Andreas Dannenberg","email":"andre@miauco.com","date":"2025-08-13 12:22:11.000000000","tz":540},"committer":{"name":"Andreas Dannenberg","email":"andre@miauco.com","date":"2025-08-17 12:31:06.000000000","tz":0},"subject":"tcl/target: add Rockchip RK3588 target","message":"tcl/target: add Rockchip RK3588 target\n\nThe Rockchip RK3588 SoC is used in systems such as the GenBook RK3588\nopen-hardware laptop and the Coolpi CM5 compute module. This patch adds\nsupport for debugging those. Tested using the ST-LINK/V2 debug adapter\nin SWD mode connected to the SDMMC_D2 (SWCLK) and SDMMC_D3 (SWDIO) pins\non the 50-pin J17 connector inside the GenBook RK3588 laptop.\n\nChange-Id: Ia5da403054b6c9aa41184a4e092a74aa882a267d\nSigned-off-by: Andreas Dannenberg \u003candre@miauco.com\u003e\n"},"description":"Edit commit message"},"7e403d9d3be58b1965f230831ac7bf84d5371189":{"kind":"REWORK","_number":4,"created":"2025-08-24 11:16:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/13/9013/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/9013/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/4 \u0026\u0026 git checkout -b change-9013 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/9013/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/9013/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"93f16eed4d4db379671293277e9b6e7d5aba6c9b","subject":"command: fix OpenOCD commands return value for next jimtcl"}],"author":{"name":"Andreas Dannenberg","email":"andre@miauco.com","date":"2025-08-13 12:22:11.000000000","tz":540},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-24 11:16:01.000000000","tz":0},"subject":"tcl/target: add Rockchip RK3588 target","message":"tcl/target: add Rockchip RK3588 target\n\nThe Rockchip RK3588 SoC is used in systems such as the GenBook RK3588\nopen-hardware laptop and the Coolpi CM5 compute module. This patch adds\nsupport for debugging those. Tested using the ST-LINK/V2 debug adapter\nin SWD mode connected to the SDMMC_D2 (SWCLK) and SDMMC_D3 (SWDIO) pins\non the 50-pin J17 connector inside the GenBook RK3588 laptop.\n\nChange-Id: Ia5da403054b6c9aa41184a4e092a74aa882a267d\nSigned-off-by: Andreas Dannenberg \u003candre@miauco.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9013\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}