)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ed1e6f3975acaf54bd2b4a0a7ebc977f8ec9d095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec18c501_c0e71738","updated":"2025-09-05 07:21:42.000000000","message":"Whoa! Great!\nOnly needs one minor improvement in the documentation.","commit_id":"c1846b47fc31c31281fb75d0d75bcac9bd36d716"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5cc56b7c60949aa3b2f030a995ed58b724c723fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a3b4bf97_0fba8840","updated":"2025-09-05 08:54:47.000000000","message":"Place the board file in a dedicated `easydevkits` vendor folder?","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"10fff38cb18f17d7e9c2b9403aa4d29733048429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cb5904cc_efdbb3ef","updated":"2025-09-05 08:34:52.000000000","message":"Thanks, that\u0027s fine for me.\nTomas?","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4d1b78469beac0f6c13c3a6cd7a7b6aab266deb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e03be0b_083d25ce","in_reply_to":"1c8ac363_0ca0ca1d","updated":"2025-09-27 15:18:50.000000000","message":"Yes, I underestimated Matthias as a vendor. Sorry!\nESP32-WROVER-E FTDI is probably compatible with the orig ESP DevKit, but no objections if Matthias submits an alias config file for it.\nThat\u0027s why I stopped the discussion. I\u0027m fine with merging this as is and no objections if configs move to vendor folders. It\u0027s up to Marc.","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1002195,"name":"Matthias Jentsch","display_name":"EasyDevKits","email":"info@easydevkits.com","username":"EasyDevKits"},"change_message_id":"d9efa15829d1dde1f2663b1da4142c2099f74cb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27b0e8dd_34129143","in_reply_to":"87e70daa_8ee2c455","updated":"2025-09-28 10:53:56.000000000","message":"Thanks a lot for the review and feedback.\nI’ve moved the board configuration files into a dedicated vendor folder and also added the configuration for the FTDI variant.\nI left out the dedicated interface configuration file for now, as it is currently only used by a single board, but I’m happy to revisit this if needed.","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1002195,"name":"Matthias Jentsch","display_name":"EasyDevKits","email":"info@easydevkits.com","username":"EasyDevKits"},"change_message_id":"56b12324d0f94ee004cd3b9d4b1aafb1ebdcb1c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bd836420_8a577325","in_reply_to":"9e03be0b_083d25ce","updated":"2025-09-27 16:23:13.000000000","message":"I would be glad to submit an alias config file for the ESP32-WROVER-E FTDI DevKit.\nFurthermore, I am planning to contribute additional EasyDevKits boards based on other Espressif chips next year.","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5a0b0295b24e582de0b4c4b4c47be5386f0ca8f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c8ac363_0ca0ca1d","in_reply_to":"a2547631_7ffff427","updated":"2025-09-27 14:42:58.000000000","message":"Is the discussion still pending?\nThe comment is \"Resolved\" but I don\u0027t see final answer/decision to proceed in the merge.\n\nMatthias,\nshould we expect new boards from your side?\nWhat about your ESP32-WROVER-E FTDI JTAG DevKit?","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d0a2dd46da55d4c59f003b4c4124a97a97fef34e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c396784d_1085f370","in_reply_to":"a3b4bf97_0fba8840","updated":"2025-09-05 09:01:41.000000000","message":"Wouldn\u0027t it be contra-productive for not so big vendors? What if we force folders for 2 and more items?","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5c531e18e531975e05f1140126db603d8724ddd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87e70daa_8ee2c455","in_reply_to":"bd836420_8a577325","updated":"2025-09-28 07:58:08.000000000","message":"I would suggest we stick to the current developer guide and place the config in a `easydevkit` vendor folder.\n\n@Matthias: See [1]. Please also change the filename accordingly. It is currently not obvious which board the file is for without taking a look at the docs inside. Example: `tcl/board/easydevkits/esp32-wrover-e-wch-jtag-devkit.cfg`. Same applies to the interface file. If this interface is only for a single board, I would suggest to omit the dedicated config.\n\n[1] https://openocd.org/doc/doxygen/html/config_files.html","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"a40940e3d8d3acccb88f6399641c4a6c18807519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a2547631_7ffff427","in_reply_to":"c396784d_1085f370","updated":"2025-09-05 09:06:49.000000000","message":"I don\u0027t thing so because then we have discussions about \"Is this vendor big enough?\". What if a vendor becomes big over time? Then we have to move files later. What is the problem with having two files in a folder? If we think a \"vendor\" is niche or it\u0027s just a hobby project we should consider not to accept configs at all. That\u0027s not the case here, just a general thought.","commit_id":"0918998d66de5fa1a3ca1480409bd0f9f4abf55b"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"dcd01a9409de56acd85cbbbd896874040d1fada5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c968f57a_c5b38a0d","updated":"2025-09-28 12:04:45.000000000","message":"Thanks!","commit_id":"dd52591cb6ed2686bfdf80f10065bb42bd552d63"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"279e744577c36379d7d7fe8b253aaf7ae451bf28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9868650a_54f49f9a","in_reply_to":"c968f57a_c5b38a0d","updated":"2025-09-28 12:26:24.000000000","message":"Thanks Matthias!","commit_id":"dd52591cb6ed2686bfdf80f10065bb42bd552d63"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ed1e6f3975acaf54bd2b4a0a7ebc977f8ec9d095","unresolved":true,"context_lines":[{"line_number":2586,"context_line":"@item A long SWD operation causes that USB host disconnects the adapter."},{"line_number":2587,"context_line":"@end itemize"},{"line_number":2588,"context_line":"@end itemize"},{"line_number":2589,"context_line":""},{"line_number":2590,"context_line":"This driver has these driver-specific command:"},{"line_number":2591,"context_line":""},{"line_number":2592,"context_line":"@deffn {Config Command} {ch347 vid_pid} [vid pid]+"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"635f2894_f0085026","line":2589,"updated":"2025-09-05 07:21:42.000000000","message":"Please add here or nearby something like:\n```\nThe driver supports activity LED through the generic\ncommand @ref{adapter gpio, @command{adapter gpio led}}.\n\n```","commit_id":"c1846b47fc31c31281fb75d0d75bcac9bd36d716"},{"author":{"_account_id":1002195,"name":"Matthias Jentsch","display_name":"EasyDevKits","email":"info@easydevkits.com","username":"EasyDevKits"},"change_message_id":"2934b98a2744ee9df9a7b0f4d1b278442d2a7b60","unresolved":false,"context_lines":[{"line_number":2586,"context_line":"@item A long SWD operation causes that USB host disconnects the adapter."},{"line_number":2587,"context_line":"@end itemize"},{"line_number":2588,"context_line":"@end itemize"},{"line_number":2589,"context_line":""},{"line_number":2590,"context_line":"This driver has these driver-specific command:"},{"line_number":2591,"context_line":""},{"line_number":2592,"context_line":"@deffn {Config Command} {ch347 vid_pid} [vid pid]+"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"5f3dcd13_2c089085","line":2589,"in_reply_to":"635f2894_f0085026","updated":"2025-09-05 08:30:20.000000000","message":"Thanks for the review. I\u0027ve added this in the documentation.","commit_id":"c1846b47fc31c31281fb75d0d75bcac9bd36d716"}],"tcl/interface/easydevkits-ch347.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3affb72751830b785240ff285522b6963e69786","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Configure activity LED"},{"line_number":15,"context_line":"# Note: The LED is active-low on GPIO4 (n4)."},{"line_number":16,"context_line":"ch347 activity_led n4"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# ---------------------------------------------------------------------------"},{"line_number":19,"context_line":"# JTAG speed (in kHz)"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c7fa5403_cdd01293","line":16,"updated":"2025-09-04 07:34:10.000000000","message":"Hummm, I missed this in the review of the driver ch347.\nShould be converted to `adapter gpio led ...`\nPossibly before v1.0.0 to avoid handling the deprecated command\nWhile not related to this patch, I keep this comment not resolved as an alert/reminder","commit_id":"2c3f6093f8447b414b6c8ab232a143485cd4f982"},{"author":{"_account_id":1002195,"name":"Matthias Jentsch","display_name":"EasyDevKits","email":"info@easydevkits.com","username":"EasyDevKits"},"change_message_id":"a0f1a94bafe40fd5d0e459d94b64280a70df9baa","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Configure activity LED"},{"line_number":15,"context_line":"# Note: The LED is active-low on GPIO4 (n4)."},{"line_number":16,"context_line":"ch347 activity_led n4"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# ---------------------------------------------------------------------------"},{"line_number":19,"context_line":"# JTAG speed (in kHz)"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6fe4e895_36e71803","line":16,"in_reply_to":"c7fa5403_cdd01293","updated":"2025-09-04 22:43:24.000000000","message":"I\u0027ve missed that also. But now I\u0027ve adjusted the ch347 driver to use the adapter gpio led command. So we can set this comment to resolved. Right?","commit_id":"2c3f6093f8447b414b6c8ab232a143485cd4f982"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3affb72751830b785240ff285522b6963e69786","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# Supported frequencies (kHz):"},{"line_number":29,"context_line":"#   469, 938, 1875, 3750, 7500, 15000, 30000, 60000"},{"line_number":30,"context_line":"# ---------------------------------------------------------------------------"},{"line_number":31,"context_line":"adapter speed 15000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ae099966_e73a389b","line":31,"updated":"2025-09-04 07:34:10.000000000","message":"Usually we put `adapter speed` in the board file, not in the interface, to take care of board limitations.\nDo you plan to upstream the board file of ESP32-WROVER-E WCH JTAG DevKit?","commit_id":"2c3f6093f8447b414b6c8ab232a143485cd4f982"},{"author":{"_account_id":1002195,"name":"Matthias Jentsch","display_name":"EasyDevKits","email":"info@easydevkits.com","username":"EasyDevKits"},"change_message_id":"a0f1a94bafe40fd5d0e459d94b64280a70df9baa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# Supported frequencies (kHz):"},{"line_number":29,"context_line":"#   469, 938, 1875, 3750, 7500, 15000, 30000, 60000"},{"line_number":30,"context_line":"# ---------------------------------------------------------------------------"},{"line_number":31,"context_line":"adapter speed 15000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3f568f5e_f6afce08","line":31,"in_reply_to":"ae099966_e73a389b","updated":"2025-09-04 22:43:24.000000000","message":"I\u0027ve added also the board file.","commit_id":"2c3f6093f8447b414b6c8ab232a143485cd4f982"}]}