)]}'
{"id":"openocd~master~I3f673b5e10f6b28a4a74881b8a06a71b58afb422","project":"openocd","branch":"master","hashtags":[],"change_id":"I3f673b5e10f6b28a4a74881b8a06a71b58afb422","subject":"rtos: linux: drop useless code","status":"MERGED","created":"2025-07-25 18:28:52.000000000","updated":"2025-09-06 08:30:08.000000000","submitted":"2025-09-06 08:30:08.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9036","meta_rev_id":"e2acd5645bdf995b90ee5d5e3f70b1481428c503","_number":9036,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-06 08:30:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-09-06 08:30:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-25 19:25:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-25 20:50:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"43e46ab76daff5a44dbed5cb4180df4eefaf36e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-25 18:28:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3bb11bdf930676d6cf5d972e0b20c4a17c005f36","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-25 20:50:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20626/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21491/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"febc1837dab2af8ca5f4348b011f70508e1c8ee7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-09-06 08:30:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e2acd5645bdf995b90ee5d5e3f70b1481428c503","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-09-06 08:30:08.000000000","message":"Change has been successfully cherry-picked as c5806c0ae18450ed3f9d4fccc477bf571d0408bd","accounts_in_message":[],"_revision_number":2}],"current_revision":"c5806c0ae18450ed3f9d4fccc477bf571d0408bd","revisions":{"c5806c0ae18450ed3f9d4fccc477bf571d0408bd":{"kind":"REWORK","_number":2,"created":"2025-09-06 08:30:08.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/9036/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/9036/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/2 \u0026\u0026 git checkout -b change-9036 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/9036/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"44b8d0f18645ace0c1a6d96957a80f1a8ee3ef67","subject":"flash: nor: jtagspi: invert the operands in check"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-27 23:09:22.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-09-06 08:30:08.000000000","tz":0},"subject":"rtos: linux: drop useless code","message":"rtos: linux: drop useless code\n\nSince the initial code merged in 2012, the last case of the switch\nhas a useless test on \u0027retval\u0027 that is not assigned in the case.\nSince \u0027retval\u0027 is initialized to ERROR_OK, the condition is always\nfalse.\n\nDrop the check on \u0027retval\u0027.\nWhile there, drop the useless parenthesis around the \u0027case\u0027 and\nadd the \u0027break\u0027 statement.\n\nChange-Id: I3f673b5e10f6b28a4a74881b8a06a71b58afb422\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9036\nTested-by: jenkins\n"}},"7a6da1761fe5dfdcbfe2fedea81a452430935dce":{"kind":"REWORK","_number":1,"created":"2025-07-25 18:28:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/9036/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/9036/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/1 \u0026\u0026 git checkout -b change-9036 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/9036/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/9036/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3cddf1bc443b7c4cee4eaa376f50b9dbc773859","subject":"flash: nor: jtagspi: invert the operands in check"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-27 23:09:22.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-25 18:28:18.000000000","tz":120},"subject":"rtos: linux: drop useless code","message":"rtos: linux: drop useless code\n\nSince the initial code merged in 2012, the last case of the switch\nhas a useless test on \u0027retval\u0027 that is not assigned in the case.\nSince \u0027retval\u0027 is initialized to ERROR_OK, the condition is always\nfalse.\n\nDrop the check on \u0027retval\u0027.\nWhile there, drop the useless parenthesis around the \u0027case\u0027 and\nadd the \u0027break\u0027 statement.\n\nChange-Id: I3f673b5e10f6b28a4a74881b8a06a71b58afb422\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}