)]}'
{"id":"openocd~master~I8149cf25f460326ba6666a9287c5c309e5d99488","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-09-06 08:31:06.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I8149cf25f460326ba6666a9287c5c309e5d99488","subject":"svf: factorize big switch case","status":"MERGED","created":"2025-07-25 18:28:52.000000000","updated":"2025-09-06 08:31:11.000000000","submitted":"2025-09-06 08:31:11.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9040","meta_rev_id":"1896fe751a4c9d925d95c83b8ec5b8a4d194a98e","_number":9040,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-06 08:31:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-09-06 08:31:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-25 19:48:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-25 21:28:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"78552a64070fc394a1c9089aee6222805408b104","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-25 18:28:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3c2f0d5e38cb65f18533e746b8e9e4f008588ffb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-25 21:28:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20630/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21494/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"5e428dbb3b529241f8e494a45d82cbdf75920955","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-26 08:26:31.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b6035fd554a3edebb510c1d5a21fff848e38cbcb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-26 08:46:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20635/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21501/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"7cf008f4094621695923945c869b31d2b45dc669","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-09-06 08:31:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1896fe751a4c9d925d95c83b8ec5b8a4d194a98e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-09-06 08:31:11.000000000","message":"Change has been successfully cherry-picked as 1c668a0a6b8c47be77de66222e1f2434f302f5d8","accounts_in_message":[],"_revision_number":3}],"current_revision":"1c668a0a6b8c47be77de66222e1f2434f302f5d8","revisions":{"1c668a0a6b8c47be77de66222e1f2434f302f5d8":{"kind":"REWORK","_number":3,"created":"2025-09-06 08:31:11.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/9040/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/9040/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/3 \u0026\u0026 git checkout -b change-9040 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/9040/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad8d96230d955fecc070b8dc1c7723e84667bb56","subject":"svf: prepare for aligning switch and case statements"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 21:43:11.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-09-06 08:31:11.000000000","tz":0},"subject":"svf: factorize big switch case","message":"svf: factorize big switch case\n\nFactorize function svf_run_command() by moving out of the \u0027case\u0027\nthe common code related to the label \u0027xxr_common\u0027.\n\nThe target is to drop later on the ugly label \u0027xxr_common\u0027 inside\nthe switch.\n\nApart for:\n- the function and local variables declaration,\n- the added function call in place of original code,\n- the reduced indentation in the new function,\nthis change is a dummy copy/paste with no code modification.\n\nChange-Id: I8149cf25f460326ba6666a9287c5c309e5d99488\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9040\nTested-by: jenkins\n"}},"d8dac019fcdb8fb48dc83c4a25f50e843e0ed559":{"kind":"REWORK","_number":2,"created":"2025-07-26 08:26:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/9040/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/9040/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/2 \u0026\u0026 git checkout -b change-9040 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/9040/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d301ed1d70e767bd397793390a5b99d047a7a58a","subject":"svf: prepare for aligning switch and case statements"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 21:43:11.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-26 08:25:56.000000000","tz":120},"subject":"svf: factorize big switch case","message":"svf: factorize big switch case\n\nFactorize function svf_run_command() by moving out of the \u0027case\u0027\nthe common code related to the label \u0027xxr_common\u0027.\n\nThe target is to drop later on the ugly label \u0027xxr_common\u0027 inside\nthe switch.\n\nApart for:\n- the function and local variables declaration,\n- the added function call in place of original code,\n- the reduced indentation in the new function,\nthis change is a dummy copy/paste with no code modification.\n\nChange-Id: I8149cf25f460326ba6666a9287c5c309e5d99488\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"31fcda3333748ce31b755393d0ac2d2693d7ce2f":{"kind":"REWORK","_number":1,"created":"2025-07-25 18:28:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/9040/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/9040/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/1 \u0026\u0026 git checkout -b change-9040 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/9040/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/9040/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d301ed1d70e767bd397793390a5b99d047a7a58a","subject":"svf: prepare for aligning switch and case statements"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 21:43:11.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-25 18:28:18.000000000","tz":120},"subject":"svf: factorize big switch case","message":"svf: factorize big switch case\n\nFactorize function svf_run_command() by moving out of the \u0027case\u0027\nthe common code related to the label \u0027xxr_common\u0027.\n\nThe target is to drop later on the ugly label \u0027xxr_common\u0027 inside\nthe switch.\n\nApart for:\n- the function and local variables declaration,\n- the added function call in place of original code,\n- the reduced indentation in the new function,\nthis change is a dummy copy/paste with no code modification.\n\nChange-Id: I8149cf25f460326ba6666a9287c5c309e5d99488\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}