)]}'
{"id":"openocd~master~I37cbc8aafaeb8aef7f083ee6f5afa9eae71e0cd9","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-09-06 08:31:41.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I37cbc8aafaeb8aef7f083ee6f5afa9eae71e0cd9","subject":"svf: rework svf_parse_cmd_string()","status":"MERGED","created":"2025-07-25 18:28:52.000000000","updated":"2025-09-06 08:31:46.000000000","submitted":"2025-09-06 08:31:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9042","meta_rev_id":"ce27bd8130c8362ae4ffb03310310298e1169dbf","_number":9042,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-06 08:31:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-06 08:31:46.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-09-06 08:31:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-25 20:35:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-25 21:52:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-07-27 11:42:43.000000000","updated_by":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"a83d9793cdfb4b458598bad84ee096f2ae1bcd6a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-25 18:28:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b3bd26b74003cd04fa84d99232dd006e732e73c0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-25 21:52:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20632/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21499/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f670729bf5babec6a92fe7cd9f7ee9e37a06e08e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-26 08:26:31.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.\n\nCopied Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"7ff89c7cd96801b0919072341bc141e228ced93c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-26 08:46:37.000000000","message":"Patch Set 2: -Verified","accounts_in_message":[],"_revision_number":2},{"id":"5cf6db80823de17dea4b2eaea83cf74e9dc4370c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-26 09:25:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20637/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21503/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4079ac2fe59254e860750148abfb1166ab41a2fe","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-07-27 11:42:43.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"634cd7878855e5fc8cd3b454294228762a5f91f8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-09-06 08:31:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ce27bd8130c8362ae4ffb03310310298e1169dbf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-09-06 08:31:46.000000000","message":"Change has been successfully cherry-picked as 880f2349153dfc701268f391d5289c2a3a530a54","accounts_in_message":[],"_revision_number":3}],"current_revision":"880f2349153dfc701268f391d5289c2a3a530a54","revisions":{"fa757d9fc31af99c2b4a5183a9a3b73efd2a75ff":{"kind":"REWORK","_number":1,"created":"2025-07-25 18:28:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/42/9042/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9042/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/1 \u0026\u0026 git checkout -b change-9042 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9042/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"19a08b49ea6816f0a8080bc17d8fceb055e8245f","subject":"svf: drop goto and label in switch statement"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 22:22:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-25 18:28:18.000000000","tz":120},"subject":"svf: rework svf_parse_cmd_string()","message":"svf: rework svf_parse_cmd_string()\n\nRework the function to drop the goto in the switch statement.\nWhile there, change some variable to boolean.\n\nChange-Id: I37cbc8aafaeb8aef7f083ee6f5afa9eae71e0cd9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"83b7451a57741764942ef481641b8946d40daa41":{"kind":"NO_CHANGE","_number":2,"created":"2025-07-26 08:26:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/42/9042/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9042/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/2 \u0026\u0026 git checkout -b change-9042 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9042/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ecc6ba57a21013a6b3a21455b98f5f95031cf813","subject":"svf: drop goto and label in switch statement"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 22:22:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-26 08:25:56.000000000","tz":120},"subject":"svf: rework svf_parse_cmd_string()","message":"svf: rework svf_parse_cmd_string()\n\nRework the function to drop the goto in the switch statement.\nWhile there, change some variable to boolean.\n\nChange-Id: I37cbc8aafaeb8aef7f083ee6f5afa9eae71e0cd9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"880f2349153dfc701268f391d5289c2a3a530a54":{"kind":"REWORK","_number":3,"created":"2025-09-06 08:31:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/42/9042/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9042/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/3 \u0026\u0026 git checkout -b change-9042 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9042/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9042/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c22e1eb3ce29620b78f379ca7e7d6e20d107bf44","subject":"svf: drop goto and label in switch statement"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-06-29 22:22:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-09-06 08:31:46.000000000","tz":0},"subject":"svf: rework svf_parse_cmd_string()","message":"svf: rework svf_parse_cmd_string()\n\nRework the function to drop the goto in the switch statement.\nWhile there, change some variable to boolean.\n\nChange-Id: I37cbc8aafaeb8aef7f083ee6f5afa9eae71e0cd9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9042\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
