)]}'
{"id":"openocd~master~I936e35adddc030ba7cec6e2fc0c7d3b1b5c4a863","project":"openocd","branch":"master","hashtags":[],"change_id":"I936e35adddc030ba7cec6e2fc0c7d3b1b5c4a863","subject":"target: allow events to be modified inside an event handler","status":"MERGED","created":"2025-07-29 14:30:16.000000000","updated":"2025-08-17 13:32:19.000000000","submitted":"2025-08-17 13:32:19.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9063","meta_rev_id":"b358c3c022f40613fe6b619b9ac63c68ea586a17","_number":9063,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-17 13:32:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-17 13:32:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-17 13:32:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-29 14:30:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-29 14:45:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-13 12:07:07.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"}],"messages":[{"id":"b21288dc68404dc11be104149217950d58c22199","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-07-29 14:30:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89395a4e9757e8a6e962854e3ca40b8371051438","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-07-29 14:45:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20668/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21534/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0723078ba4ce4fbc16458d69deac813d35c4774f","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-13 12:07:07.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f04e3be3afa8ee03b329761e8f8f4b916062f0b1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-17 13:32:15.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b358c3c022f40613fe6b619b9ac63c68ea586a17","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-17 13:32:19.000000000","message":"Change has been successfully cherry-picked as 8b4eb936dbd863191e75cb7d1567d75d13b1e231","accounts_in_message":[],"_revision_number":2}],"current_revision":"8b4eb936dbd863191e75cb7d1567d75d13b1e231","revisions":{"8b4eb936dbd863191e75cb7d1567d75d13b1e231":{"kind":"REWORK","_number":2,"created":"2025-08-17 13:32:19.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/9063/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/9063/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/2 \u0026\u0026 git checkout -b change-9063 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/9063/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"93c565e7b40cf27ec133da2ceababe7c5f994b28","subject":"tcl/target/max32690: Add max32690 support"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-29 14:14:38.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-17 13:32:19.000000000","tz":0},"subject":"target: allow events to be modified inside an event handler","message":"target: allow events to be modified inside an event handler\n\nThe code in an event handler can use the command \u0027$target_name\nconfigure\u0027 to add a new event or to remove or modify an existing\nevent.\nSuch operation impacts the list of event of the target and also\nmodify the event itself, causing OpenOCD to access memory already\ndeallocated or not anymore valid.\n\nUse the safe version of list_for_each_entry() to iterate on the\nlist of events.\nMake a local copy of the current event, to avoid issues if it gets\ndeallocated.\nUse Jim_IncrRefCount() to guarantee that the body of the event\nhandler don\u0027t gets deallocated when the event is removed.\n\nChange-Id: I936e35adddc030ba7cec6e2fc0c7d3b1b5c4a863\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9063\nReviewed-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nTested-by: jenkins\n"}},"0e4381206ef786705d12eddcf8475523396aaba6":{"kind":"REWORK","_number":1,"created":"2025-07-29 14:30:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/9063/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/9063/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/1 \u0026\u0026 git checkout -b change-9063 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/9063/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/9063/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6872f7e406ad74f366f55947d23becd5a5faca15","subject":"adapter/xds110: Hide \u0027(dis)connected\u0027 message"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-29 14:14:38.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-07-29 14:14:38.000000000","tz":120},"subject":"target: allow events to be modified inside an event handler","message":"target: allow events to be modified inside an event handler\n\nThe code in an event handler can use the command \u0027$target_name\nconfigure\u0027 to add a new event or to remove or modify an existing\nevent.\nSuch operation impacts the list of event of the target and also\nmodify the event itself, causing OpenOCD to access memory already\ndeallocated or not anymore valid.\n\nUse the safe version of list_for_each_entry() to iterate on the\nlist of events.\nMake a local copy of the current event, to avoid issues if it gets\ndeallocated.\nUse Jim_IncrRefCount() to guarantee that the body of the event\nhandler don\u0027t gets deallocated when the event is removed.\n\nChange-Id: I936e35adddc030ba7cec6e2fc0c7d3b1b5c4a863\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}