)]}'
{"src/helper/log.h":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"df796b19f0a5cce514eea3043098b783873714fc","unresolved":true,"context_lines":[{"line_number":97,"context_line":"/* Avoid fn call and building parameter list if we\u0027re not outputting the information."},{"line_number":98,"context_line":" * Matters on feeble CPUs for DEBUG/INFO statements that are involved frequently */"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#define LOG_LEVEL_IS(FOO)  ((debug_level) \u003e\u003d (FOO))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"#define LOG_DEBUG_IO(expr ...) \\"},{"line_number":103,"context_line":"\tdo { \\"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"deede26f_5f4bc02d","line":100,"updated":"2025-08-05 11:27:48.000000000","message":"The naming seems a bit misleading.\n\nI\u0027d expect that `LOG_LEVEL_IS(...)` checks for equality, and therefore the condition would not be met for more verbose log levels.\nI\u0027d suggest renaming the macro to something like `LOG_IS_ENABLED_FOR(...)`, similar to how it\u0027s named in Python [1].\n\nIf you agree, but would like for this to be addressed in a separate patch I can prepare such a patch either as a parent or as a child of this one.\n\n[1] https://docs.python.org/3/library/logging.html#logging.Logger.isEnabledFor","commit_id":"3304d3074bbacd4d8fcf2886ef0a0e28f92687f5"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"49dd1e5ecd993aca672f04c713b1d2baf1c2e871","unresolved":false,"context_lines":[{"line_number":97,"context_line":"/* Avoid fn call and building parameter list if we\u0027re not outputting the information."},{"line_number":98,"context_line":" * Matters on feeble CPUs for DEBUG/INFO statements that are involved frequently */"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#define LOG_LEVEL_IS(FOO)  ((debug_level) \u003e\u003d (FOO))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"#define LOG_DEBUG_IO(expr ...) \\"},{"line_number":103,"context_line":"\tdo { \\"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"910f1384_1457ea18","line":100,"in_reply_to":"1760acfc_04047857","updated":"2025-10-27 14:56:21.000000000","message":"Addressed in https://review.openocd.org/c/openocd/+/9191","commit_id":"3304d3074bbacd4d8fcf2886ef0a0e28f92687f5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c5c1cf55a82613c8bb99358ca2b25c5a3532d386","unresolved":true,"context_lines":[{"line_number":97,"context_line":"/* Avoid fn call and building parameter list if we\u0027re not outputting the information."},{"line_number":98,"context_line":" * Matters on feeble CPUs for DEBUG/INFO statements that are involved frequently */"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#define LOG_LEVEL_IS(FOO)  ((debug_level) \u003e\u003d (FOO))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"#define LOG_DEBUG_IO(expr ...) \\"},{"line_number":103,"context_line":"\tdo { \\"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1760acfc_04047857","line":100,"in_reply_to":"deede26f_5f4bc02d","updated":"2025-08-09 21:23:12.000000000","message":"I agree, the name is misleading.\nI have another patch for riscv https://review.openocd.org/c/openocd/+/9071\nmaybe should be fixed together.","commit_id":"3304d3074bbacd4d8fcf2886ef0a0e28f92687f5"}]}