)]}'
{"id":"openocd~master~I055025a1f8eb4abe50955607b3e89530dfd92af4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002432":{"account":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"last_update":"2025-11-24 10:52:10.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-11-24 10:52:04.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I055025a1f8eb4abe50955607b3e89530dfd92af4","subject":"jtag/drivers/jtag_dpi: fix wraparound bug in runtest","status":"MERGED","created":"2025-08-11 11:29:24.000000000","updated":"2025-11-24 10:52:10.000000000","submitted":"2025-11-24 10:52:10.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9078","meta_rev_id":"cba280baf5b103ec14fa4b93f68eda2c3ee72a00","_number":9078,"owner":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-24 10:52:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-11-24 10:52:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-11-24 10:52:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-24 10:52:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-11 11:29:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-08-11 11:45:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-11 12:46:15.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2025-08-11 14:57:24.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2025-09-05 07:26:22.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"fa6c384a7845212af406b172ac431714f56ca513","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"real_author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"date":"2025-08-11 11:29:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8dd11e5bb9dadfe5aef92f8e28c6d2e10a28df29","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-11 11:45:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20754/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21621/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"997afa6607bcb36e8a8172e79a951189431c8d03","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"real_author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"date":"2025-08-11 12:24:28.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"d5e7d6a7c3db3cfdb77518148006e337b1aae864","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-11 12:40:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20755/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21622/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8b454d2d3b348043efd2f20d6083440460405daf","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-08-11 12:46:15.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"86a2a4cb9374e27cadf2beb2630067f6022a7022","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-11 14:57:24.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"57ba3eb6ab37c72dae8ab0a61959b55d8ec62e17","author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"real_author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"date":"2025-09-04 17:41:12.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7733792a9d73148d86f6c862dd0ea49a06042f6e","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-09-05 07:26:22.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"323d0fa5fa3bf5cd984bc572cbd37de4ce617537","author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"real_author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"date":"2025-10-13 07:00:40.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"feaa358cfa8e0586b559836c6bdf0facf23a52e5","author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"real_author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"date":"2025-11-23 18:48:53.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a73d1caa1574c6e95d3de08228e6e746f06da06e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-11-24 10:52:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cba280baf5b103ec14fa4b93f68eda2c3ee72a00","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-11-24 10:52:10.000000000","message":"Change has been successfully cherry-picked as 7487fade751a70fe58f5ba106abc4ed5ecda8a8e","accounts_in_message":[],"_revision_number":3}],"current_revision":"7487fade751a70fe58f5ba106abc4ed5ecda8a8e","revisions":{"c11cfcd0293cf12181dd05e152b48f90993e70d2":{"kind":"REWORK","_number":1,"created":"2025-08-11 11:29:24.000000000","uploader":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"ref":"refs/changes/78/9078/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/9078/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/1 \u0026\u0026 git checkout -b change-9078 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/9078/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"NikLeberg","email":"niklaus.leuenb@gmail.com","date":"2025-08-11 11:19:08.000000000","tz":120},"committer":{"name":"NikLeberg","email":"niklaus.leuenb@gmail.com","date":"2025-08-11 11:19:08.000000000","tz":120},"subject":"jtag/drivers/jtag_dpi: fix wraparound bug in runtest","message":"jtag/drivers/jtag_dpi: fix wraparound bug in runtest\n\nCommit #0847a4d introduced bug when changing loop variable from `int` to\n`unsigned int`. Instead of getting negative and terminating the loop,\nthe value wraps around to `INT_MAX` and the loop never finishes.\n\nChange-Id: I055025a1f8eb4abe50955607b3e89530dfd92af4\nSigned-off-by: NikLeberg \u003cniklaus.leuenb@gmail.com\u003e\nFixes: 0847a4d\n"}},"7487fade751a70fe58f5ba106abc4ed5ecda8a8e":{"kind":"REWORK","_number":3,"created":"2025-11-24 10:52:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/78/9078/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/9078/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/3 \u0026\u0026 git checkout -b change-9078 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/9078/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"461af9b3abd1aeb94f047f990074b7e5d954fbea","subject":"rtt/tcl: fix format specifiers"}],"author":{"name":"NikLeberg","email":"niklaus.leuenb@gmail.com","date":"2025-08-11 11:19:08.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-11-24 10:52:10.000000000","tz":0},"subject":"jtag/drivers/jtag_dpi: fix wraparound bug in runtest","message":"jtag/drivers/jtag_dpi: fix wraparound bug in runtest\n\nCommit 0847a4d7fb98 (\"jtag/commands: Use \u0027unsigned int\u0027 data type\")\nintroduced bug when changing loop variable from `int` to `unsigned int`.\nInstead of getting negative and terminating the loop, the value wraps\naround to `INT_MAX` and the loop never finishes.\n\nChange-Id: I055025a1f8eb4abe50955607b3e89530dfd92af4\nSigned-off-by: NikLeberg \u003cniklaus.leuenb@gmail.com\u003e\nFixes: 0847a4d7fb98 (\"jtag/commands: Use \u0027unsigned int\u0027 data type\")\nReviewed-on: https://review.openocd.org/c/openocd/+/9078\nReviewed-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d9e9591febcba86b98c4c49b9aab2d991bc9ff4c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-08-11 12:24:28.000000000","uploader":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"ref":"refs/changes/78/9078/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/9078/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/2 \u0026\u0026 git checkout -b change-9078 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/9078/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/9078/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"NikLeberg","email":"niklaus.leuenb@gmail.com","date":"2025-08-11 11:19:08.000000000","tz":120},"committer":{"name":"niklaus.leuenb","email":"niklaus.leuenb@gmail.com","date":"2025-08-11 12:24:28.000000000","tz":0},"subject":"jtag/drivers/jtag_dpi: fix wraparound bug in runtest","message":"jtag/drivers/jtag_dpi: fix wraparound bug in runtest\n\nCommit 0847a4d7fb98 (\"jtag/commands: Use \u0027unsigned int\u0027 data type\")\nintroduced bug when changing loop variable from `int` to `unsigned int`.\nInstead of getting negative and terminating the loop, the value wraps\naround to `INT_MAX` and the loop never finishes.\n\nChange-Id: I055025a1f8eb4abe50955607b3e89530dfd92af4\nSigned-off-by: NikLeberg \u003cniklaus.leuenb@gmail.com\u003e\nFixes: 0847a4d7fb98 (\"jtag/commands: Use \u0027unsigned int\u0027 data type\")\n"},"description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}