)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c49929affb637c4531aad26737cc6ea5d3385cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9fa14c32_235ac7c8","updated":"2025-08-17 09:38:40.000000000","message":"Thanks for the patch, Marek.\nI don\u0027t run Windows PC. Can you please check my question below?","commit_id":"86982248ea2fa6358d3b0a8772dbaae96fff1cc4"}],"src/helper/replacements.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c49929affb637c4531aad26737cc6ea5d3385cb9","unresolved":true,"context_lines":[{"line_number":161,"context_line":"\t\twfds \u003d NULL;"},{"line_number":162,"context_line":"\tif (efds \u0026\u0026 efds-\u003efd_count \u003d\u003d 0)"},{"line_number":163,"context_line":"\t\tefds \u003d NULL;"},{"line_number":164,"context_line":"\tif (!rfds \u0026\u0026 !wfds \u0026\u0026 !efds \u0026\u0026 tv) {"},{"line_number":165,"context_line":"\t\tsleep(tv-\u003etv_sec);"},{"line_number":166,"context_line":"\t\tusleep(tv-\u003etv_usec);"},{"line_number":167,"context_line":"\t\treturn 0;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"33ed2c78_cf310fd0","line":164,"updated":"2025-08-17 09:38:40.000000000","message":"What happens in case of `tv \u003d\u003d NULL`.\nThe Linux `man pselect` reports:\n\u003e If the timeout parameter is a null pointer, then the call to pselect() or select() shall block indefinitely until at least one descriptor meets the specified criteria.\n\nClearly we don\u0027t want to wait forever when there is no test to allows the code to return.\nWill the call to `select()` below return error? Or we get stuck forever?","commit_id":"86982248ea2fa6358d3b0a8772dbaae96fff1cc4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0f7591f0b9bf8e000fb2e64becf7af56e454c939","unresolved":false,"context_lines":[{"line_number":161,"context_line":"\t\twfds \u003d NULL;"},{"line_number":162,"context_line":"\tif (efds \u0026\u0026 efds-\u003efd_count \u003d\u003d 0)"},{"line_number":163,"context_line":"\t\tefds \u003d NULL;"},{"line_number":164,"context_line":"\tif (!rfds \u0026\u0026 !wfds \u0026\u0026 !efds \u0026\u0026 tv) {"},{"line_number":165,"context_line":"\t\tsleep(tv-\u003etv_sec);"},{"line_number":166,"context_line":"\t\tusleep(tv-\u003etv_usec);"},{"line_number":167,"context_line":"\t\treturn 0;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"18d6b4bf_db6eab48","line":164,"in_reply_to":"1c36cd8b_82ba0f00","updated":"2025-08-18 13:59:05.000000000","message":"Thanks for testing it","commit_id":"86982248ea2fa6358d3b0a8772dbaae96fff1cc4"},{"author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"change_message_id":"5ee7829a2d74a41a66ac05335b51af33c5a60f94","unresolved":true,"context_lines":[{"line_number":161,"context_line":"\t\twfds \u003d NULL;"},{"line_number":162,"context_line":"\tif (efds \u0026\u0026 efds-\u003efd_count \u003d\u003d 0)"},{"line_number":163,"context_line":"\t\tefds \u003d NULL;"},{"line_number":164,"context_line":"\tif (!rfds \u0026\u0026 !wfds \u0026\u0026 !efds \u0026\u0026 tv) {"},{"line_number":165,"context_line":"\t\tsleep(tv-\u003etv_sec);"},{"line_number":166,"context_line":"\t\tusleep(tv-\u003etv_usec);"},{"line_number":167,"context_line":"\t\treturn 0;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1c36cd8b_82ba0f00","line":164,"in_reply_to":"33ed2c78_cf310fd0","updated":"2025-08-18 13:17:02.000000000","message":"Actually the Windows implementation (https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-select) states that WSAEINVAL is set as an error in these cases: \n\n\u003e The time-out value is not valid, or all three descriptor parameters were null.\n\nI actually submitted a PR to their documentation to update this, that it also fails if the descriptor parameters are empty.\n\nI did test this during debugging and yes, it does fail gracefully.","commit_id":"86982248ea2fa6358d3b0a8772dbaae96fff1cc4"}]}