)]}'
{"id":"openocd~master~I601878671caf4ae44e105d6a819251d2d96c607c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-08-18 13:59:05.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2025-08-24 11:16:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I601878671caf4ae44e105d6a819251d2d96c607c","subject":"replacements: make socket_select() work on Windows if no sockets are provided","status":"MERGED","created":"2025-08-14 08:07:00.000000000","updated":"2025-08-24 11:16:42.000000000","submitted":"2025-08-24 11:16:42.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9081","meta_rev_id":"f1b1c3456eff5bc1f975496c64edacc5dc394948","_number":9081,"owner":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-24 11:16:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-24 11:16:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-14 08:07:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-08-14 08:07:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-17 09:38:40.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-08-18 13:59:05.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"54ae8b7df31d9b524eecf5f5b312f9fae76846d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2025-08-14 08:07:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"21f058676f81e9b61264beee344ece7af3d80a1e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2025-08-14 08:07:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"60ff23173e715a92bf3eb10e59faa8f7aa7eb227","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-14 08:07:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20773/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/21640/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"2024b400719ecc6c53217fadc825c0a750f01fe6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-14 08:24:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20774/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21641/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e590b84e9a79a7aaa87831935034c747f7e4b28d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2025-08-14 12:01:35.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"7030fb39ced97a304264b6b2e4e08177ce0dbe8a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-14 12:16:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20775/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21642/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"c49929affb637c4531aad26737cc6ea5d3385cb9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-17 09:38:40.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"5ee7829a2d74a41a66ac05335b51af33c5a60f94","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2025-08-18 13:17:02.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"0f7591f0b9bf8e000fb2e64becf7af56e454c939","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-18 13:59:05.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3d544431457ed40e78a3b882a4baba0aef8563bc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-24 11:16:39.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f1b1c3456eff5bc1f975496c64edacc5dc394948","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-24 11:16:42.000000000","message":"Change has been successfully cherry-picked as 160e2343bd7ab4f3b5f2bd8c89535709cc4bf519","accounts_in_message":[],"_revision_number":4}],"current_revision":"160e2343bd7ab4f3b5f2bd8c89535709cc4bf519","revisions":{"160e2343bd7ab4f3b5f2bd8c89535709cc4bf519":{"kind":"REWORK","_number":4,"created":"2025-08-24 11:16:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/9081/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/9081/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/4 \u0026\u0026 git checkout -b change-9081 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/9081/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e403d9d3be58b1965f230831ac7bf84d5371189","subject":"tcl/target: add Rockchip RK3588 target"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-08-13 13:36:21.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-24 11:16:42.000000000","tz":0},"subject":"replacements: make socket_select() work on Windows if no sockets are provided","message":"replacements: make socket_select() work on Windows if no sockets are provided\n\nOn Windows 11, if select() is called with empty sets, it fails and\nreturns WSAINVAL. On POSIX this works fine.\n\nThis patch addresses it by detecting this case in OpenOCD replacements\nand returning 0 in these cases.\n\nThis fixes OpenOCD crash on Windows if no services are enabled\n(gdb server, tcl server and telnet server all disabled).\n\nChange-Id: I601878671caf4ae44e105d6a819251d2d96c607c\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9081\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"382180deaf6c6ede0de1f1da4c737b8108d25c8f":{"kind":"REWORK","_number":2,"created":"2025-08-14 08:07:34.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/81/9081/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/9081/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/2 \u0026\u0026 git checkout -b change-9081 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/9081/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-08-13 13:36:21.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-08-14 08:07:29.000000000","tz":120},"subject":"replacements: return 0 on Windows if no sockets are provided","message":"replacements: return 0 on Windows if no sockets are provided\n\nOn Windows 11, if select is called with empty sets, it fails and\nreturns WSAINVAL, on POSIX this works fine.\n\nThis patch addresses it by detecting this case in OpenOCD replacements\nand returning 0 in these cases.\n\nThis fixes Windows crash if no services are enabled.\n\nChange-Id: I601878671caf4ae44e105d6a819251d2d96c607c\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}},"86982248ea2fa6358d3b0a8772dbaae96fff1cc4":{"kind":"REWORK","_number":3,"created":"2025-08-14 12:01:35.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/81/9081/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/9081/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/3 \u0026\u0026 git checkout -b change-9081 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/9081/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-08-13 13:36:21.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-08-14 12:01:25.000000000","tz":120},"subject":"replacements: make socket_select() work on Windows if no sockets are provided","message":"replacements: make socket_select() work on Windows if no sockets are provided\n\nOn Windows 11, if select() is called with empty sets, it fails and\nreturns WSAINVAL. On POSIX this works fine.\n\nThis patch addresses it by detecting this case in OpenOCD replacements\nand returning 0 in these cases.\n\nThis fixes OpenOCD crash on Windows if no services are enabled\n(gdb server, tcl server and telnet server all disabled).\n\nChange-Id: I601878671caf4ae44e105d6a819251d2d96c607c\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}},"cf72ef7496164318fabc612d107b71395f4706e9":{"kind":"REWORK","_number":1,"created":"2025-08-14 08:07:00.000000000","uploader":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"ref":"refs/changes/81/9081/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/9081/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/1 \u0026\u0026 git checkout -b change-9081 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/9081/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/9081/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3061149545b2be806b9a382995a33f5a60af9555","subject":"flash: at91sam7: align format strings to types"}],"author":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-08-13 13:36:21.000000000","tz":120},"committer":{"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","date":"2025-08-14 07:56:37.000000000","tz":120},"subject":"replacements: return 0 on Windows if no sockets are provided","message":"replacements: return 0 on Windows if no sockets are provided\n\nOn Windows 11, if select is called with empty sets, it fails and\nreturns WSAINVAL, on POSIX this works fine.\n\nThis patch addresses it by detecting this case in OpenOCD replacements\nand returning 0 in these cases.\n\nThis fixes Windows crash if no services are enabled.\n\nChange-Id: I601878671caf4ae44e105d6a819251d2d96c607c\nSigned-off-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}