)]}'
{"id":"openocd~master~Ibd7aaeccdf4d7c9efe72aa71909aef83be5ecd27","project":"openocd","branch":"master","attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2025-10-22 12:22:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}}},"removed_from_attention_set":{"1001874":{"account":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"last_update":"2025-08-24 11:15:31.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-10-24 13:36:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-08-24 11:15:31.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibd7aaeccdf4d7c9efe72aa71909aef83be5ecd27","subject":"command: fix OpenOCD commands return value for next jimtcl","status":"MERGED","created":"2025-08-15 14:20:59.000000000","updated":"2025-10-24 13:36:21.000000000","submitted":"2025-08-24 11:15:31.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":16,"unresolved_comment_count":5,"has_review_started":true,"submission_id":"9084","meta_rev_id":"025a23f1658b4ab246228e918b876c87867d3d3e","_number":9084,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-08-24 11:15:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-08-24 11:15:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}],"reviewers":{"CC":[{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-15 14:20:59.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"state":"REVIEWER"},{"updated":"2025-08-15 14:25:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-08-15 14:49:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-15 15:50:34.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2025-09-28 13:35:03.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"CC"}],"messages":[{"id":"3da8dd64ac9a658b2bda544725648e33ad9c8acd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-15 14:20:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c31dc8a394cddface594a0b412156fcb149d5f91","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-15 14:49:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20780/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21647/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9b994262c7a5c720d91bb2a0a8e197a01b062eb3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-15 15:50:34.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0d04b51bca65ffd461b5904c0842b87f8c49dce2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-15 16:33:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20783/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21650/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ff9d394ebb5aad821801f660e7a80fe187c0a9c7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-24 11:15:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ee6fbae5685afe0e2b65677a95c442768fcf0c49","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-24 11:15:31.000000000","message":"Change has been successfully cherry-picked as 93f16eed4d4db379671293277e9b6e7d5aba6c9b","accounts_in_message":[],"_revision_number":3},{"id":"d50deff9d07f5f9bec087d6cf1e64f4ee808e7f4","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-25 12:56:15.000000000","message":"Patch Set 3:\n\n(6 comments)","accounts_in_message":[],"_revision_number":3},{"id":"eb594226f19bb26395c2f60e663f438dadbc0262","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-25 13:45:33.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"65513fa9e3239fe68caab7ec17ea2d9c63bcef8b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-08-27 16:21:13.000000000","message":"Patch Set 3:\n\n(5 comments)","accounts_in_message":[],"_revision_number":3},{"id":"d1ad133aedde6b7e8a7735c4f458f61a0e506b26","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-09-28 13:35:03.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b9b1f7e276fef768b2221512fd5a2f500ffb2a24","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-19 14:34:03.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c524d176b76c9170d27cd71eaf467a7d40049108","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-10-22 12:22:46.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"025a23f1658b4ab246228e918b876c87867d3d3e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-24 13:36:21.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision":"93f16eed4d4db379671293277e9b6e7d5aba6c9b","revisions":{"93f16eed4d4db379671293277e9b6e7d5aba6c9b":{"kind":"REWORK","_number":3,"created":"2025-08-24 11:15:31.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/84/9084/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/9084/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/3 \u0026\u0026 git checkout -b change-9084 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/9084/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7effc6f825fe8aacfb15ea198994b212f55897cb","subject":"helper: command: inline command_retval_set()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-15 12:53:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-24 11:15:31.000000000","tz":0},"subject":"command: fix OpenOCD commands return value for next jimtcl","message":"command: fix OpenOCD commands return value for next jimtcl\n\nJimTcl has been so far quite comfortable with new commands that\nreturn error codes not supported by JimTcl itself.\nThis has been exploited by OpenOCD, allowing the OpenOCD commands\nto return OpenOCD error codes mixed with JimTcl error code.\n\nWith the change [1] merged in JimTcl branch \u0027master\u0027 for 0.84, any\nnegative value returned by a command gets interpreted as a syntax\nerror detected at runtime by the command itself; JimTcl dumps the\ncorrect syntax and returns a valid JimTcl error code that replaces\nthe negative value.\nSince all OpenOCD error codes are negative values, they are all\ntaken as syntax errors by the new JimTcl. E.g.:\n\topenocd -c exit\ndumps\n\twrong # args: should be \"exit ...\"\n\nActually OpenOCD does not need the OpenOCD error code from the\ncommands, with the exception of the codes:\n[a] ERROR_COMMAND_SYNTAX_ERROR, used internally by the command\n    dispatcher, before returning to JimTcl;\n[b] ERROR_COMMAND_CLOSE_CONNECTION, to alert the telnet server\n    that the current connection should be closed.\n\nWith [a] already used internally, only [b] needs to be propagated\nthrough JimTcl and back to the OpenOCD caller.\n\nMap the OpenOCD error code ERROR_COMMAND_CLOSE_CONNECTION to the\nexisting JimTcl error code JIM_EXIT, originally used only by\nJimTcl \u0027exit\u0027 command.\n\nDetect JIM_EXIT in command_run_line() and return to the caller the\noriginal ERROR_COMMAND_CLOSE_CONNECTION.\n\nLet exec_command(), and also its caller jim_command_dispatch(),\nto only return JimTcl error codes. Rename it to report the change.\n\nModify the test suite as now a syntax error does not returns -601\nanymore.\n\nWhile there, drop the association key \"retval\" as it\u0027s not used.\n\nNote: after this change there is no real need to replace the\nJimTcl command \u0027exit\u0027 with the OpenOCD version as both produce the\nsame result. But I prefer keeping the code as is to mask any\nfuture change in the related JimTcl code.\n\nLink: https://github.com/msteveb/jimtcl/commit/5669e84aad22 [1]\nChange-Id: Ibd7aaeccdf4d7c9efe72aa71909aef83be5ecd27\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Andrzej Sierżęga \u003casier70@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9084\nTested-by: jenkins\n"}},"33c1a1c0e545c2cd5bb6c56972d0593955f5f070":{"kind":"REWORK","_number":2,"created":"2025-08-15 15:50:34.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/84/9084/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/9084/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/2 \u0026\u0026 git checkout -b change-9084 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/9084/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ba982b801aac7f883343040b5f008573d3d9d3a8","subject":"helper: command: inline command_retval_set()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-15 12:53:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-15 15:47:22.000000000","tz":120},"subject":"command: fix OpenOCD commands return value for next jimtcl","message":"command: fix OpenOCD commands return value for next jimtcl\n\nJimTcl has been so far quite comfortable with new commands that\nreturn error codes not supported by JimTcl itself.\nThis has been exploited by OpenOCD, allowing the OpenOCD commands\nto return OpenOCD error codes mixed with JimTcl error code.\n\nWith the change [1] merged in JimTcl branch \u0027master\u0027 for 0.84, any\nnegative value returned by a command gets interpreted as a syntax\nerror detected at runtime by the command itself; JimTcl dumps the\ncorrect syntax and returns a valid JimTcl error code that replaces\nthe negative value.\nSince all OpenOCD error codes are negative values, they are all\ntaken as syntax errors by the new JimTcl. E.g.:\n\topenocd -c exit\ndumps\n\twrong # args: should be \"exit ...\"\n\nActually OpenOCD does not need the OpenOCD error code from the\ncommands, with the exception of the codes:\n[a] ERROR_COMMAND_SYNTAX_ERROR, used internally by the command\n    dispatcher, before returning to JimTcl;\n[b] ERROR_COMMAND_CLOSE_CONNECTION, to alert the telnet server\n    that the current connection should be closed.\n\nWith [a] already used internally, only [b] needs to be propagated\nthrough JimTcl and back to the OpenOCD caller.\n\nMap the OpenOCD error code ERROR_COMMAND_CLOSE_CONNECTION to the\nexisting JimTcl error code JIM_EXIT, originally used only by\nJimTcl \u0027exit\u0027 command.\n\nDetect JIM_EXIT in command_run_line() and return to the caller the\noriginal ERROR_COMMAND_CLOSE_CONNECTION.\n\nLet exec_command(), and also its caller jim_command_dispatch(),\nto only return JimTcl error codes. Rename it to report the change.\n\nModify the test suite as now a syntax error does not returns -601\nanymore.\n\nWhile there, drop the association key \"retval\" as it\u0027s not used.\n\nNote: after this change there is no real need to replace the\nJimTcl command \u0027exit\u0027 with the OpenOCD version as both produce the\nsame result. But I prefer keeping the code as is to mask any\nfuture change in the related JimTcl code.\n\nLink: https://github.com/msteveb/jimtcl/commit/5669e84aad22 [1]\nChange-Id: Ibd7aaeccdf4d7c9efe72aa71909aef83be5ecd27\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Andrzej Sierżęga \u003casier70@gmail.com\u003e\n"}},"c23043752bd92b24a8d6434dc50d604826f70e15":{"kind":"REWORK","_number":1,"created":"2025-08-15 14:20:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/84/9084/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/84/9084/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/1 \u0026\u0026 git checkout -b change-9084 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/84/9084/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/84/9084/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"af4eef2668dee259ce3a0ca89ca78e0af38078a5","subject":"helper: command: inline command_retval_set()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-15 12:53:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-08-15 14:18:27.000000000","tz":120},"subject":"command: fix OpenOCD commands return value for next jimtcl","message":"command: fix OpenOCD commands return value for next jimtcl\n\nJimTcl has been so far quite comfortable with new commands that\nreturn error codes not supported by JimTcl itself.\nThis has been exploited by OpenOCD, allowing the OpenOCD commands\nto return OpenOCD error codes mixed with JimTcl error code.\n\nWith the change [1] merged in JimTcl branch \u0027master\u0027 for 0.84, any\nnegative value returned by a command gets interpreted as a syntax\nerror detected at runtime by the command itself; JimTcl dumps the\ncorrect syntax and returns a valid JimTcl error code that replaces\nthe negative value.\nSince all OpenOCD error codes are negative values, they are all\ntaken as syntax errors by the new JimTcl. E.g.:\n\topenocd -c exit\ndumps\n\twrong # args: should be \"exit ...\"\n\nActually OpenOCD does not need the OpenOCD error code from the\ncommands, with the exception of the codes:\n[a] ERROR_COMMAND_SYNTAX_ERROR, used internally by the command\n    dispatcher, before returning to JimTcl;\n[b] ERROR_COMMAND_CLOSE_CONNECTION, to alert the telnet server\n    that the current connection should be closed.\n\nWith [a] already used internally, only [b] needs to be propagated\nthrough JimTcl and back to the OpenOCD caller.\n\nMap the OpenOCD error code ERROR_COMMAND_CLOSE_CONNECTION to the\nexisting JimTcl error code JIM_EXIT, originally used only by\nJimTcl \u0027exit\u0027 command.\n\nDetect JIM_EXIT in command_run_line() and return to the caller the\noriginal ERROR_COMMAND_CLOSE_CONNECTION.\n\nLet exec_command(), and also its caller jim_command_dispatch(),\nto only return JimTcl error codes. Rename it to report the change.\n\nWhile there, drop the association key \"retval\" as it\u0027s not used.\n\nNote: after this change there is no real need to replace the\nJimTcl command \u0027exit\u0027 with the OpenOCD version as both produce the\nsame result. But I prefer keeping the code as is to mask any\nfuture change in the related JimTcl code.\n\nLink: https://github.com/msteveb/jimtcl/commit/5669e84aad22 [1]\nChange-Id: Ibd7aaeccdf4d7c9efe72aa71909aef83be5ecd27\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Andrzej Sierżęga \u003casier70@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}