)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"4a1b22632da6aec96f6a3c774b13aa1b9ae30641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36747772_d766d231","updated":"2025-08-25 15:47:06.000000000","message":"Thanks for the patch!\n\nI have a minor suggestion how to further simplify breakpoint/watchpoint interface. Please, take a look.","commit_id":"c65fc58dffad01186d5ec29b498e35d24bd1cd89"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"c564c5bcb1d874552601575886a684e1d7c72a59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0c077b5_95e927f8","updated":"2025-08-26 11:22:04.000000000","message":"Please note, there is a conflict with 8487 [1].\n\nI can rebase 8487 on top of this one, however merging this after 8487 will reduce the diff so perhaps it is preferable?\n\nIn any case I would be very happy if 8487 is revived, so could you please take a look and leave a comment if you have the time?\n\n1: https://review.openocd.org/c/openocd/+/8487","commit_id":"b2d8128235621d36129ec771dd1539d8aea4a92c"},{"author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"change_message_id":"2049e5e70975886bd143375a7489b45909cac520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a02c934_139e834d","in_reply_to":"f0c077b5_95e927f8","updated":"2025-08-27 07:59:36.000000000","message":"ah, I missed that change request, that would also fix the original issue as SMP-aware rwp is used instead of watchpoint_clear_target","commit_id":"b2d8128235621d36129ec771dd1539d8aea4a92c"}],"src/target/breakpoints.c":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"4a1b22632da6aec96f6a3c774b13aa1b9ae30641","unresolved":true,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"int breakpoint_clear_target(struct target *target)"},{"line_number":471,"context_line":"{"},{"line_number":472,"context_line":"\treturn breakpoint_watchpoint_remove_all(target, BREAKPOINT);"},{"line_number":473,"context_line":"}"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"struct breakpoint *breakpoint_find(struct target *target, target_addr_t address)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"16b74db4_d87f05a8","line":472,"updated":"2025-08-25 15:47:06.000000000","message":"AFAIU, `breakpoint_clear_target()` and `watchpoint_clear_target()` are only used in `gdb_new_connection()` in `src/server/gdb_server.c`.\n\nI\u0027d suggest just dropping the `breakpoint_clear_target()` and `watchpoint_clear_target()` and replacing them with a call to `breakpoint_remove_all()/watchpoint_remove_all()` at the only callsite.","commit_id":"c65fc58dffad01186d5ec29b498e35d24bd1cd89"},{"author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"change_message_id":"9a0fafb565c1db56cc0ac26ddafd357927f9693b","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"int breakpoint_clear_target(struct target *target)"},{"line_number":471,"context_line":"{"},{"line_number":472,"context_line":"\treturn breakpoint_watchpoint_remove_all(target, BREAKPOINT);"},{"line_number":473,"context_line":"}"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"struct breakpoint *breakpoint_find(struct target *target, target_addr_t address)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"57cdb35f_c7af19ec","line":472,"in_reply_to":"16b74db4_d87f05a8","updated":"2025-08-26 00:01:50.000000000","message":"Thanks for the suggestion, seems better this way!","commit_id":"c65fc58dffad01186d5ec29b498e35d24bd1cd89"}]}