)]}'
{"id":"openocd~master~I8e85dbc66fd3e596990d631ed2aed22959a8ca60","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001803":{"account":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"last_update":"2025-09-30 07:22:37.000000000","reason":"Change was submitted"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-09-30 07:22:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8e85dbc66fd3e596990d631ed2aed22959a8ca60","subject":"target/breakpoints: drop duplicate breakpoint/watchpoint \"clear_target\" functions","status":"MERGED","created":"2025-08-19 10:16:41.000000000","updated":"2025-09-30 07:22:37.000000000","submitted":"2025-09-30 07:22:37.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9086","meta_rev_id":"b4300b9d747d7a6ba56dcb41a45938ae6fa7ee6d","_number":9086,"owner":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-30 07:22:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-09-30 07:22:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-30 07:22:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-19 10:16:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-08-19 10:17:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-08-25 07:55:18.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2025-08-25 07:55:18.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"state":"CC"},{"updated":"2025-08-25 07:55:18.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"CC"},{"updated":"2025-08-25 15:47:06.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2025-09-23 15:54:28.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"c732f60a2cd7fd63627caf6c2e0d29f60ed37379","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-08-19 10:16:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b727c134165b2bc764b3fd217063d9c84608211","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-19 10:17:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20796/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21663/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"5eb051672200861742a368cc5c2f613e92b85cdf","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-19 23:39:06.000000000","message":"Patch Set 1: -Verified","accounts_in_message":[],"_revision_number":1},{"id":"11717e1b5a260f3dcb51271d781c6f56fa623bc8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-19 23:54:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20806/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21673/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4a1b22632da6aec96f6a3c774b13aa1b9ae30641","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-25 15:47:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"444c65ce3bb21d211cc27e3edd73af79658fbebe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-08-25 23:58:10.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9a0fafb565c1db56cc0ac26ddafd357927f9693b","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-08-26 00:01:50.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d71f4d558c2145d7157cc40363227b2f1e802f54","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-08-26 00:30:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20826/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21693/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"84fdfe7a273004571f54cc477e7847ab7ab1402a","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-26 11:06:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c564c5bcb1d874552601575886a684e1d7c72a59","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-08-26 11:22:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2049e5e70975886bd143375a7489b45909cac520","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-08-27 07:59:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"05f8868b7136ce9113523414d518f8e82db4336c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-09-23 15:54:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b4300b9d747d7a6ba56dcb41a45938ae6fa7ee6d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-09-30 07:22:37.000000000","message":"Change has been successfully cherry-picked as e5888bda38f4952e2ae92f7dc5b25fc9a2d1c2b3","accounts_in_message":[],"_revision_number":3}],"current_revision":"e5888bda38f4952e2ae92f7dc5b25fc9a2d1c2b3","revisions":{"e5888bda38f4952e2ae92f7dc5b25fc9a2d1c2b3":{"kind":"REWORK","_number":3,"created":"2025-09-30 07:22:37.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/86/9086/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/9086/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/3 \u0026\u0026 git checkout -b change-9086 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/9086/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"896738264e92b74a17250dab639999a2743d0b7c","subject":"jtag/drivers/cmsis_dap_tcp: fix socket handling for Windows"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-08-18 20:05:55.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-09-30 07:22:37.000000000","tz":0},"subject":"target/breakpoints: drop duplicate breakpoint/watchpoint \"clear_target\" functions","message":"target/breakpoints: drop duplicate breakpoint/watchpoint \"clear_target\" functions\n\nWe need to cleanup watchpoints on all targets in SMP group when GDB\nconnects. Otherwise, the targets will not be consistent.\nOnce thats fixed, both *_clear_target functions clearly duplicate\nthe corresponding *_remove_all functions.\n\nChange-Id: I8e85dbc66fd3e596990d631ed2aed22959a8ca60\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9086\nReviewed-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"b2d8128235621d36129ec771dd1539d8aea4a92c":{"kind":"REWORK","_number":2,"created":"2025-08-25 23:58:10.000000000","uploader":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"ref":"refs/changes/86/9086/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/9086/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/2 \u0026\u0026 git checkout -b change-9086 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/9086/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68b6d3ad477b45a54282571ebd4ed8a53cf7dd90","subject":"jtag/driver/angie: Update Angie probe driver"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-08-18 20:05:55.000000000","tz":120},"committer":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-08-25 23:56:24.000000000","tz":120},"subject":"target/breakpoints: drop duplicate breakpoint/watchpoint \"clear_target\" functions","message":"target/breakpoints: drop duplicate breakpoint/watchpoint \"clear_target\" functions\n\nWe need to cleanup watchpoints on all targets in SMP group when GDB\nconnects. Otherwise, the targets will not be consistent.\nOnce thats fixed, both *_clear_target functions clearly duplicate\nthe corresponding *_remove_all functions.\n\nChange-Id: I8e85dbc66fd3e596990d631ed2aed22959a8ca60\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\n"}},"c65fc58dffad01186d5ec29b498e35d24bd1cd89":{"kind":"REWORK","_number":1,"created":"2025-08-19 10:16:41.000000000","uploader":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"ref":"refs/changes/86/9086/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/9086/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/1 \u0026\u0026 git checkout -b change-9086 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/9086/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/9086/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68b6d3ad477b45a54282571ebd4ed8a53cf7dd90","subject":"jtag/driver/angie: Update Angie probe driver"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-08-18 20:05:55.000000000","tz":120},"committer":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-08-18 20:52:26.000000000","tz":120},"subject":"target/breakpoints: account for SMP in watchpoint_clear_target","message":"target/breakpoints: account for SMP in watchpoint_clear_target\n\nWe need to cleanup watchpoints on all targets in SMP group when GDB\nconnects. Otherwise, the targets will not be consistent.\nOnce thats fixed, both *_clear_target functions clearly duplicate\nthe corresponding *_remove_all functions, and we can reuse the same\nhelper function to simplify.\n\nChange-Id: I8e85dbc66fd3e596990d631ed2aed22959a8ca60\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}