)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002405,"name":"Lucien Buchmann","email":"lucien.buchmann@dufour.aero","username":"lucien"},"change_message_id":"f4f98f433f428a230756091f9819acf98f1855f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8f0e49b_c3e3e99b","updated":"2025-08-27 12:41:44.000000000","message":"I know it is just a small change, but hopefully useful.\nI used ARRAY_SIZE(context) to set the loop variable limit.","commit_id":"4df2fa6162df8cafa444fb08e1cb2c0d62a17526"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"cad7a10d4d7a035646c5bc1a1628154b7761b10c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4b84774_365899b8","updated":"2025-09-24 07:26:18.000000000","message":"Thanks for the patch, Lucien!","commit_id":"67b5c972e365522f8e8beaaa4287f710504de4c1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"cc864a3bb1c14b79f81ea988263a996af00efa25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c16ff605_b7962d0e","updated":"2025-09-26 07:43:02.000000000","message":"Thanks!","commit_id":"76ead487e966f2457725f63e6d450f58263fc05b"},{"author":{"_account_id":1002405,"name":"Lucien Buchmann","email":"lucien.buchmann@dufour.aero","username":"lucien"},"change_message_id":"5af4a8437b68b23942973b06ce31dd8d1f7b5549","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9e123aa1_95ceec44","updated":"2025-09-26 07:47:50.000000000","message":"maybe like this? 😊","commit_id":"76ead487e966f2457725f63e6d450f58263fc05b"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"0102ebda9864678b70f24dd7170ea2045bdfd2ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"154e7b79_c7ba4eb8","in_reply_to":"9e123aa1_95ceec44","updated":"2025-09-26 08:28:15.000000000","message":"Thanks!","commit_id":"76ead487e966f2457725f63e6d450f58263fc05b"}],"src/target/armv4_5.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"cad7a10d4d7a035646c5bc1a1628154b7761b10c","unresolved":true,"context_lines":[{"line_number":680,"context_line":"\tcache-\u003ereg_list \u003d reg_list;"},{"line_number":681,"context_line":"\tcache-\u003enum_regs \u003d 0;"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"\tfor (int i \u003d 0; i \u003c num_core_regs; i++) {"},{"line_number":684,"context_line":"\t\t/* Skip registers this core doesn\u0027t expose */"},{"line_number":685,"context_line":"\t\tif (arm_core_regs[i].mode \u003d\u003d ARM_MODE_MON"},{"line_number":686,"context_line":"\t\t\t\u0026\u0026 arm-\u003ecore_type !\u003d ARM_CORE_TYPE_SEC_EXT"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"854dd58b_e70c49b6","line":683,"range":{"start_line":683,"start_character":21,"end_line":683,"end_character":34},"updated":"2025-09-24 07:26:18.000000000","message":"If you touch this, I have feeling that `num_regs` and `num_core_regs` should be converted to unsigned int too. See `struct reg_cache` definition.","commit_id":"67b5c972e365522f8e8beaaa4287f710504de4c1"},{"author":{"_account_id":1002405,"name":"Lucien Buchmann","email":"lucien.buchmann@dufour.aero","username":"lucien"},"change_message_id":"5af4a8437b68b23942973b06ce31dd8d1f7b5549","unresolved":false,"context_lines":[{"line_number":680,"context_line":"\tcache-\u003ereg_list \u003d reg_list;"},{"line_number":681,"context_line":"\tcache-\u003enum_regs \u003d 0;"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"\tfor (int i \u003d 0; i \u003c num_core_regs; i++) {"},{"line_number":684,"context_line":"\t\t/* Skip registers this core doesn\u0027t expose */"},{"line_number":685,"context_line":"\t\tif (arm_core_regs[i].mode \u003d\u003d ARM_MODE_MON"},{"line_number":686,"context_line":"\t\t\t\u0026\u0026 arm-\u003ecore_type !\u003d ARM_CORE_TYPE_SEC_EXT"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"cef1cd04_4a703eb2","line":683,"range":{"start_line":683,"start_character":21,"end_line":683,"end_character":34},"in_reply_to":"4df23f42_c138f5ed","updated":"2025-09-26 07:47:50.000000000","message":"Done","commit_id":"67b5c972e365522f8e8beaaa4287f710504de4c1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"92af725e5df7685259d3809f731fdb4def354958","unresolved":true,"context_lines":[{"line_number":680,"context_line":"\tcache-\u003ereg_list \u003d reg_list;"},{"line_number":681,"context_line":"\tcache-\u003enum_regs \u003d 0;"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"\tfor (int i \u003d 0; i \u003c num_core_regs; i++) {"},{"line_number":684,"context_line":"\t\t/* Skip registers this core doesn\u0027t expose */"},{"line_number":685,"context_line":"\t\tif (arm_core_regs[i].mode \u003d\u003d ARM_MODE_MON"},{"line_number":686,"context_line":"\t\t\t\u0026\u0026 arm-\u003ecore_type !\u003d ARM_CORE_TYPE_SEC_EXT"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"772a68dc_b99215d6","line":683,"range":{"start_line":683,"start_character":21,"end_line":683,"end_character":34},"in_reply_to":"5110a593_09371527","updated":"2025-09-24 09:01:31.000000000","message":"Marc, I\u0027m slightly against using `size_t` for variables where the native `unsigned int` is clearly long enough. Well since OpenOCD probably does not compile on any 16-bit host, the `size_t` aka `unsigned long int` are mostly the same size as `unsigned int` - but printf type specifiers differs, code authors need to track which type to use.\nI would prefer to follow C-style guide:\n\u003e use native types (int or unsigned int ) if the type (size) is not important","commit_id":"67b5c972e365522f8e8beaaa4287f710504de4c1"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"958f1ab79034923372e88e543b3f21fbd2c8a51a","unresolved":true,"context_lines":[{"line_number":680,"context_line":"\tcache-\u003ereg_list \u003d reg_list;"},{"line_number":681,"context_line":"\tcache-\u003enum_regs \u003d 0;"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"\tfor (int i \u003d 0; i \u003c num_core_regs; i++) {"},{"line_number":684,"context_line":"\t\t/* Skip registers this core doesn\u0027t expose */"},{"line_number":685,"context_line":"\t\tif (arm_core_regs[i].mode \u003d\u003d ARM_MODE_MON"},{"line_number":686,"context_line":"\t\t\t\u0026\u0026 arm-\u003ecore_type !\u003d ARM_CORE_TYPE_SEC_EXT"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4df23f42_c138f5ed","line":683,"range":{"start_line":683,"start_character":21,"end_line":683,"end_character":34},"in_reply_to":"772a68dc_b99215d6","updated":"2025-09-24 09:19:02.000000000","message":"Absolutely fine for me, I only have an allergy if signedness is not correct ;)","commit_id":"67b5c972e365522f8e8beaaa4287f710504de4c1"},{"author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"46c941a529628015202006641485243c6b1b9477","unresolved":true,"context_lines":[{"line_number":680,"context_line":"\tcache-\u003ereg_list \u003d reg_list;"},{"line_number":681,"context_line":"\tcache-\u003enum_regs \u003d 0;"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"\tfor (int i \u003d 0; i \u003c num_core_regs; i++) {"},{"line_number":684,"context_line":"\t\t/* Skip registers this core doesn\u0027t expose */"},{"line_number":685,"context_line":"\t\tif (arm_core_regs[i].mode \u003d\u003d ARM_MODE_MON"},{"line_number":686,"context_line":"\t\t\t\u0026\u0026 arm-\u003ecore_type !\u003d ARM_CORE_TYPE_SEC_EXT"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5110a593_09371527","line":683,"range":{"start_line":683,"start_character":21,"end_line":683,"end_character":34},"in_reply_to":"854dd58b_e70c49b6","updated":"2025-09-24 08:12:13.000000000","message":"Yes, please change all to `unsigned int` or (if appropriate) `size_t` for return values of `ARRAY_SIZE()`.","commit_id":"67b5c972e365522f8e8beaaa4287f710504de4c1"}]}