)]}'
{"id":"openocd~master~I0c72ff52340f546a5f635663a8fde28c99176d1b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001803":{"account":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"last_update":"2025-09-12 16:39:52.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-09-08 15:56:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}},"1002413":{"account":{"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"},"last_update":"2025-09-08 16:02:47.000000000","reason":"\u003cGERRIT_ACCOUNT_1002413\u003e replied on the change","reason_account":{"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"}}},"hashtags":[],"change_id":"I0c72ff52340f546a5f635663a8fde28c99176d1b","subject":"jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend","status":"MERGED","created":"2025-09-08 14:16:33.000000000","updated":"2025-09-12 16:39:52.000000000","submitted":"2025-09-12 16:39:52.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9115","meta_rev_id":"41372edb40f234bd883c2e82797c95d60875d547","_number":9115,"owner":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-12 16:39:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-09-12 16:39:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-09-12 16:39:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-08 14:16:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-09-08 14:17:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-09-08 15:11:42.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"CC"},{"updated":"2025-09-08 15:11:42.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2025-09-08 15:11:42.000000000","updated_by":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"reviewer":{"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"},"state":"REVIEWER"}],"messages":[{"id":"eb3e8c8bb3505ec76f3ac2dcd4e5a1e8d2b83f83","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-09-08 14:16:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4e27e9ef87de711edf647f6fb5b4d8bf9a5bc31e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-09-08 14:17:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20879/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21746/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"9ab96ee79b74aaa6d3df22387f534479deb92922","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"real_author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"date":"2025-09-08 14:23:51.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5a6ee11ca83febbe5910f26bd0ead389c406e0ef","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-09-08 15:08:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20881/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21748/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"51fff6e73043c40c5216ad39649d485b04fbe247","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-09-08 15:56:51.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"593e6b90d3cc9a43c27edb0315e9d7d515c8c64d","author":{"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"},"real_author":{"_account_id":1002413,"name":"Brian Kuschak","email":"bkuschak@gmail.com","username":"bkuschak"},"date":"2025-09-08 16:02:47.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"859f0ef836922024b00b3be40ef0959efd48b297","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-09-08 16:30:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"41372edb40f234bd883c2e82797c95d60875d547","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-09-12 16:39:52.000000000","message":"Change has been successfully cherry-picked as a6752a1671f7387ee3232bf84fe27a3746a55ac9","accounts_in_message":[],"_revision_number":3}],"current_revision":"a6752a1671f7387ee3232bf84fe27a3746a55ac9","revisions":{"3bfdb4deddf311395ba9dd931086c31d2af2f3c0":{"kind":"REWORK","_number":1,"created":"2025-09-08 14:16:33.000000000","uploader":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"ref":"refs/changes/15/9115/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/9115/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/1 \u0026\u0026 git checkout -b change-9115 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/9115/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9279a489d466529e94ff8abc92e3565f6b1fc010","subject":"target/stm8: Remove useless parentheses"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-09-08 10:25:32.000000000","tz":120},"committer":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-09-08 14:11:36.000000000","tz":120},"subject":"jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend","message":"jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend\n\nFor some hosts build fails after the recent cmsis_dap_tcp addition\n(see commit fcff4b712c53a6169f0f96dd63f0adb1b12a1789 or\nhttps://review.openocd.org/c/openocd/+/8973)\n\n- Header \u0027hidapi.h\u0027 may not be available and should not be needed here.\n\n- Global pointer variable is not guaranteed to be treated as a constant\n  expression even with const modifier. Use global array instead, to avoid\n  \u0027error: initializer element is not constant\u0027, as address of a global\n  array is a constant expression.\n\nChange-Id: I0c72ff52340f546a5f635663a8fde28c99176d1b\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\n"}},"a6752a1671f7387ee3232bf84fe27a3746a55ac9":{"kind":"REWORK","_number":3,"created":"2025-09-12 16:39:52.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/9115/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/9115/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/3 \u0026\u0026 git checkout -b change-9115 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/9115/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c2cfeee471bd4a1b77ab1c30329200bb5fd37af4","subject":"add tcl/board/pico2-debug.cfg; update tcl/board/pico-debug.cfg"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-09-08 10:25:32.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-09-12 16:39:52.000000000","tz":0},"subject":"jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend","message":"jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend\n\nFor some hosts build fails after the recent cmsis_dap_tcp addition\n(see commit fcff4b712c53 (\"jtag/drivers/cmsis_dap: add new backend\ncmsis_dap_tcp\") or https://review.openocd.org/c/openocd/+/8973)\n\n- Header \u0027hidapi.h\u0027 may not be available and should not be needed here.\n\n- Global pointer variable is not guaranteed to be treated as a constant\n  expression even with const modifier. Use global array instead, to avoid\n  \u0027error: initializer element is not constant\u0027, as address of a global\n  array is a constant expression.\n\nChange-Id: I0c72ff52340f546a5f635663a8fde28c99176d1b\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9115\nTested-by: jenkins\nReviewed-by: Brian Kuschak \u003cbkuschak@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ae6f7b08c57e59f7bee5e34b03645389d817f8ee":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-09-08 14:23:51.000000000","uploader":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"ref":"refs/changes/15/9115/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/9115/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/2 \u0026\u0026 git checkout -b change-9115 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/9115/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/9115/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9279a489d466529e94ff8abc92e3565f6b1fc010","subject":"target/stm8: Remove useless parentheses"}],"author":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-09-08 10:25:32.000000000","tz":120},"committer":{"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","date":"2025-09-08 14:21:57.000000000","tz":120},"subject":"jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend","message":"jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend\n\nFor some hosts build fails after the recent cmsis_dap_tcp addition\n(see commit fcff4b712c53 (\"jtag/drivers/cmsis_dap: add new backend\ncmsis_dap_tcp\") or https://review.openocd.org/c/openocd/+/8973)\n\n- Header \u0027hidapi.h\u0027 may not be available and should not be needed here.\n\n- Global pointer variable is not guaranteed to be treated as a constant\n  expression even with const modifier. Use global array instead, to avoid\n  \u0027error: initializer element is not constant\u0027, as address of a global\n  array is a constant expression.\n\nChange-Id: I0c72ff52340f546a5f635663a8fde28c99176d1b\nSigned-off-by: Samuel Obuch \u003csamuel.obuch@espressif.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}