)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a35e3df27c177b06b4cc343426f223a86ac0854c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6809064a_ab04745d","updated":"2025-09-12 03:37:25.000000000","message":"Michael,\ncould you please sign off this patch? I want to preserve your authorship and checkpatch require patches signed off by author. Thanks","commit_id":"d3a943888b49ae889b45196618dc532bbf242a9a"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"bf77e00b0f231faa80b364f555c582227d716a5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e422623_ac8025bc","in_reply_to":"6809064a_ab04745d","updated":"2025-09-12 20:08:21.000000000","message":"Thanks. Now we can remove Checkpatch-ignore: NO_AUTHOR_SIGN_OFF","commit_id":"d3a943888b49ae889b45196618dc532bbf242a9a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6c20a4a7d579f09f57352a967413161981820b37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26fb63a6_c724779c","updated":"2025-09-13 12:34:48.000000000","message":"This should be added only as last commit in the series, otherwise we will not be able to bisect on system that have libgpiod v2.","commit_id":"260d8e55a35abefbac4e2e96fd3d03c31d251753"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6f887265b61cb5500393388f9e9aa410a2834b07","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb2c0151_30b95914","in_reply_to":"26fb63a6_c724779c","updated":"2025-09-13 12:43:35.000000000","message":"In fact, it was initially at the end of the series in https://review.openocd.org/c/openocd/+/8226/","commit_id":"260d8e55a35abefbac4e2e96fd3d03c31d251753"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d062ac1d212573a47f59ba78ea9c3e1ec6387748","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd17abdc_a2fe8ea1","in_reply_to":"eb2c0151_30b95914","updated":"2025-09-13 12:55:27.000000000","message":"I moved this part to provide `HAVE_LIBGPIOD_V1` to\n8202: jtag: linuxgpiod: wrap gpiod_request_config from libgpiod v2 | https://review.openocd.org/c/openocd/+/8202\nand some others. If there is a good reason not to move it, then\n```\n#if HAVE_LIBGPIOD_V1\n```\nshould be changed to \n```\n#if defined(HAVE_LIBGPIOD_V1) \u0026\u0026 HAVE_LIBGPIOD_V1\n```","commit_id":"260d8e55a35abefbac4e2e96fd3d03c31d251753"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0ec3167efa8f4772221b932df3260f29ea733fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c768f623_8149d3ee","in_reply_to":"fd17abdc_a2fe8ea1","updated":"2025-09-13 13:00:06.000000000","message":"Yes, you are right!\nIn my dev branch I have set\n`#define HAVE_LIBGPIOD_V1 1`\nto verify that the wrapped functions were correct","commit_id":"260d8e55a35abefbac4e2e96fd3d03c31d251753"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f0dec7e96c426c87110c0a330625718dee58443","unresolved":true,"context_lines":[{"line_number":589,"context_line":"], ["},{"line_number":590,"context_line":"\tPKG_CHECK_MODULES([LIBGPIOD], [libgpiod], ["},{"line_number":591,"context_line":"\t\tuse_libgpiod\u003dyes"},{"line_number":592,"context_line":"\t\tAC_DEFINE([HAVE_LIBGPIOD_V1], [1], [define if libgpiod is version v1.x])"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"\t\tPKG_CHECK_EXISTS([libgpiod \u003e\u003d 1.5],"},{"line_number":595,"context_line":"\t\t\t[AC_DEFINE([HAVE_LIBGPIOD1_FLAGS_BIAS], [1], [define if libgpiod v1 has line request flags bias])])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"6137b24f_cef49e4d","line":592,"updated":"2025-09-14 10:02:58.000000000","message":"But, it would have been enough to only add this `AC_DEFINE()` in this patch, as we do not support libgpiod2 yet at this level in the series.\nThe rest of this patch could go back in 8226\nI\u0027m testing this locally, and I will send out the new version if you agree","commit_id":"260d8e55a35abefbac4e2e96fd3d03c31d251753"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c16ae7c1cd8a7aa250d4233e81530e4dfe6e3ea0","unresolved":false,"context_lines":[{"line_number":589,"context_line":"], ["},{"line_number":590,"context_line":"\tPKG_CHECK_MODULES([LIBGPIOD], [libgpiod], ["},{"line_number":591,"context_line":"\t\tuse_libgpiod\u003dyes"},{"line_number":592,"context_line":"\t\tAC_DEFINE([HAVE_LIBGPIOD_V1], [1], [define if libgpiod is version v1.x])"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"\t\tPKG_CHECK_EXISTS([libgpiod \u003e\u003d 1.5],"},{"line_number":595,"context_line":"\t\t\t[AC_DEFINE([HAVE_LIBGPIOD1_FLAGS_BIAS], [1], [define if libgpiod v1 has line request flags bias])])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9cafc147_5d0e6748","line":592,"in_reply_to":"3261a663_75aa987a","updated":"2025-09-27 14:54:54.000000000","message":"Done","commit_id":"260d8e55a35abefbac4e2e96fd3d03c31d251753"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a936abfa2b0ea7731a368728296c411126b5dd1e","unresolved":true,"context_lines":[{"line_number":589,"context_line":"], ["},{"line_number":590,"context_line":"\tPKG_CHECK_MODULES([LIBGPIOD], [libgpiod], ["},{"line_number":591,"context_line":"\t\tuse_libgpiod\u003dyes"},{"line_number":592,"context_line":"\t\tAC_DEFINE([HAVE_LIBGPIOD_V1], [1], [define if libgpiod is version v1.x])"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"\t\tPKG_CHECK_EXISTS([libgpiod \u003e\u003d 1.5],"},{"line_number":595,"context_line":"\t\t\t[AC_DEFINE([HAVE_LIBGPIOD1_FLAGS_BIAS], [1], [define if libgpiod v1 has line request flags bias])])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3261a663_75aa987a","line":592,"in_reply_to":"6137b24f_cef49e4d","updated":"2025-09-14 10:12:19.000000000","message":"Yes, please do.\nIn #8226 you can simply revert to patchset 3","commit_id":"260d8e55a35abefbac4e2e96fd3d03c31d251753"}]}