)]}'
{"id":"openocd~master~I5402dd57dc9a81f65ee4c67d24e11c366006427c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-11-03 22:38:58.000000000","reason":"removed on reply"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-10-28 11:00:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}}},"hashtags":[],"change_id":"I5402dd57dc9a81f65ee4c67d24e11c366006427c","subject":"target/riscv: improve error messaging in case `sbasize` is zero","status":"MERGED","created":"2025-09-23 16:53:54.000000000","updated":"2025-11-12 20:32:33.000000000","submitted":"2025-11-12 20:32:33.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9142","meta_rev_id":"08ec84f5e131a05669c0e7e7b3ad6b222c43d092","_number":9142,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-12 20:32:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-11-12 20:32:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-12 20:32:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-23 16:53:54.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2025-09-23 16:59:31.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-09-23 17:37:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5ede79e8dddfeaea5944910897a72b19191ca8cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-09-23 16:53:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b8ba56732516d30fa604e8c9da45d242f9be7f7a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-09-23 17:37:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21025/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21903/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f98df5774e4c0d769ef9e54670a5bf6a29d5d4f5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-11 16:47:57.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"01a8fd9bd6cae14dce96160eced2adf3f904fcb7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-12 03:40:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21124/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22002/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"33d11146795d58fc1d81b00427a5d11db3e8a774","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-21 19:29:38.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"181a7674e1caa9bfa14c4c1d26d882de27bd2571","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-21 19:41:27.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"9e7355ee3db80e100285017af04cf7175ae1f9e5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-21 19:41:46.000000000","message":"Patch Set 3:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":3},{"id":"05edfbb170e9f75bca6b2ad42a0f10e4f57a564f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-22 01:32:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21190/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22067/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"2fb98f2d4d1d45ee9517480dc88964938545585e","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-10-22 12:06:52.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"1e9cfca0ec53393f6662d793d24ad76d5e3ee37d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-23 07:05:05.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"336b0507b5a26197014bc1268e82249c7df35f2c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-23 11:35:05.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21213/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22090/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"9934781e8330744f7e6c9ed939ac97ad5815d1f0","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-10-28 11:00:46.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"4613bba6a3f33b7fe43aa54dcfd16ff9e2d82e64","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-03 22:38:58.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"08ec84f5e131a05669c0e7e7b3ad6b222c43d092","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-12 20:32:33.000000000","message":"Change has been successfully cherry-picked as f5ce311103cac65a0d5000891d6ebebfe51e93ed","accounts_in_message":[],"_revision_number":6}],"current_revision":"f5ce311103cac65a0d5000891d6ebebfe51e93ed","revisions":{"1291ea81c26f6aa1faddd284dc21a657f1435f01":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-11 16:47:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/42/9142/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9142/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/2 \u0026\u0026 git checkout -b change-9142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9142/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd3e44b0692bbcdd07188d99d80624c84580dfd7","subject":"target/riscv: check nextdm address in abits range"}],"author":{"name":"Sriram Shanmuga","email":"sriramharshalee@gmail.com","date":"2025-07-07 15:17:04.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-11 16:44:00.000000000","tz":120},"subject":"target/riscv: improve error messaging in case `sbasize` is zero","message":"target/riscv: improve error messaging in case `sbasize` is zero\n\nImported from\nhttps://github.com/riscv-collab/riscv-openocd/pull/1274\n\nFrom: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\n\nRISC-V Debug Specification v1.0 [3.14.22. System Bus Access Control and\nStatus (`sbcs`, at 0x38)] states in `sbasize` field description:\n\u003e Width of system bus addresses in bits. (0 indicates there is no bus\naccess support.)\n\nBefore the patch, the error message did not include the information\nabout `sbcs.sbasize` being zero wich made it quite undescriptive:\n```\n[riscv.cpu] Turning off memory sampling because it failed.\n\n```\n\nFixes #1270\n\nChange-Id: I5402dd57dc9a81f65ee4c67d24e11c366006427c\nSigned-off-by: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"dff8bc9db79b22b4796e7005d6d64b7fa79bc785":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-10-21 19:29:38.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/42/9142/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9142/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/3 \u0026\u0026 git checkout -b change-9142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9142/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a93dbaef1168df8656fa55ff3aa01e56ef123eab","subject":"target/riscv: check nextdm address in abits range"}],"author":{"name":"Sriram Shanmuga","email":"sriramharshalee@gmail.com","date":"2025-07-07 15:17:04.000000000","tz":180},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-10-21 19:27:35.000000000","tz":120},"subject":"target/riscv: improve error messaging in case `sbasize` is zero","message":"target/riscv: improve error messaging in case `sbasize` is zero\n\nImported from\nhttps://github.com/riscv-collab/riscv-openocd/pull/1274\n\nFrom: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\n\nRISC-V Debug Specification v1.0 [3.14.22. System Bus Access Control and\nStatus (`sbcs`, at 0x38)] states in `sbasize` field description:\n\u003e Width of system bus addresses in bits. (0 indicates there is no bus\naccess support.)\n\nBefore the patch, the error message did not include the information\nabout `sbcs.sbasize` being zero wich made it quite undescriptive:\n```\n[riscv.cpu] Turning off memory sampling because it failed.\n\n```\n\nFixes #1270\n\nChange-Id: I5402dd57dc9a81f65ee4c67d24e11c366006427c\nSigned-off-by: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"557a34c8eeb26e76c8a1c3566ec9d3e5ba24fce5":{"kind":"REWORK","_number":1,"created":"2025-09-23 16:53:54.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/42/9142/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9142/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/1 \u0026\u0026 git checkout -b change-9142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9142/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"67ddd8f64a6fe9d1d840158c0ee2a4b394ba984e","subject":"target/riscv: check nextdm address in abits range"}],"author":{"name":"Sriram Shanmuga","email":"sriramharshalee@gmail.com","date":"2025-07-07 15:17:04.000000000","tz":180},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-09-23 16:47:21.000000000","tz":120},"subject":"target/riscv: improve error messaging in case `sbasize` is zero","message":"target/riscv: improve error messaging in case `sbasize` is zero\n\nImported from\nhttps://github.com/riscv-collab/riscv-openocd/pull/1274\n\nFrom: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\n\nRISC-V Debug Specification v1.0 [3.14.22. System Bus Access Control and\nStatus (`sbcs`, at 0x38)] states in `sbasize` field description:\n\u003e Width of system bus addresses in bits. (0 indicates there is no bus\naccess support.)\n\nBefore the patch, the error message did not include the information\nabout `sbcs.sbasize` being zero wich made it quite undescriptive:\n```\n[riscv.cpu] Turning off memory sampling because it failed.\n\n```\n\nFixes #1270\n\nChange-Id: I5402dd57dc9a81f65ee4c67d24e11c366006427c\nSigned-off-by: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"f5ce311103cac65a0d5000891d6ebebfe51e93ed":{"kind":"REWORK","_number":6,"created":"2025-11-12 20:32:33.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/42/9142/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9142/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/6 \u0026\u0026 git checkout -b change-9142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9142/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3483756cba5038335654bee437b5f17b7e6b88fd","subject":"target/riscv: check nextdm address in abits range"}],"author":{"name":"Sriram Shanmuga","email":"sriramharshalee@gmail.com","date":"2025-07-07 15:17:04.000000000","tz":180},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-12 20:32:33.000000000","tz":0},"subject":"target/riscv: improve error messaging in case `sbasize` is zero","message":"target/riscv: improve error messaging in case `sbasize` is zero\n\nImported from\nhttps://github.com/riscv-collab/riscv-openocd/pull/1274\n\nFrom: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\n\nRISC-V Debug Specification v1.0 [3.14.22. System Bus Access Control and\nStatus (`sbcs`, at 0x38)] states in `sbasize` field description:\n\u003e Width of system bus addresses in bits. (0 indicates there is no bus\naccess support.)\n\nBefore the patch, the error message did not include the information\nabout `sbcs.sbasize` being zero wich made it quite undescriptive:\n```\n[riscv.cpu] Turning off memory sampling because it failed.\n\n```\n\nFixes #1270\n\nChange-Id: I5402dd57dc9a81f65ee4c67d24e11c366006427c\nSigned-off-by: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9142\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"5917beeb6b9393ed1db9a657b718679f6ad84f87":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-10-21 19:41:27.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/42/9142/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9142/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/4 \u0026\u0026 git checkout -b change-9142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9142/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43971e9a89d06453c2cdce5ee91c8c1a897d018e","subject":"target/riscv: check nextdm address in abits range"}],"author":{"name":"Sriram Shanmuga","email":"sriramharshalee@gmail.com","date":"2025-07-07 15:17:04.000000000","tz":180},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-10-21 19:40:52.000000000","tz":120},"subject":"target/riscv: improve error messaging in case `sbasize` is zero","message":"target/riscv: improve error messaging in case `sbasize` is zero\n\nImported from\nhttps://github.com/riscv-collab/riscv-openocd/pull/1274\n\nFrom: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\n\nRISC-V Debug Specification v1.0 [3.14.22. System Bus Access Control and\nStatus (`sbcs`, at 0x38)] states in `sbasize` field description:\n\u003e Width of system bus addresses in bits. (0 indicates there is no bus\naccess support.)\n\nBefore the patch, the error message did not include the information\nabout `sbcs.sbasize` being zero wich made it quite undescriptive:\n```\n[riscv.cpu] Turning off memory sampling because it failed.\n\n```\n\nFixes #1270\n\nChange-Id: I5402dd57dc9a81f65ee4c67d24e11c366006427c\nSigned-off-by: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"40bdd067b434cfafe7dd793eda6231f071397bc7":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2025-10-23 07:05:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/42/9142/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9142/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/5 \u0026\u0026 git checkout -b change-9142 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9142/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9142/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b4e6d740534ebd66fdf7b405e437db1d44d32505","subject":"target/riscv: check nextdm address in abits range"}],"author":{"name":"Sriram Shanmuga","email":"sriramharshalee@gmail.com","date":"2025-07-07 15:17:04.000000000","tz":180},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-10-23 06:56:25.000000000","tz":120},"subject":"target/riscv: improve error messaging in case `sbasize` is zero","message":"target/riscv: improve error messaging in case `sbasize` is zero\n\nImported from\nhttps://github.com/riscv-collab/riscv-openocd/pull/1274\n\nFrom: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\n\nRISC-V Debug Specification v1.0 [3.14.22. System Bus Access Control and\nStatus (`sbcs`, at 0x38)] states in `sbasize` field description:\n\u003e Width of system bus addresses in bits. (0 indicates there is no bus\naccess support.)\n\nBefore the patch, the error message did not include the information\nabout `sbcs.sbasize` being zero wich made it quite undescriptive:\n```\n[riscv.cpu] Turning off memory sampling because it failed.\n\n```\n\nFixes #1270\n\nChange-Id: I5402dd57dc9a81f65ee4c67d24e11c366006427c\nSigned-off-by: Sriram Shanmuga \u003csriramharshalee@gmail.com\u003e\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}