)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"64f8caa56c764bd08f2cc2f71bfe5377ac4c470c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tcl: adjust `gdb-attach` handlers to remove BPs and WPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The commit 9f9c4fd4cf236837433bb80de9f75b635aaed544 (\"move BP/WP removal"},{"line_number":10,"context_line":"to `gdb-attach` handler\") changed the default `gdb-attach` handler."},{"line_number":11,"context_line":"Adjust custom handlers accordingly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"57c0c7c1_8407176e","line":9,"updated":"2025-10-19 10:38:31.000000000","message":"Checkpatch cannot find this SHA1, and please consider that the SHA1 of the patch will change in the moment it get merged.\nSo please write here something like\n`The previous patch in this series (\"move ...`","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e729ded728da22fc7ae0c123001b48d552e07d30","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tcl: adjust `gdb-attach` handlers to remove BPs and WPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The commit 9f9c4fd4cf236837433bb80de9f75b635aaed544 (\"move BP/WP removal"},{"line_number":10,"context_line":"to `gdb-attach` handler\") changed the default `gdb-attach` handler."},{"line_number":11,"context_line":"Adjust custom handlers accordingly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2e3ee931_1d99fa0c","line":9,"in_reply_to":"4f3cd21c_3d950a05","updated":"2025-10-23 10:44:38.000000000","message":"Done","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"7c6918fe2ede31bdb522119d0b5cdb8d5a24b880","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tcl: adjust `gdb-attach` handlers to remove BPs and WPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The commit 9f9c4fd4cf236837433bb80de9f75b635aaed544 (\"move BP/WP removal"},{"line_number":10,"context_line":"to `gdb-attach` handler\") changed the default `gdb-attach` handler."},{"line_number":11,"context_line":"Adjust custom handlers accordingly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4f3cd21c_3d950a05","line":9,"in_reply_to":"57c0c7c1_8407176e","updated":"2025-10-22 12:05:50.000000000","message":"Addressed. Thanks for the suggestion!","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"}],"tcl/board/at91rm9200-dk.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f95be3fce3a15709703868b5ed6e64e96977a42c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"$_TARGETNAME configure -event gdb-attach {"},{"line_number":14,"context_line":"\tcatch {rbp all}"},{"line_number":15,"context_line":"\tcatch {rwp all}"},{"line_number":16,"context_line":"\treset init"},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":"$_TARGETNAME configure -event reset-init { at91rm9200_dk_init }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"dca46d66_dad53aa6","line":16,"updated":"2025-10-02 09:35:04.000000000","message":"The default handler first `halt`s the target and then `rbp` `rwp`.\nIMO this sequence is the reason for all these changes.\nWhy here (and in all files but `ti_k3.cfg`) is the sequence reversed and breakpoints/wps removed from possibly running target?","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c8fc9e18b95049b5208537aec9811757e9a7a0d2","unresolved":true,"context_lines":[{"line_number":13,"context_line":"$_TARGETNAME configure -event gdb-attach {"},{"line_number":14,"context_line":"\tcatch {rbp all}"},{"line_number":15,"context_line":"\tcatch {rwp all}"},{"line_number":16,"context_line":"\treset init"},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":"$_TARGETNAME configure -event reset-init { at91rm9200_dk_init }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"af6241ad_d721c031","line":16,"in_reply_to":"90be1173_1bdeb805","updated":"2025-10-25 15:36:24.000000000","message":"\u003e Unfortunately the processing time will be longer so gdb could timeout during attach.\n\nThere is an old patch to have a working keep-alive during the delay of gdb-attach\nhttps://review.openocd.org/c/openocd/+/6703\nTo be recovered ...","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"7c6918fe2ede31bdb522119d0b5cdb8d5a24b880","unresolved":true,"context_lines":[{"line_number":13,"context_line":"$_TARGETNAME configure -event gdb-attach {"},{"line_number":14,"context_line":"\tcatch {rbp all}"},{"line_number":15,"context_line":"\tcatch {rwp all}"},{"line_number":16,"context_line":"\treset init"},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":"$_TARGETNAME configure -event reset-init { at91rm9200_dk_init }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"eed70b49_5afb4a2d","line":16,"in_reply_to":"dca46d66_dad53aa6","updated":"2025-10-22 12:05:50.000000000","message":"Before the changes, BPs and WPs were removed before calling the handler.\nI\u0027m not comfortable changing the order of these operations for these non-default cases.\nWith the `ti_k3.cfg` I decided to change the order because there was a mention of \"default handler\" in the comment (\"# gdb-attach default rule\"). This made me think that it is more important for the operation being prepended to be the first one.\n\nI do understand that the reasoning is quite weak. I can try to analyse this on case-to-case basis.\n\nFor the usual `reset init`, one more reason is HW breakpoints and WPs. AFAIU, on most architectures they are deleted by the reset. At least for RISC-V this is not handled well. So I\u0027d like to avoid reordering reset with the deletion of BPs/WPs.","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e729ded728da22fc7ae0c123001b48d552e07d30","unresolved":true,"context_lines":[{"line_number":13,"context_line":"$_TARGETNAME configure -event gdb-attach {"},{"line_number":14,"context_line":"\tcatch {rbp all}"},{"line_number":15,"context_line":"\tcatch {rwp all}"},{"line_number":16,"context_line":"\treset init"},{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":"$_TARGETNAME configure -event reset-init { at91rm9200_dk_init }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"90be1173_1bdeb805","line":16,"in_reply_to":"eed70b49_5afb4a2d","updated":"2025-10-23 10:44:38.000000000","message":"Yes, good point!\nConsidering that we need first to `halt` to ensure the following `rbp`/`rwp` works.\nSomething like this:\n```\n$_TARGETNAME configure -event gdb-attach {\n\tcatch {halt}\n\tcatch {rbp all}\n\tcatch {rwp all}\n\treset init\n}\n```\nUnfortunately the processing time will be longer so gdb could timeout during attach.","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"}],"tcl/target/ti_k3.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f95be3fce3a15709703868b5ed6e64e96977a42c","unresolved":true,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"$_TARGETNAME.sysctrl configure -event reset-assert { }"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"proc prepend_default_handler {target event script} {"},{"line_number":389,"context_line":"\tset handler [$target cget -event $event]"},{"line_number":390,"context_line":"\t$target configure -event $event \"${script}; ${handler}\""},{"line_number":391,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"b225db03_f8e5af7b","line":388,"updated":"2025-10-02 09:35:04.000000000","message":"I\u0027m not a fan of modifying the handler code but must admit that the changes in this file looks good.\nJust please remove misleading `default` word from proc name - it always prepends the current handler code, even if it have been changed or prepended.\nWe probably should factor out the proc to be easily reusable (perhaps a tcl file to source), however this is not necessary in this patch.","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e729ded728da22fc7ae0c123001b48d552e07d30","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"$_TARGETNAME.sysctrl configure -event reset-assert { }"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"proc prepend_default_handler {target event script} {"},{"line_number":389,"context_line":"\tset handler [$target cget -event $event]"},{"line_number":390,"context_line":"\t$target configure -event $event \"${script}; ${handler}\""},{"line_number":391,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"42173acb_e395155b","line":388,"in_reply_to":"1dd69616_c6d3b612","updated":"2025-10-23 10:44:38.000000000","message":"Okay","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"7c6918fe2ede31bdb522119d0b5cdb8d5a24b880","unresolved":true,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"$_TARGETNAME.sysctrl configure -event reset-assert { }"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"proc prepend_default_handler {target event script} {"},{"line_number":389,"context_line":"\tset handler [$target cget -event $event]"},{"line_number":390,"context_line":"\t$target configure -event $event \"${script}; ${handler}\""},{"line_number":391,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"1dd69616_c6d3b612","line":388,"in_reply_to":"b225db03_f8e5af7b","updated":"2025-10-22 12:05:50.000000000","message":"\u003e Just please remove misleading default word from proc name - it always prepends the current handler code, even if it have been changed or prepended.\n\nAddressed.\n\n\u003e We probably should factor out the proc to be easily reusable (perhaps a tcl file to source), however this is not necessary in this patch.\n\nI\u0027m not sure it worth the hustle. The `proc` is quite niche and a bit hacky.\n\nIn any case, AFAIU going forward the concept of an event handler will be reworked. AFAIR Antonio suggested using `proc`s in the namespace with the name of a target.","commit_id":"97cf90168898346ee14d14a976dbc820f575e875"}]}