)]}'
{"id":"openocd~master~Idd68270fbdf879153cd59f4cacf5036aa599b251","project":"openocd","branch":"master","hashtags":[],"change_id":"Idd68270fbdf879153cd59f4cacf5036aa599b251","subject":"configure.ac: rename \u0027adapterTuple\u0027 as \u0027adapter_driver\u0027","status":"MERGED","created":"2025-10-05 09:32:32.000000000","updated":"2025-10-11 16:17:45.000000000","submitted":"2025-10-11 16:17:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9160","meta_rev_id":"3a0903df22880bb09df0b8fb52698a2a14e3bb2a","_number":9160,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-10-11 16:17:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-10-11 16:17:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-05 09:32:44.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-10-05 10:04:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5b9db5a5b10d4f6e18977d5da482904da546d8ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-05 09:32:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8fc209c4e46dc25dc45b42a39e02165dbcc1923b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-05 10:04:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21091/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21970/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d2a610a40933744c1a47e2a3f835891e8d476852","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-11 16:17:37.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3a0903df22880bb09df0b8fb52698a2a14e3bb2a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-11 16:17:45.000000000","message":"Change has been successfully cherry-picked as 1f5da25ed19f41499efdd482e522e016d0eb406c","accounts_in_message":[],"_revision_number":2}],"current_revision":"1f5da25ed19f41499efdd482e522e016d0eb406c","revisions":{"1f5da25ed19f41499efdd482e522e016d0eb406c":{"kind":"REWORK","_number":2,"created":"2025-10-11 16:17:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/60/9160/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/9160/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/2 \u0026\u0026 git checkout -b change-9160 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/9160/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7c16c38eda25da452945cd7148146e986efb6efe","subject":"configure.ac: add adapter dependency from sys/mman.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-05 09:17:16.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-11 16:17:45.000000000","tz":0},"subject":"configure.ac: rename \u0027adapterTuple\u0027 as \u0027adapter_driver\u0027","message":"configure.ac: rename \u0027adapterTuple\u0027 as \u0027adapter_driver\u0027\n\nCommit ce3bf664c815 (\"configure.ac: rename M4 macro \u0027adapter\u0027 to\nprevent accidental conflicts\") renames the macro as \u0027adapterTuple\u0027\nbut since the macro name is printed in error messages, this\ncreates cryptic errors like:\n\tconfigure: error: header sys/mman.h is required\n\tfor adapterTuple \"Bitbanging on EP93xx-based SBCs\".\n\nRename it as \u0027adapter_driver\u0027. It keeps valid the purpose of the\nformer renaming, while keeping readable the error message.\n\nChange-Id: Idd68270fbdf879153cd59f4cacf5036aa599b251\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: ce3bf664c815 (\"configure.ac: rename M4 macro \u0027adapter\u0027 to prevent accidental conflicts\")\nReviewed-on: https://review.openocd.org/c/openocd/+/9160\nTested-by: jenkins\n"}},"e4917e718c50b78ff9e6ee17aa8c65ecf5b83d69":{"kind":"REWORK","_number":1,"created":"2025-10-05 09:32:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/60/9160/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/9160/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/1 \u0026\u0026 git checkout -b change-9160 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/9160/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/9160/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9946b783844d3dd369d99acd3fe333b1667c3042","subject":"configure.ac: add adapter dependency from sys/mman.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-05 09:17:16.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-05 09:31:22.000000000","tz":120},"subject":"configure.ac: rename \u0027adapterTuple\u0027 as \u0027adapter_driver\u0027","message":"configure.ac: rename \u0027adapterTuple\u0027 as \u0027adapter_driver\u0027\n\nCommit ce3bf664c815 (\"configure.ac: rename M4 macro \u0027adapter\u0027 to\nprevent accidental conflicts\") renames the macro as \u0027adapterTuple\u0027\nbut since the macro name is printed in error messages, this\ncreates cryptic errors like:\n\tconfigure: error: header sys/mman.h is required\n\tfor adapterTuple \"Bitbanging on EP93xx-based SBCs\".\n\nRename it as \u0027adapter_driver\u0027. It keeps valid the purpose of the\nformer renaming, while keeping readable the error message.\n\nChange-Id: Idd68270fbdf879153cd59f4cacf5036aa599b251\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: ce3bf664c815 (\"configure.ac: rename M4 macro \u0027adapter\u0027 to prevent accidental conflicts\")\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}