)]}'
{"id":"openocd~master~Ic5da392f8ab26b47466be199432432cdc08712ab","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2025-10-13 07:56:35.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic5da392f8ab26b47466be199432432cdc08712ab","subject":"adapters/cmsis-dap: Fix build without libusb","status":"MERGED","created":"2025-10-08 06:30:51.000000000","updated":"2025-10-13 07:56:35.000000000","submitted":"2025-10-13 07:56:35.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9161","meta_rev_id":"2376e70d65fcb449189b9325e86b8653d25e2698","_number":9161,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-10-13 07:56:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-10-13 07:56:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-10-13 07:56:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-08 06:35:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-10-08 06:42:08.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2025-10-08 07:00:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-10-13 07:19:56.000000000","updated_by":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"reviewer":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"state":"REVIEWER"}],"messages":[{"id":"f02f1f555f3f2179ecf88805c2bb212c37c01d5d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-10-08 06:30:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d495b50521341444cb31a11537ce71df2e607355","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-08 06:42:08.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"aacd783c414620247399f321d0b8db692ec75bb1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-08 07:00:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21094/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/21972/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"adbc2d69fb25bd6a84b12b1bf6793af7061d57b3","author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"real_author":{"_account_id":1002432,"name":"NikLeberg","display_name":"NikLeberg","email":"niklaus.leuenb@gmail.com","username":"NikLeberg"},"date":"2025-10-13 07:19:56.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2376e70d65fcb449189b9325e86b8653d25e2698","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-10-13 07:56:35.000000000","message":"Change has been successfully cherry-picked as 3fd975941537346c7a3c37aecc944b30305a8e1e","accounts_in_message":[],"_revision_number":2}],"current_revision":"3fd975941537346c7a3c37aecc944b30305a8e1e","revisions":{"eae61beebbb41e65bc7479adb61b5b92bdfcd2a1":{"kind":"REWORK","_number":1,"created":"2025-10-08 06:30:51.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/61/9161/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/9161/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/1 \u0026\u0026 git checkout -b change-9161 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/9161/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e5888bda38f4952e2ae92f7dc5b25fc9a2d1c2b3","subject":"target/breakpoints: drop duplicate breakpoint/watchpoint \"clear_target\" functions"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-10-08 05:40:44.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-10-08 06:23:30.000000000","tz":120},"subject":"adapters/cmsis-dap: Fix build without libusb","message":"adapters/cmsis-dap: Fix build without libusb\n\nThe cmsis-dap core driver depends on libusb-related code which breaks\nthe build when libusb is not available.\n\nRemove libusb dependency of the core driver to fix the build issue. For\nnow, use an own timeout #define with the value of LIBUSB_TIMEOUT_MS but\ntimeout handling should be better moved to the backends. However, this\nshould be addressed in a dedicated patch.\n\nChange-Id: Ic5da392f8ab26b47466be199432432cdc08712ab\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"3fd975941537346c7a3c37aecc944b30305a8e1e":{"kind":"REWORK","_number":2,"created":"2025-10-13 07:56:35.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/9161/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/9161/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/2 \u0026\u0026 git checkout -b change-9161 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/9161/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/9161/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f5da25ed19f41499efdd482e522e016d0eb406c","subject":"configure.ac: rename \u0027adapterTuple\u0027 as \u0027adapter_driver\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2025-10-08 05:40:44.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-10-13 07:56:35.000000000","tz":0},"subject":"adapters/cmsis-dap: Fix build without libusb","message":"adapters/cmsis-dap: Fix build without libusb\n\nThe cmsis-dap core driver depends on libusb-related code which breaks\nthe build when libusb is not available.\n\nRemove libusb dependency of the core driver to fix the build issue. For\nnow, use an own timeout #define with the value of LIBUSB_TIMEOUT_MS but\ntimeout handling should be better moved to the backends. However, this\nshould be addressed in a dedicated patch.\n\nChange-Id: Ic5da392f8ab26b47466be199432432cdc08712ab\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9161\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: \u003cniklaus.leuenb@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
