)]}'
{"id":"openocd~master~Idfa4fe9c6dfb2acfbf434c392237937ae03f0e8a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002161":{"account":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"last_update":"2025-10-14 21:16:56.000000000","reason":"\u003cGERRIT_ACCOUNT_1002161\u003e replied on the change","reason_account":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-10-18 08:58:52.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Idfa4fe9c6dfb2acfbf434c392237937ae03f0e8a","subject":"helper/log: mark \u0027fmt\u0027 argument of alloc_*printf() as not NULL","status":"MERGED","created":"2025-10-12 09:51:35.000000000","updated":"2025-10-18 08:58:55.000000000","submitted":"2025-10-18 08:58:55.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9166","meta_rev_id":"f8e9d63265f39fec05763e3c44b34d8232aef4a1","_number":9166,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-10-18 08:58:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-10-18 08:58:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-10-18 08:58:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-12 09:51:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"state":"REVIEWER"},{"updated":"2025-10-12 09:51:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-10-12 10:47:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"303406b4dd615a453008e0e9df08ea5fa2fd9aa6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-12 09:51:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0a60d663ec01a2d450e439a9e64623bf43a92e2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-12 10:47:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21134/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22012/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"7c28fdee229236dd6b7f8ad6023e15fdb0af1ed5","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2025-10-14 21:16:56.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c553d4345c5bea546a933ee2dadb54a75a5e85d9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-18 08:58:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f8e9d63265f39fec05763e3c44b34d8232aef4a1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-18 08:58:55.000000000","message":"Change has been successfully cherry-picked as 85542c1c5c65ea73beb6d52b3ea5c38601313a3b","accounts_in_message":[],"_revision_number":2}],"current_revision":"85542c1c5c65ea73beb6d52b3ea5c38601313a3b","revisions":{"eb495be6e8ab72dacd477d2853d87fa326681ffa":{"kind":"REWORK","_number":1,"created":"2025-10-12 09:51:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/9166/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/9166/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/1 \u0026\u0026 git checkout -b change-9166 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/9166/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1f5da25ed19f41499efdd482e522e016d0eb406c","subject":"configure.ac: rename \u0027adapterTuple\u0027 as \u0027adapter_driver\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-12 09:30:00.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-12 09:49:04.000000000","tz":120},"subject":"helper/log: mark \u0027fmt\u0027 argument of alloc_*printf() as not NULL","message":"helper/log: mark \u0027fmt\u0027 argument of alloc_*printf() as not NULL\n\nEven after commit e12ceddd5ee4 (\"helper/log: mark `fmt` argument\nof `alloc_vprintf()` as format string\"), the GCC compiler still\nreports that alloc_vprintf() could call vsnprintf() with a NULL\nformat parameter.\n\nInform the compiler that alloc_vprintf() cannot accept NULL as\nformat string.\nAdd an assert() in alloc_vprintf() so even compilers that do not\nuse the function attribute \u0027nonnull\u0027 will play safe.\nWhile there, extend the same fixes to alloc_printf() too.\n\nChange-Id: Idfa4fe9c6dfb2acfbf434c392237937ae03f0e8a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Parshintsev Anatoly \u003canatoly.parshintsev@syntacore.com\u003e\n"}},"85542c1c5c65ea73beb6d52b3ea5c38601313a3b":{"kind":"REWORK","_number":2,"created":"2025-10-18 08:58:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/9166/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/9166/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/2 \u0026\u0026 git checkout -b change-9166 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/9166/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/9166/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"557a2082b1b41b288a9acd0400a6f5c75a8f47b7","subject":"openocd: don\u0027t test \u0027debug_level\u0027 directly"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-12 09:30:00.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-18 08:58:55.000000000","tz":0},"subject":"helper/log: mark \u0027fmt\u0027 argument of alloc_*printf() as not NULL","message":"helper/log: mark \u0027fmt\u0027 argument of alloc_*printf() as not NULL\n\nEven after commit e12ceddd5ee4 (\"helper/log: mark `fmt` argument\nof `alloc_vprintf()` as format string\"), the GCC compiler still\nreports that alloc_vprintf() could call vsnprintf() with a NULL\nformat parameter.\n\nInform the compiler that alloc_vprintf() cannot accept NULL as\nformat string.\nAdd an assert() in alloc_vprintf() so even compilers that do not\nuse the function attribute \u0027nonnull\u0027 will play safe.\nWhile there, extend the same fixes to alloc_printf() too.\n\nChange-Id: Idfa4fe9c6dfb2acfbf434c392237937ae03f0e8a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Parshintsev Anatoly \u003canatoly.parshintsev@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9166\nTested-by: jenkins\nReviewed-by: Anatoly P \u003canatoly.parshintsev@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}