)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e4e2778b83433cac85a9379ed5780f4928f49c4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Draft: fix missing thread ID in stop reply when smp-configured hart (but not hart 0) single-stepped"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"See [1] for context."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Link: https://github.com/riscv-collab/riscv-openocd/pull/675 [1]"},{"line_number":12,"context_line":"Change-Id: I9872062dfa0e3f1ca531d282d52a1b04c527546a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"70809ff1_8919f944","line":9,"updated":"2025-10-25 12:32:20.000000000","message":"We don\u0027t know what will happen to riscv-openocd on github once the merge upstream gets completed.\nEven more pessimistic: since github has been acquired by a corporation with the only purpose to train their AI with the user\u0027s code, we cannot be confident the link below will last.\nPlus, offline git history with self contained commit message is relevant.\nThe link below is welcome as \"extra\" information and to provide some sort of history.\nBut it cannot and should not replace a decent commit message that explains the commit.","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"1095b643a03bc5ad2bb4a2685a1524d02b34169b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Draft: fix missing thread ID in stop reply when smp-configured hart (but not hart 0) single-stepped"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"See [1] for context."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Link: https://github.com/riscv-collab/riscv-openocd/pull/675 [1]"},{"line_number":12,"context_line":"Change-Id: I9872062dfa0e3f1ca531d282d52a1b04c527546a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ac409615_6d1d6110","line":9,"in_reply_to":"70809ff1_8919f944","updated":"2025-11-06 11:17:40.000000000","message":"Addressed.","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c902d988b50fec270fe485a0573feb1d536071","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Draft: fix missing thread ID in stop reply when smp-configured hart (but not hart 0) single-stepped"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"See [1] for context."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Link: https://github.com/riscv-collab/riscv-openocd/pull/675 [1]"},{"line_number":12,"context_line":"Change-Id: I9872062dfa0e3f1ca531d282d52a1b04c527546a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c5c29d10_c9666660","line":9,"in_reply_to":"ac409615_6d1d6110","updated":"2025-11-08 17:27:23.000000000","message":"Done","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c902d988b50fec270fe485a0573feb1d536071","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-06 14:07:59 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rtos: server/gdb_srever: fix missing thread ID in stop reply"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cherry-picked from [1]."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0d9809a2_b2e985da","line":7,"updated":"2025-11-08 17:27:23.000000000","message":"typo: s/gdb_srever/gdb_server/","commit_id":"3096908783cedeeb726d504f8f99eb539e8890aa"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"3c961c64facba446419e826013cd623633bcc16b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-06 14:07:59 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rtos: server/gdb_srever: fix missing thread ID in stop reply"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cherry-picked from [1]."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d715137b_8952d242","line":7,"in_reply_to":"0d9809a2_b2e985da","updated":"2025-11-09 08:28:05.000000000","message":"Done","commit_id":"3096908783cedeeb726d504f8f99eb539e8890aa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"63f60a8dfb96a4bd0e3ca52beecb46f3d4e0b538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e98d423_aa74273f","updated":"2025-11-03 23:16:15.000000000","message":"We need this functionality to pass riscv-tests.\n@Evgeniy, could you please finish the patch?","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"1095b643a03bc5ad2bb4a2685a1524d02b34169b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04b2e010_b9f05e47","in_reply_to":"8e98d423_aa74273f","updated":"2025-11-06 11:17:40.000000000","message":"Addressed.","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c902d988b50fec270fe485a0573feb1d536071","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"735b36ff_eb3b0b21","updated":"2025-11-08 17:27:23.000000000","message":"There is typo in the commit message.\nFixing it pushing a new version would destroy the relationship in the whole series. I would wait and check if there is any real need to re-push the whole series.\nTomas, would you mind fixing the typo in gerrit-webpage while merging this patch?","commit_id":"3096908783cedeeb726d504f8f99eb539e8890aa"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"3c961c64facba446419e826013cd623633bcc16b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad33e2cc_9bfbd181","in_reply_to":"735b36ff_eb3b0b21","updated":"2025-11-09 08:28:05.000000000","message":"Yes, keeping the relationship in this series is getting somewhat tricky. I fix it now not to miss it later. I hope that I will be able to merge the series correctly. We should do it ASAP.","commit_id":"3096908783cedeeb726d504f8f99eb539e8890aa"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"87ff163bcc88b133b851647e017434c70f2fb911","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d75b4d1f_e8707b3b","updated":"2025-11-12 21:08:19.000000000","message":"This change does not merge cleanly without merging\n9176: rtos: server: target: ask the RTOS which target to set swbp on. | https://review.openocd.org/c/openocd/+/9176\n\nIt\u0027s easy to rebase this one, but I think it\u0027s worth to quickly get 9176 ready.","commit_id":"20e742d38fc85717a90158736685992d44832d1a"}],"src/rtos/rtos.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e4e2778b83433cac85a9379ed5780f4928f49c4","unresolved":true,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"struct rtos *rtos_of_target(struct target *target)"},{"line_number":720,"context_line":"{"},{"line_number":721,"context_line":"\t/* Primarily consider the rtos field of the target itself, secondarily consider"},{"line_number":722,"context_line":"\t * rtos field SMP leader target, then consider rtos field of any other target in the SMP group."},{"line_number":723,"context_line":"\t * Otherwise NULL return means that no associated non-zero rtos field could be found. */"},{"line_number":724,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4b4cb8d1_e9dd984c","line":721,"updated":"2025-10-25 12:32:20.000000000","message":"What about `rtos_from_target()`?\nThis comment describes the code, that is already clear. No need for it.\nInstead, before the function could be good to have a doxigen comment for the function explaining, e.g. \"get the rtos from the target itself or from one of the targets in the same SMP node, or NULL when no rtos is set\"","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"1095b643a03bc5ad2bb4a2685a1524d02b34169b","unresolved":true,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"struct rtos *rtos_of_target(struct target *target)"},{"line_number":720,"context_line":"{"},{"line_number":721,"context_line":"\t/* Primarily consider the rtos field of the target itself, secondarily consider"},{"line_number":722,"context_line":"\t * rtos field SMP leader target, then consider rtos field of any other target in the SMP group."},{"line_number":723,"context_line":"\t * Otherwise NULL return means that no associated non-zero rtos field could be found. */"},{"line_number":724,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5542c82c_9dcc53b0","line":721,"in_reply_to":"4b4cb8d1_e9dd984c","updated":"2025-11-06 11:17:40.000000000","message":"Addressed.","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c902d988b50fec270fe485a0573feb1d536071","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"struct rtos *rtos_of_target(struct target *target)"},{"line_number":720,"context_line":"{"},{"line_number":721,"context_line":"\t/* Primarily consider the rtos field of the target itself, secondarily consider"},{"line_number":722,"context_line":"\t * rtos field SMP leader target, then consider rtos field of any other target in the SMP group."},{"line_number":723,"context_line":"\t * Otherwise NULL return means that no associated non-zero rtos field could be found. */"},{"line_number":724,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7f3ffdba_e3a0e800","line":721,"in_reply_to":"5542c82c_9dcc53b0","updated":"2025-11-08 17:27:23.000000000","message":"Done","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3e4e2778b83433cac85a9379ed5780f4928f49c4","unresolved":true,"context_lines":[{"line_number":728,"context_line":"\t\treturn target-\u003ertos;"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"\tforeach_smp_target(pos, target-\u003esmp_targets)"},{"line_number":731,"context_line":"\t\tif ((pos-\u003etarget-\u003ertos) \u0026\u0026 (pos-\u003etarget-\u003ertos-\u003etype))"},{"line_number":732,"context_line":"\t\t\treturn pos-\u003etarget-\u003ertos;"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"\treturn NULL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"85a04c47_a1aa38e0","line":731,"updated":"2025-10-25 12:32:20.000000000","message":"Checkpatch complains about unnecessary parentheses.\nThey were already in the original code, not your fault.\nUse:\n`if (pos-\u003etarget-\u003ertos \u0026\u0026 pos-\u003etarget-\u003ertos-\u003etype)`","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"1095b643a03bc5ad2bb4a2685a1524d02b34169b","unresolved":true,"context_lines":[{"line_number":728,"context_line":"\t\treturn target-\u003ertos;"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"\tforeach_smp_target(pos, target-\u003esmp_targets)"},{"line_number":731,"context_line":"\t\tif ((pos-\u003etarget-\u003ertos) \u0026\u0026 (pos-\u003etarget-\u003ertos-\u003etype))"},{"line_number":732,"context_line":"\t\t\treturn pos-\u003etarget-\u003ertos;"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"\treturn NULL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9c3fbc00_f00a4ce7","line":731,"in_reply_to":"85a04c47_a1aa38e0","updated":"2025-11-06 11:17:40.000000000","message":"Addressed.","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b0c902d988b50fec270fe485a0573feb1d536071","unresolved":false,"context_lines":[{"line_number":728,"context_line":"\t\treturn target-\u003ertos;"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"\tforeach_smp_target(pos, target-\u003esmp_targets)"},{"line_number":731,"context_line":"\t\tif ((pos-\u003etarget-\u003ertos) \u0026\u0026 (pos-\u003etarget-\u003ertos-\u003etype))"},{"line_number":732,"context_line":"\t\t\treturn pos-\u003etarget-\u003ertos;"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"\treturn NULL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"62f27b03_b44de92b","line":731,"in_reply_to":"9c3fbc00_f00a4ce7","updated":"2025-11-08 17:27:23.000000000","message":"Done","commit_id":"f78898f9a9446a20c85b1ba953c0bd86b379ef55"}]}