)]}'
{"id":"openocd~master~Ia5007e04b3c061a0f7a74387b51ab2a57c658088","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-11-22 19:03:45.000000000","reason":"removed on reply"},"1000853":{"account":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2025-11-11 15:38:02.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-11-10 08:35:55.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}}},"hashtags":[],"change_id":"Ia5007e04b3c061a0f7a74387b51ab2a57c658088","subject":"command: return OpenOCD error code as Tcl \u0027errorCode\u0027","status":"MERGED","created":"2025-10-24 13:29:41.000000000","updated":"2025-11-22 19:03:49.000000000","submitted":"2025-11-22 19:03:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9186","meta_rev_id":"7973c05191bb184bbb9d0b48ad6b502783e0dfe6","_number":9186,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-22 19:03:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-22 19:03:49.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-11-22 19:03:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-22 19:03:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-24 13:48:52.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-10-24 14:26:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-10-24 14:28:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2025-10-24 14:28:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"b6daa8067d19e8372be487b7c85a290398bc471f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-24 13:29:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5e4fffe491ff88dfda2b6a6790d6901e6141ab3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-10-24 14:26:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21235/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22114/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9470b7b7393d5364bcf0069cde92e5818c8a0458","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-24 14:28:07.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"db90e4664f4e019871330765b0abac6ea1651f82","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-10-24 14:35:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ca977f6caa31779451de6d75f9e1c86759a26f69","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-11-10 08:35:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"889ae5401348bcbb05efc99bcbb3706b9bbc7d2e","author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"Marc Schink","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-11-11 15:38:02.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"78de029edfe4364d02093f9b7052c1d9d888d107","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-11-22 19:03:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7973c05191bb184bbb9d0b48ad6b502783e0dfe6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-11-22 19:03:49.000000000","message":"Change has been successfully cherry-picked as d2aeb5fcc9eb1445684306441ea2524c4e196196","accounts_in_message":[],"_revision_number":2}],"current_revision":"d2aeb5fcc9eb1445684306441ea2524c4e196196","revisions":{"6b5630abb080dff04c4ec4e425eb3e648852b62a":{"kind":"REWORK","_number":1,"created":"2025-10-24 13:29:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/9186/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/9186/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/1 \u0026\u0026 git checkout -b change-9186 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/9186/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23e0ff69391c927692be1a57765daddc40ea933b","subject":"command: on syntax error, run \u0027usage\u0027 inside the same cmd_ctx"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-24 08:12:30.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-24 13:28:39.000000000","tz":120},"subject":"command: return OpenOCD error code as Tcl \u0027errorCode\u0027","message":"command: return OpenOCD error code as Tcl \u0027errorCode\u0027\n\nCommit 93f16eed4d4d (\"command: fix OpenOCD commands return value\nfor next jimtcl\") aligns the return of OpenOCD Tcl commands to the\nstandard Tcl error codes.\n\nThis has the side effect to hide the internal OpenOCD error codes\n(e.g. ERROR_FAIL \u003d -4) from the Tcl environment. These codes are\nfor internal use, can change during OpenOCD development and should\nnot be exposed to the user.\nNevertheless, some ACI test has been instrumented to check such\nvalues and there is a requirement to make them available, possibly\nwithout breaking the Tcl language rules.\n\nTcl allows procedures to return, through the \u0027return\u0027 command [1]:\n- the result text;\n- a return code like \u0027ok\u0027 or \u0027error\u0027;\n- an optional \u0027errorcode\u0027;\n- ...\n\nThe optional \u0027errorcode\u0027 can be exploited to propagate the OpenOCD\nerror code to the Tcl script for ACI test purpose.\nIt would be equivalent of considering the OpenOCD commands as Tcl\nprocedures that either returns as:\n\treturn -code ok \u0027command output text\u0027\nor return an error as:\n\treturn -code error -errorcode {OpenOCD -4} \u0027error text\u0027\nwhere \u0027-4\u0027 is the OpenOCD value for ERROR_FAIL.\n\nTcl stores the errorcode in the global variable \u0027errorCode\u0027 that\ncan be easily accessed within a Tcl script [2].\nThe variable \u0027errorCode\u0027 is by default set to \u0027NONE\u0027 and has to be\nset to a Tcl list. The first element of the list identifies the\ngeneral class of errors and determines the format of the rest of\nthe list. This allows the required flexibility to propagate the\nOpenOCD error codes in a format unique that does not impact other\nTcl functionality.\n\nPropagates the OpenOCD error code in the Tcl global variable\n\u0027errorCode\u0027 as a Tcl list formatted as {OpenOCD %s}.\nModify the test script to check for OpenOCD error code.\n\nLink: https://www.tcl-lang.org/man/tcl8.6/TclCmd/return.htm [1]\nLink: https://www.tcl-lang.org/man/tcl8.6/TclCmd/tclvars.htm [2]\nChange-Id: Ia5007e04b3c061a0f7a74387b51ab2a57c658088\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d2aeb5fcc9eb1445684306441ea2524c4e196196":{"kind":"REWORK","_number":2,"created":"2025-11-22 19:03:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/9186/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/9186/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/2 \u0026\u0026 git checkout -b change-9186 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/9186/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/9186/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fcce5d52d9afd6c7fa04da72534486a3a96cc178","subject":"command: on syntax error, run \u0027usage\u0027 inside the same cmd_ctx"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-10-24 08:12:30.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-11-22 19:03:49.000000000","tz":0},"subject":"command: return OpenOCD error code as Tcl \u0027errorCode\u0027","message":"command: return OpenOCD error code as Tcl \u0027errorCode\u0027\n\nCommit 93f16eed4d4d (\"command: fix OpenOCD commands return value\nfor next jimtcl\") aligns the return of OpenOCD Tcl commands to the\nstandard Tcl error codes.\n\nThis has the side effect to hide the internal OpenOCD error codes\n(e.g. ERROR_FAIL \u003d -4) from the Tcl environment. These codes are\nfor internal use, can change during OpenOCD development and should\nnot be exposed to the user.\nNevertheless, some ACI test has been instrumented to check such\nvalues and there is a requirement to make them available, possibly\nwithout breaking the Tcl language rules.\n\nTcl allows procedures to return, through the \u0027return\u0027 command [1]:\n- the result text;\n- a return code like \u0027ok\u0027 or \u0027error\u0027;\n- an optional \u0027errorcode\u0027;\n- ...\n\nThe optional \u0027errorcode\u0027 can be exploited to propagate the OpenOCD\nerror code to the Tcl script for ACI test purpose.\nIt would be equivalent of considering the OpenOCD commands as Tcl\nprocedures that either returns as:\n\treturn -code ok \u0027command output text\u0027\nor return an error as:\n\treturn -code error -errorcode {OpenOCD -4} \u0027error text\u0027\nwhere \u0027-4\u0027 is the OpenOCD value for ERROR_FAIL.\n\nTcl stores the errorcode in the global variable \u0027errorCode\u0027 that\ncan be easily accessed within a Tcl script [2].\nThe variable \u0027errorCode\u0027 is by default set to \u0027NONE\u0027 and has to be\nset to a Tcl list. The first element of the list identifies the\ngeneral class of errors and determines the format of the rest of\nthe list. This allows the required flexibility to propagate the\nOpenOCD error codes in a format unique that does not impact other\nTcl functionality.\n\nPropagates the OpenOCD error code in the Tcl global variable\n\u0027errorCode\u0027 as a Tcl list formatted as {OpenOCD %s}.\nModify the test script to check for OpenOCD error code.\n\nLink: https://www.tcl-lang.org/man/tcl8.6/TclCmd/return.htm [1]\nLink: https://www.tcl-lang.org/man/tcl8.6/TclCmd/tclvars.htm [2]\nChange-Id: Ia5007e04b3c061a0f7a74387b51ab2a57c658088\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9186\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\nReviewed-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}