)]}'
{"id":"openocd~master~I12d1c57b7154e64abdf23dd7cd31714f9d8ec6f0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-11-22 19:27:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I12d1c57b7154e64abdf23dd7cd31714f9d8ec6f0","subject":"target/cortex_a: fix HW breakpoint length for gdb kind 3","status":"MERGED","created":"2025-11-03 17:53:22.000000000","updated":"2025-11-22 19:27:14.000000000","submitted":"2025-11-22 19:27:14.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9211","meta_rev_id":"86d10417c27e0c96faaabfbf2447a43af035dd6b","_number":9211,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-22 19:27:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-11-22 19:27:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-03 18:38:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-11-03 19:11:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-11-11 17:29:56.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"90bc955fb63c00f2b09211bade585cee6d66abe3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-03 17:53:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ca550b5c36c246eb3bf3c0340e3b6959d9a3ebeb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-11-03 19:11:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/22200/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/21317/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fb1e80a152441ee8422c139341497ced15ee0906","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-11-11 17:29:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"facc2e3add5b8e96250ed927cf4936a5ef6b780a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-11-22 19:27:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"86d10417c27e0c96faaabfbf2447a43af035dd6b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-11-22 19:27:14.000000000","message":"Change has been successfully cherry-picked as cd41947febbeb908e2c0dbf6c3c0e74d799da6c0","accounts_in_message":[],"_revision_number":2}],"current_revision":"cd41947febbeb908e2c0dbf6c3c0e74d799da6c0","revisions":{"f595972881d37051611624de2ac235bdd477d2a5":{"kind":"REWORK","_number":1,"created":"2025-11-03 17:53:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/11/9211/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/9211/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/1 \u0026\u0026 git checkout -b change-9211 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/9211/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56d6e6dee415d12c42979c3f49ba31a3bf9cdf3b","subject":"target, breakpoints: report hit watchpoint in trivial case"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-03 16:33:12.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-03 17:52:50.000000000","tz":60},"subject":"target/cortex_a: fix HW breakpoint length for gdb kind 3","message":"target/cortex_a: fix HW breakpoint length for gdb kind 3\n\nGdb uses length 3 to set breakpoint on a 4 byte Thumb-2\ninstruction. Without this patch a breakpoint on down aligned word\naddress was set. If the requested address was not word aligned,\nthe breakpoint triggered at previous instruction and was not\nrecognised properly by gdb.\n\nSet breakpoint on whole word if aligns with requested address,\notherwise use length 2 and set byte mask.\n\nChange-Id: I12d1c57b7154e64abdf23dd7cd31714f9d8ec6f0\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"cd41947febbeb908e2c0dbf6c3c0e74d799da6c0":{"kind":"REWORK","_number":2,"created":"2025-11-22 19:27:14.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/11/9211/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/11/9211/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/2 \u0026\u0026 git checkout -b change-9211 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/11/9211/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/11/9211/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a247ff122380a6a6e14878b462785fc209f875b0","subject":"target, breakpoints: report hit watchpoint in trivial case"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-03 16:33:12.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-11-22 19:27:14.000000000","tz":0},"subject":"target/cortex_a: fix HW breakpoint length for gdb kind 3","message":"target/cortex_a: fix HW breakpoint length for gdb kind 3\n\nGdb uses length 3 to set breakpoint on a 4 byte Thumb-2\ninstruction. Without this patch a breakpoint on down aligned word\naddress was set. If the requested address was not word aligned,\nthe breakpoint triggered at previous instruction and was not\nrecognised properly by gdb.\n\nSet breakpoint on whole word if aligns with requested address,\notherwise use length 2 and set byte mask.\n\nChange-Id: I12d1c57b7154e64abdf23dd7cd31714f9d8ec6f0\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9211\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}