)]}'
{"src/jtag/drivers/ti_icdi_usb.c":[{"author":{"_account_id":1000018,"name":"Mathias Küster","email":"kesmtp@freenet.de","username":"mathen"},"change_message_id":"e9bdf6046a3fb27fb55801e9c2b071cab78274cb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\tint tmp;"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"\tfor (i \u003d 0; i \u003c count; i++) {"},{"line_number":66,"context_line":"\t\tsscanf(hex + (2 * i), \"%02x\", \u0026tmp);"},{"line_number":67,"context_line":"\t\tbin[i] \u003d tmp;"},{"line_number":68,"context_line":"\t}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":11,"id":"AAAA7n%2F%2F%2F8I%3D","line":66,"updated":"2012-11-09 19:04:54.000000000","message":"Return value should be checked.","commit_id":"ecd4b778f2d153e17236ba10161f9af26bc407d5"},{"author":{"_account_id":1000018,"name":"Mathias Küster","email":"kesmtp@freenet.de","username":"mathen"},"change_message_id":"e9bdf6046a3fb27fb55801e9c2b071cab78274cb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"\tint i;"},{"line_number":76,"context_line":"\tint cmd_len \u003d 0;"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\t/* May use a length, or a nul-terminated string as input. */"},{"line_number":79,"context_line":"\tif (count \u003d\u003d 0)"},{"line_number":80,"context_line":"\t\tcount \u003d strlen(bin);"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":11,"id":"AAAA7n%2F%2F%2F8Q%3D","line":78,"updated":"2012-11-09 19:04:54.000000000","message":"nul?","commit_id":"ecd4b778f2d153e17236ba10161f9af26bc407d5"},{"author":{"_account_id":1000018,"name":"Mathias Küster","email":"kesmtp@freenet.de","username":"mathen"},"change_message_id":"e9bdf6046a3fb27fb55801e9c2b071cab78274cb","unresolved":false,"context_lines":[{"line_number":80,"context_line":"\t\tcount \u003d strlen(bin);"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\tfor (i \u003d 0; i \u003c count; i++)"},{"line_number":83,"context_line":"\t\tcmd_len +\u003d sprintf(hex + cmd_len, \"%02x\", bin[i]);"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"\treturn cmd_len;"},{"line_number":86,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"AAAA7n%2F%2F%2F8M%3D","line":83,"updated":"2012-11-09 19:04:54.000000000","message":"snprintf is the better choice, you should always use a destination buffer length","commit_id":"ecd4b778f2d153e17236ba10161f9af26bc407d5"}]}