)]}'
{"id":"openocd~master~I0f27145cad24686cf539aebfea7f6578b7cd78ab","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-11-12 20:53:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0f27145cad24686cf539aebfea7f6578b7cd78ab","subject":"target/riscv: fix progbuf memory writes in case last write is busy","status":"MERGED","created":"2025-11-06 10:47:08.000000000","updated":"2025-11-12 20:53:02.000000000","submitted":"2025-11-12 20:53:02.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9233","meta_rev_id":"edcfb3973db0bac2bfc8f6a4e35a15e60cdc0b1f","_number":9233,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-11-12 20:53:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-11-12 20:53:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-06 10:51:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-11-06 11:07:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-11-07 07:38:39.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"db8c7582a761280551faddd57a69100b360bcbf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-11-06 10:47:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e554314fc95ec79251a79c20fa3e01ca39fc6de8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-11-06 11:07:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/22253/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/21367/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ff413783aafe14213147af12b2b34c64a02afa09","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-07 07:38:39.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"edcfb3973db0bac2bfc8f6a4e35a15e60cdc0b1f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-12 20:53:02.000000000","message":"Change has been successfully cherry-picked as 4e78563a0083d32a7cbb3ebfa92f7b9142637bf3","accounts_in_message":[],"_revision_number":2}],"current_revision":"4e78563a0083d32a7cbb3ebfa92f7b9142637bf3","revisions":{"4e78563a0083d32a7cbb3ebfa92f7b9142637bf3":{"kind":"REWORK","_number":2,"created":"2025-11-12 20:53:02.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/33/9233/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/9233/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/2 \u0026\u0026 git checkout -b change-9233 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/9233/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d7fb95d8003b01c2d6aa3e53a2d3eafbddfcb5a1","subject":"tcl/target: update riscv commands in configs"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-10-28 14:16:55.000000000","tz":180},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-12 20:53:02.000000000","tz":0},"subject":"target/riscv: fix progbuf memory writes in case last write is busy","message":"target/riscv: fix progbuf memory writes in case last write is busy\n\nRestarting the program buffer memory write pipeline when the write of\nthe last element resulted in the busy response triggers an extra memory\nwrtite, that is cought by an assertion:\n```\nsrc/target/riscv/riscv-013.c:5048: write_memory_progbuf_inner: Assertion\n`next_addr_on_target - args.address \u003c\u003d (target_addr_t)args.size *\nargs.count\u0027 failed.\n```\n\nChange-Id: I0f27145cad24686cf539aebfea7f6578b7cd78ab\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9233\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"c1d8ff3022aabf969d23538f8938a0e96fe2698f":{"kind":"REWORK","_number":1,"created":"2025-11-06 10:47:08.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/33/9233/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/33/9233/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/1 \u0026\u0026 git checkout -b change-9233 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/33/9233/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/33/9233/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"618ddb68c6e8cd12105f77a1f40f3c6d285156fa","subject":"tcl/target: update riscv commands in configs"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-10-28 14:16:55.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2025-11-06 10:46:45.000000000","tz":180},"subject":"target/riscv: fix progbuf memory writes in case last write is busy","message":"target/riscv: fix progbuf memory writes in case last write is busy\n\nRestarting the program buffer memory write pipeline when the write of\nthe last element resulted in the busy response triggers an extra memory\nwrtite, that is cought by an assertion:\n```\nsrc/target/riscv/riscv-013.c:5048: write_memory_progbuf_inner: Assertion\n`next_addr_on_target - args.address \u003c\u003d (target_addr_t)args.size *\nargs.count\u0027 failed.\n```\n\nChange-Id: I0f27145cad24686cf539aebfea7f6578b7cd78ab\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
