)]}'
{"id":"openocd~master~I804605d31310698445b3ffb5e3fcad1fc43a5579","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2025-11-19 13:39:48.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-11-19 13:34:50.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I804605d31310698445b3ffb5e3fcad1fc43a5579","subject":"target: rework target_checksum_memory()","status":"MERGED","created":"2025-11-19 11:08:21.000000000","updated":"2025-12-29 11:55:17.000000000","submitted":"2025-12-29 11:55:17.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9242","meta_rev_id":"4b814e304bf1a1dabb1c5e4b28b602f174c5be1f","_number":9242,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-12-29 11:55:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-12-29 11:55:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-12-29 11:55:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-19 11:08:35.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-11-19 11:27:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-11-19 12:13:59.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"CC"},{"updated":"2025-11-19 13:39:48.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2025-12-29 11:55:17.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"7ee86d4dd43054ea98644ceeb822de93a1bf8fe0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-19 11:08:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"49305cb5ba4ee9b0379704a230cfe5f79fc8468a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-11-19 11:27:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/22311/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/21424/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"14ff7b11753426d49a33163d239f58ae41f10db5","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-11-19 12:13:59.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d0e1a39a8638be44c3b1f998d6a1b176dcf0bc10","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-19 12:39:56.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6455b80faa4c0a0b06717ee1b41f41a95f8dbc09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-19 13:21:31.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c6d79269e874d2d9ae9f375137dfd974b8a33555","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-11-19 13:34:50.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"59e2e73492146c6e9faaeb7d24218fe1f907d30c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-11-19 13:38:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/22313/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/21426/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"919e2abb8bcb05aa6701cb1b57c0a53674d30b54","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2025-11-19 13:39:48.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0a0efbf1d77e64d5f398ec1be7e0d9421ce3658c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-12-14 20:55:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4b814e304bf1a1dabb1c5e4b28b602f174c5be1f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-12-29 11:55:17.000000000","message":"Change has been successfully cherry-picked as 4593222e857f4f74010e321267cd3a3a12c32740","accounts_in_message":[],"_revision_number":3}],"current_revision":"4593222e857f4f74010e321267cd3a3a12c32740","revisions":{"b8637104b8e88dfae33edfd64a714ffdabddc888":{"kind":"REWORK","_number":1,"created":"2025-11-19 11:08:21.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/42/9242/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9242/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/1 \u0026\u0026 git checkout -b change-9242 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9242/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e78563a0083d32a7cbb3ebfa92f7b9142637bf3","subject":"target/riscv: fix progbuf memory writes in case last write is busy"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-19 06:56:40.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-19 08:16:25.000000000","tz":60},"subject":"target, gdb_server: allow GDB compare-sections without checksum_memory","message":"target, gdb_server: allow GDB compare-sections without checksum_memory\n\nSome targets do not have checksum_memory() method implemented.\nWithout this patch GDB \u0027compare-sections\u0027 fails on such target\nbecause OpenOCD propagates non implemented method as a general\nerror.\n\nGDB compare-sections command can work-around not implemented\nqCrc remote protocol command by simple memory read.\n\nReturn qCrc reply as it were not implemented in the case the target\nmisses checksum_memory() method implementation. GDB \u0027compare-sections\u0027\nis slow but works.\n\nChange-Id: I804605d31310698445b3ffb5e3fcad1fc43a5579\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"67632b4bc016e80f748e051cfbebfae9b071d037":{"kind":"REWORK","_number":2,"created":"2025-11-19 13:21:31.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/42/9242/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9242/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/2 \u0026\u0026 git checkout -b change-9242 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9242/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e78563a0083d32a7cbb3ebfa92f7b9142637bf3","subject":"target/riscv: fix progbuf memory writes in case last write is busy"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-19 13:04:55.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-19 13:20:29.000000000","tz":60},"subject":"target: rework target_checksum_memory()","message":"target: rework target_checksum_memory()\n\nCommit d7142a572710 (\"target/target: Check checksum_memory\nbefore call\") added the error return if target\u0027s checksum_memory()\nmethod is not implemented however the slow path with read buffer and\nimage_calculate_checksum() should be used instead.\n\nAlso the code fragment commented as /* convert to target endianness */\nis a pure nonsense - it does not convert anything. Drop the conversion\nloop.\n\nChange-Id: I804605d31310698445b3ffb5e3fcad1fc43a5579\nSuggested-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"4593222e857f4f74010e321267cd3a3a12c32740":{"kind":"REWORK","_number":3,"created":"2025-12-29 11:55:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/42/9242/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9242/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/3 \u0026\u0026 git checkout -b change-9242 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9242/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9242/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"df2eb07086c3639876659b7866a1b0e33db7c29e","subject":"flash/nor/bl602: add bl602 flash driver"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-11-19 13:04:55.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-12-29 11:55:17.000000000","tz":0},"subject":"target: rework target_checksum_memory()","message":"target: rework target_checksum_memory()\n\nCommit d7142a572710 (\"target/target: Check checksum_memory\nbefore call\") added the error return if target\u0027s checksum_memory()\nmethod is not implemented however the slow path with read buffer and\nimage_calculate_checksum() should be used instead.\n\nAlso the code fragment commented as /* convert to target endianness */\nis a pure nonsense - it does not convert anything. Drop the conversion\nloop.\n\nChange-Id: I804605d31310698445b3ffb5e3fcad1fc43a5579\nSuggested-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9242\nReviewed-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}