)]}'
{"src/target/arm_dap.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e9927538b2aa0c782312d52fd4a6be127846f8d2","unresolved":true,"context_lines":[{"line_number":478,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":479,"context_line":"\t}"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"\tif (apsel_gateway \u003d\u003d DP_APSEL_INVALID)"},{"line_number":482,"context_line":"\t\tap \u003d dap_get_ap(dap, apsel);"},{"line_number":483,"context_line":"\telse"},{"line_number":484,"context_line":"\t\tap \u003d dap_get_ap_gateway(dap, apsel, apsel_gateway);"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"\tif (!ap) {"},{"line_number":487,"context_line":"\t\tcommand_print(CMD, \"Cannot get AP\");"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"aaa4a5d7_02836775","line":484,"range":{"start_line":481,"start_character":1,"end_line":484,"end_character":53},"updated":"2025-11-23 06:30:01.000000000","message":"This and many following patches contain this code pattern.\nWouldn\u0027t be better to introduce a function to get ap with optional apsel_gateway, which does exactly same as these 4 lines?\nMaybe it can fully replace `dap_get_ap_gateway()`","commit_id":"bd656a4b033b15a64f173477fd9e907659040b6e"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"275bff62d1cc4af2f98ba6f729f982d4fcc6e539","unresolved":true,"context_lines":[{"line_number":478,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":479,"context_line":"\t}"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"\tif (apsel_gateway \u003d\u003d DP_APSEL_INVALID)"},{"line_number":482,"context_line":"\t\tap \u003d dap_get_ap(dap, apsel);"},{"line_number":483,"context_line":"\telse"},{"line_number":484,"context_line":"\t\tap \u003d dap_get_ap_gateway(dap, apsel, apsel_gateway);"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"\tif (!ap) {"},{"line_number":487,"context_line":"\t\tcommand_print(CMD, \"Cannot get AP\");"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b4ebb72f_191cca2f","line":484,"range":{"start_line":481,"start_character":1,"end_line":484,"end_character":53},"in_reply_to":"aaa4a5d7_02836775","updated":"2025-11-24 02:59:49.000000000","message":"Thanks for pointing this out and I agree. I\u0027ll update the patch series with a fix for this.","commit_id":"bd656a4b033b15a64f173477fd9e907659040b6e"}]}