)]}'
{"id":"openocd~master~Ie8320fa6ee2086981c0b1f3c18f51e171709078d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002465":{"account":{"_account_id":1002465,"name":"Niklas Gürtler","email":"profclonk@gmail.com","username":"NiklasGuertler"},"last_update":"2025-12-12 19:14:30.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie8320fa6ee2086981c0b1f3c18f51e171709078d","subject":"tcl/target/stm32l4, tcl/target/stm32w*: Fix clock configuration","status":"MERGED","created":"2025-12-03 11:43:45.000000000","updated":"2025-12-12 19:14:30.000000000","submitted":"2025-12-12 19:14:30.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9282","meta_rev_id":"97305624273d62e1cb39c04e7c11345658b66db3","_number":9282,"owner":{"_account_id":1002465,"name":"Niklas Gürtler","email":"profclonk@gmail.com","username":"NiklasGuertler"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-12-12 19:14:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-12-12 19:14:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-03 11:44:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-12-03 12:11:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-12-05 20:45:27.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"e4be87cbe38d183e677e4986cebce60fda4fb453","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002465,"name":"Niklas Gürtler","email":"profclonk@gmail.com","username":"NiklasGuertler"},"real_author":{"_account_id":1002465,"name":"Niklas Gürtler","email":"profclonk@gmail.com","username":"NiklasGuertler"},"date":"2025-12-03 11:43:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"261a1f11f339fa336401c575d9da243bce60d927","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-12-03 12:11:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/22417/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/21530/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"31b2ce7d5c59283cdff65aa8390ac7ba8d0207ab","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-12-05 20:45:27.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"97305624273d62e1cb39c04e7c11345658b66db3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-12-12 19:14:30.000000000","message":"Change has been successfully cherry-picked as 5479c58d23771c31d6f034a63b3f01b83ed5129a","accounts_in_message":[],"_revision_number":2}],"current_revision":"5479c58d23771c31d6f034a63b3f01b83ed5129a","revisions":{"5479c58d23771c31d6f034a63b3f01b83ed5129a":{"kind":"REWORK","_number":2,"created":"2025-12-12 19:14:30.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/82/9282/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/9282/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/2 \u0026\u0026 git checkout -b change-9282 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/9282/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8115c286637eabfbc48712e41d901f3d1090f408","subject":"tcl/target/gd32vf103: copy a few minor settings from riscv-openocd"}],"author":{"name":"Niklas Gürtler","email":"profclonk@gmail.com","date":"2025-12-03 11:03:11.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-12-12 19:14:30.000000000","tz":0},"subject":"tcl/target/stm32l4, tcl/target/stm32w*: Fix clock configuration","message":"tcl/target/stm32l4, tcl/target/stm32w*: Fix clock configuration\n\nFor stm32l4, stm32wbx, stm32wlx the target tcl scripts try to change the\nMSI oscillator\u0027s speed to 24 MHz before boosting the interface\nfrequency, but don\u0027t clear the RCC_CR_MSIRANGE field correctly before.\nThis causes the register write access to fail and leaves the clock\nfrequency unchanged. For the stm32wlx, the script also neglects to set\nthe MSIRGSEL bit, such that the frequency setting is not actually\napplied.\n\nThe issue appears to not cause a problem when using an ST-Link adapter.\nWhen using an FT4232HP, communication to the target fails after the\nreset-init event, possibly because this adapter actually supports the\nhigher interface frequency.\n\nThis commit fixes the register accesses to make sure the RCC_CR_MSIRANGE\nis cleared to zero before OR-ing the new value. For the stm32wlx, also\nset the MSIRGSEL bit. Just to be safe, also fix the write access to the\nFLASH_ACR_LATENCY field to clear it before OR-ing, even though it should\nbe zero at reset anyways.\n\nChange-Id: Ie8320fa6ee2086981c0b1f3c18f51e171709078d\nSigned-off-by: Niklas Gürtler \u003cprofclonk@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9282\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"2df57622e8d949f7f252e053c97a7e1d875e0321":{"kind":"REWORK","_number":1,"created":"2025-12-03 11:43:45.000000000","uploader":{"_account_id":1002465,"name":"Niklas Gürtler","email":"profclonk@gmail.com","username":"NiklasGuertler"},"ref":"refs/changes/82/9282/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/9282/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/1 \u0026\u0026 git checkout -b change-9282 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/9282/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/9282/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ac6972ba16b471cb46a2d862fb24d54b98b4bb61","subject":"adapter/gpio: Use command_print() instead of LOG_ERROR()"}],"author":{"name":"Niklas Gürtler","email":"profclonk@gmail.com","date":"2025-12-03 11:03:11.000000000","tz":60},"committer":{"name":"Niklas Gürtler","email":"profclonk@gmail.com","date":"2025-12-03 11:43:11.000000000","tz":60},"subject":"tcl/target/stm32l4, tcl/target/stm32w*: Fix clock configuration","message":"tcl/target/stm32l4, tcl/target/stm32w*: Fix clock configuration\n\nFor stm32l4, stm32wbx, stm32wlx the target tcl scripts try to change the\nMSI oscillator\u0027s speed to 24 MHz before boosting the interface\nfrequency, but don\u0027t clear the RCC_CR_MSIRANGE field correctly before.\nThis causes the register write access to fail and leaves the clock\nfrequency unchanged. For the stm32wlx, the script also neglects to set\nthe MSIRGSEL bit, such that the frequency setting is not actually\napplied.\n\nThe issue appears to not cause a problem when using an ST-Link adapter.\nWhen using an FT4232HP, communication to the target fails after the\nreset-init event, possibly because this adapter actually supports the\nhigher interface frequency.\n\nThis commit fixes the register accesses to make sure the RCC_CR_MSIRANGE\nis cleared to zero before OR-ing the new value. For the stm32wlx, also\nset the MSIRGSEL bit. Just to be safe, also fix the write access to the\nFLASH_ACR_LATENCY field to clear it before OR-ing, even though it should\nbe zero at reset anyways.\n\nChange-Id: Ie8320fa6ee2086981c0b1f3c18f51e171709078d\nSigned-off-by: Niklas Gürtler \u003cprofclonk@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}