)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b4360f95c2de6ed1bfeacf7adffed4280d89044f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b76bc9c1_84133aa6","updated":"2026-05-02 10:35:50.000000000","message":"Merge?","commit_id":"ac80a80a8f77596a9928563df0505a733d787fd6"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"873997d863d5dca4773e03c4fc835074b117bea2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cf697721_80abb4a9","updated":"2026-04-15 07:08:02.000000000","message":"Ping","commit_id":"ac80a80a8f77596a9928563df0505a733d787fd6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"73bbccc947d8e928c7d6bc8404f7a8a9542d34b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"03d11880_cafa911f","updated":"2026-05-04 07:17:44.000000000","message":"Thanks!","commit_id":"ec3b009a9ce1c60c2b7bc791acaf181f70f3f436"}],"src/flash/nand/fileio.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b34e7455b4fdfe1828c4259215c671311cf3af8e","unresolved":true,"context_lines":[{"line_number":99,"context_line":"{"},{"line_number":100,"context_line":"\tnand_fileio_cleanup(state);"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\tif (duration_measure(\u0026state-\u003ebench) !\u003d ERROR_OK)"},{"line_number":103,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5b69a3c6_81b51e9e","line":102,"updated":"2026-05-03 13:50:32.000000000","message":"I agree that the original code was incorrect, as `duration_measure()` was returning `0` or `-1` while the callers of `nand_fileio_finish()` where checking against `ERROR_OK`.\nBut now that `duration_measure()` returns a proper `ERROR_xx`, why changing this code instead of propagating the error?\nThis should remain\n`return duration_measure(\u0026state-\u003ebench);`","commit_id":"ac80a80a8f77596a9928563df0505a733d787fd6"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"4e399e010ec4bc121988700accffc7026881cedf","unresolved":false,"context_lines":[{"line_number":99,"context_line":"{"},{"line_number":100,"context_line":"\tnand_fileio_cleanup(state);"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\tif (duration_measure(\u0026state-\u003ebench) !\u003d ERROR_OK)"},{"line_number":103,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"dddeae43_bb344dca","line":102,"in_reply_to":"5b69a3c6_81b51e9e","updated":"2026-05-03 21:39:14.000000000","message":"You\u0027re right, that\u0027s a leftover from `int` -\u003e `bool` -\u003e `int` (`ERROR_xx`) return type. Fixed.","commit_id":"ac80a80a8f77596a9928563df0505a733d787fd6"}],"src/helper/time_support.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f499832dd787926ddeb9cd7ec725ff56f50d3699","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"int duration_start(struct duration *duration)"},{"line_number":70,"context_line":"{"},{"line_number":71,"context_line":"\treturn gettimeofday(\u0026duration-\u003estart, NULL);"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"int duration_measure(struct duration *duration)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3b754484_e87f859a","side":"PARENT","line":71,"updated":"2025-12-08 12:53:12.000000000","message":"Agree that returning the value from `gettimeofday()` is incorrect, but instead of returning bool I think we should return `ERROR_OK` / `ERROR_FAIL`","commit_id":"656047706179796a246105815cdb053c0b0a53b4"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"873997d863d5dca4773e03c4fc835074b117bea2","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"int duration_start(struct duration *duration)"},{"line_number":70,"context_line":"{"},{"line_number":71,"context_line":"\treturn gettimeofday(\u0026duration-\u003estart, NULL);"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"int duration_measure(struct duration *duration)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"31dbeff0_63782a02","side":"PARENT","line":71,"in_reply_to":"3b754484_e87f859a","updated":"2026-04-15 07:08:02.000000000","message":"Done","commit_id":"656047706179796a246105815cdb053c0b0a53b4"}]}