)]}'
{"id":"openocd~master~Iccfddb3e34f3f26927983f3b00d9d5f81b06eb21","project":"openocd","branch":"master","hashtags":[],"change_id":"Iccfddb3e34f3f26927983f3b00d9d5f81b06eb21","subject":"target: cortex_a: support read and write watchpoints","status":"MERGED","created":"2025-12-09 09:48:19.000000000","updated":"2026-01-11 18:13:54.000000000","submitted":"2026-01-11 18:13:54.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9291","meta_rev_id":"fb666d242c1478fb69342308df57cea6961d57c5","_number":9291,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-01-11 18:13:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-01-11 18:13:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-09 09:48:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-12-09 10:04:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6eea1d30890711ac8803b3d9788cc1394eeb32ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-12-09 09:48:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8df917463d51ca46c6eb276956642bcfd0eb612b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-12-09 10:04:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21543/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22430/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"24a94edf6b045461878aaf04e49722b1babc3c58","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2025-12-09 10:52:12.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b2090bc1b976bdd2973763879a8e7a352aca5f37","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-11 18:10:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fb666d242c1478fb69342308df57cea6961d57c5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-11 18:13:54.000000000","message":"Change has been successfully cherry-picked as e39ae004b073652f7dccc3ff8d6021d6494646b9","accounts_in_message":[],"_revision_number":2}],"current_revision":"e39ae004b073652f7dccc3ff8d6021d6494646b9","revisions":{"608eabd8d134d18813e04fcee2868138e761de0d":{"kind":"REWORK","_number":1,"created":"2025-12-09 09:48:19.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/9291/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/9291/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/1 \u0026\u0026 git checkout -b change-9291 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/9291/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa9ff8dc5ec60c46134f57a2f858149bb083036e","subject":"target/esirisc_trace: drop macro BIT_MASK() conflicting with bits.h"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-12-09 08:35:06.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-12-09 09:47:48.000000000","tz":60},"subject":"target: cortex_a: support read and write watchpoints","message":"target: cortex_a: support read and write watchpoints\n\nThe current code for cortex_a watchpoint sets the field DBGWCR:LSC\nto \u00273\u0027, that corresponds to \u0027access\u0027 watchpoint.\nThus, any \u0027r\u0027 or \u0027w\u0027 watchpoint is considered to \u0027a\u0027.\n\nConvert the enum watchpoint_rw to the corresponding values for the\nfield DBGWCR:LSC.\n\nChange-Id: Iccfddb3e34f3f26927983f3b00d9d5f81b06eb21\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e39ae004b073652f7dccc3ff8d6021d6494646b9":{"kind":"REWORK","_number":2,"created":"2026-01-11 18:13:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/9291/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/9291/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/2 \u0026\u0026 git checkout -b change-9291 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/9291/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/9291/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0eecf4d21d73585b4f882e6859c8c331880cd2e3","subject":"target/aarch64: fix last_run_control_op on SMP"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-12-09 08:35:06.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-11 18:13:54.000000000","tz":0},"subject":"target: cortex_a: support read and write watchpoints","message":"target: cortex_a: support read and write watchpoints\n\nThe current code for cortex_a watchpoint sets the field DBGWCR:LSC\nto \u00273\u0027, that corresponds to \u0027access\u0027 watchpoint.\nThus, any \u0027r\u0027 or \u0027w\u0027 watchpoint is considered to \u0027a\u0027.\n\nConvert the enum watchpoint_rw to the corresponding values for the\nfield DBGWCR:LSC.\n\nChange-Id: Iccfddb3e34f3f26927983f3b00d9d5f81b06eb21\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9291\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
