)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"5b2eb1f336a56a0a275bcdb82efc5616313ae094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24118578_d0f90209","updated":"2026-01-07 14:27:14.000000000","message":"Hi Tomas,\nWould you be able to take a look at these patches?\nOr advise me if anything needs to be done.\nThanks,\nMark","commit_id":"91256fb2d28458c508ae5ba3687a0985968490ab"}],"tcl/target/max32680.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"07b3ed626a5505ede4c4198790e8c6182da20e1a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set ADAPTER_KHZ 500"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Set the reset pin configuration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"7f3a3579_ffd671e8","line":2,"updated":"2026-01-08 05:10:32.000000000","message":"A meaningful description of the target (e.g. Cortex-M4 @ 168MHz, SWD debug only) or URL of the documentation is a good habit in OpenOCD config files.","commit_id":"91256fb2d28458c508ae5ba3687a0985968490ab"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"ea98a6b8521e8a9ef2a93fd734d413745db1334f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set ADAPTER_KHZ 500"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Set the reset pin configuration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"941ea98a_5514557b","line":2,"in_reply_to":"7f3a3579_ffd671e8","updated":"2026-01-08 16:17:43.000000000","message":"Done","commit_id":"91256fb2d28458c508ae5ba3687a0985968490ab"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"07b3ed626a5505ede4c4198790e8c6182da20e1a","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Set the reset pin configuration"},{"line_number":6,"context_line":"reset_config srst_only"},{"line_number":7,"context_line":"adapter srst delay 2"},{"line_number":8,"context_line":"adapter srst pulse_width 2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Set flash parameters"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"88ea215f_44cc579a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2026-01-08 05:10:32.000000000","message":"Should not be necessary with swd transport","commit_id":"91256fb2d28458c508ae5ba3687a0985968490ab"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"ea98a6b8521e8a9ef2a93fd734d413745db1334f","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Set the reset pin configuration"},{"line_number":6,"context_line":"reset_config srst_only"},{"line_number":7,"context_line":"adapter srst delay 2"},{"line_number":8,"context_line":"adapter srst pulse_width 2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Set flash parameters"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3a63b6bb_13a4c1fb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"in_reply_to":"88ea215f_44cc579a","updated":"2026-01-08 16:17:43.000000000","message":"Done","commit_id":"91256fb2d28458c508ae5ba3687a0985968490ab"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c168ea9097584db07f98e22019a50e2e60b786fd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1926080e_cbd06625","line":19,"updated":"2026-01-09 19:44:30.000000000","message":"If the device really needs slower clock, set it here (only the last setting is used)","commit_id":"b71705109c8b638a0e926b083f24227e5001210f"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"eb713b8844f1935c5a9807a2035437f7baad74d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1bb51c51_1ae9bd44","line":19,"in_reply_to":"1926080e_cbd06625","updated":"2026-01-09 20:01:43.000000000","message":"As we no longer set the speed here or in the include file we will operate at the default 100kHz, so this should not be a problem.\nI do not have one of these boards and they appear to be rare, but the 500 value was being overwritten anyway, so we should be fixing it if anything.","commit_id":"b71705109c8b638a0e926b083f24227e5001210f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c58306a78738e69cd4dfd41f3a5178a3fc8029a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff90c91f_40104f0d","line":19,"in_reply_to":"1bb51c51_1ae9bd44","updated":"2026-01-09 20:22:04.000000000","message":"Okay then. Thanks!","commit_id":"b71705109c8b638a0e926b083f24227e5001210f"}],"tcl/target/max32xxx_common.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"07b3ed626a5505ede4c4198790e8c6182da20e1a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"source [find mem_helper.tcl]"},{"line_number":6,"context_line":"source [find target/swj-dp.tcl]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Set the adapter speed"},{"line_number":9,"context_line":"if { [info exists ADAPTER_KHZ] } {"},{"line_number":10,"context_line":"   set _ADAPTER_KHZ $ADAPTER_KHZ"},{"line_number":11,"context_line":"} else {"},{"line_number":12,"context_line":"   set _ADAPTER_KHZ 2000"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":"adapter speed $_ADAPTER_KHZ"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Target configuration"},{"line_number":17,"context_line":"if { [info exists CHIPNAME] } {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b1287da0_d00c4f04","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":27},"updated":"2026-01-08 05:10:32.000000000","message":"Honestly I\u0027m not a fan of reinventing the wheel.\nHundreds of OpenOCD targets don\u0027t set the adapter speed (the preferred option) or use `adapter speed` directly. Just the max32xxx based configs need a special Tcl variable (BTW named according to the deprecated command).\n\nCouldn\u0027t you simply remove this instrumentation (and use `adapter speed` if needed)? The problem in max32680.cfg shows how error prone such specialities are...","commit_id":"91256fb2d28458c508ae5ba3687a0985968490ab"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"ea98a6b8521e8a9ef2a93fd734d413745db1334f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"source [find mem_helper.tcl]"},{"line_number":6,"context_line":"source [find target/swj-dp.tcl]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Set the adapter speed"},{"line_number":9,"context_line":"if { [info exists ADAPTER_KHZ] } {"},{"line_number":10,"context_line":"   set _ADAPTER_KHZ $ADAPTER_KHZ"},{"line_number":11,"context_line":"} else {"},{"line_number":12,"context_line":"   set _ADAPTER_KHZ 2000"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":"adapter speed $_ADAPTER_KHZ"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Target configuration"},{"line_number":17,"context_line":"if { [info exists CHIPNAME] } {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6da60436_683d6c55","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":27},"in_reply_to":"b1287da0_d00c4f04","updated":"2026-01-08 16:17:43.000000000","message":"Removed in a separate commit.\nNote: this causes a warning about adapter speed not being set and says it will run at very low speed.","commit_id":"91256fb2d28458c508ae5ba3687a0985968490ab"}]}