)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"06323d64c44aedc0eb59bac3a6d4992c51d2c1bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6017f1ec_4b64954a","updated":"2025-12-29 20:36:44.000000000","message":"Lucien,\nthe old code narrows the type for target specific work. It makes good sense to me as the target is undoubtedly 32 bit only.\nYour change moves one type cast deeper to `armv4_5_run_algorithm_inner()` and makes it implicit.","commit_id":"8cd61e65ea391446573bf517ef04b0e063fc655d"}],"src/target/armv4_5.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"06323d64c44aedc0eb59bac3a6d4992c51d2c1bb","unresolved":true,"context_lines":[{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":"/* wait for execution to complete and check exit point */"},{"line_number":1373,"context_line":"static int armv4_5_run_algorithm_completion(struct target *target,"},{"line_number":1374,"context_line":"\tuint32_t exit_point,"},{"line_number":1375,"context_line":"\tunsigned int timeout_ms,"},{"line_number":1376,"context_line":"\tvoid *arch_info)"},{"line_number":1377,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9732c007_33b53cbb","line":1374,"range":{"start_line":1374,"start_character":1,"end_line":1374,"end_character":9},"updated":"2025-12-29 20:36:44.000000000","message":"Here is narrowed type.","commit_id":"8cd61e65ea391446573bf517ef04b0e063fc655d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"06323d64c44aedc0eb59bac3a6d4992c51d2c1bb","unresolved":true,"context_lines":[{"line_number":1517,"context_line":"\tretval \u003d target_resume(target, false, entry_point, true, true);"},{"line_number":1518,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":1519,"context_line":"\t\treturn retval;"},{"line_number":1520,"context_line":"\tretval \u003d run_it(target, exit_point, timeout_ms, arch_info);"},{"line_number":1521,"context_line":""},{"line_number":1522,"context_line":"\tif (exit_point)"},{"line_number":1523,"context_line":"\t\tbreakpoint_remove(target, exit_point);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5707e19e_c516bca6","line":1520,"range":{"start_line":1520,"start_character":25,"end_line":1520,"end_character":35},"updated":"2025-12-29 20:36:44.000000000","message":"And this becomes an implicit cast","commit_id":"8cd61e65ea391446573bf517ef04b0e063fc655d"}]}
