)]}'
{"id":"openocd~master~I340ec3ee46f471f31170c6717ed74fb632f0da20","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-02-01 14:50:13.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I340ec3ee46f471f31170c6717ed74fb632f0da20","subject":"server: fix double free() on add_service() early return","status":"MERGED","created":"2026-01-04 17:42:50.000000000","updated":"2026-02-01 14:50:13.000000000","submitted":"2026-02-01 14:50:13.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9372","meta_rev_id":"e9452ed07a79119dfe21fb88eb633dd4ac88721b","_number":9372,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-01 14:50:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-02-01 14:50:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-04 17:47:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-01-04 18:15:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-01-09 20:15:37.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"7a79e1074a5c10e877a9843e7e372e404092310c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-04 17:42:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"deee511808e26d469decb8cb60c6cd68bc88e125","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-01-04 18:15:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21606/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22493/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c81a6d55b002dd65dc519d0facc3234fd9709a04","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-05 09:43:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d260f72031fe8e958ff19df0352dca66fcf3f5b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-05 09:56:35.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"8cb37c5edcc969b4c6de92951f1f7d1c81c493d4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-05 10:03:23.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2011b7ec0dd6fd841b683a89e6ab916af71eb442","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-01-05 10:13:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21619/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22506/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a478686d4e6053b32d3a22949be9fe4f36f0cf24","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-01-09 20:15:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e9452ed07a79119dfe21fb88eb633dd4ac88721b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-01 14:50:13.000000000","message":"Change has been successfully cherry-picked as f275432b270d40af1b37bf6fe53ac2f3fb4f1689","accounts_in_message":[],"_revision_number":3}],"current_revision":"f275432b270d40af1b37bf6fe53ac2f3fb4f1689","revisions":{"b24ed5aa08539a51eb06f9aebb2b0f08b1765679":{"kind":"REWORK","_number":1,"created":"2026-01-04 17:42:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/9372/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/9372/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/1 \u0026\u0026 git checkout -b change-9372 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/9372/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4593222e857f4f74010e321267cd3a3a12c32740","subject":"target: rework target_checksum_memory()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-04 16:23:12.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-04 16:33:24.000000000","tz":60},"subject":"server: fix double free() on add_service() early return","message":"server: fix double free() on add_service() early return\n\nThe function add_service() can return on error when cannot create\nthe new service. In this case the caller cannot assume that the\nparameter \u0027priv\u0027 has been taken in consideration and it should\ntake care of free() it.\nTo avoid a double free(), add_service() should not free() the\nparameter \u0027priv\u0027 if it exits with error.\n\nReplace the call to free_service() with a dedicated exit path on\nerror.\n\nChange-Id: I340ec3ee46f471f31170c6717ed74fb632f0da20\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Palsson \u003ckarlp@tweak.au\u003e\nFixes: 5ff384be086a (\"server: fix a new double free()\")\nFixes: 5ff384be086a (\"semihosting: fix memory leak and double free\")\n"}},"f275432b270d40af1b37bf6fe53ac2f3fb4f1689":{"kind":"REWORK","_number":3,"created":"2026-02-01 14:50:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/9372/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/9372/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/3 \u0026\u0026 git checkout -b change-9372 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/9372/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b9e40161613fd880fc85fdb357365b70e646ff23","subject":"flash/stm32l4x: Fix flash size address for STM32WBA5"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-04 16:23:12.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-01 14:50:13.000000000","tz":0},"subject":"server: fix double free() on add_service() early return","message":"server: fix double free() on add_service() early return\n\nThe function add_service() can return on error when cannot create\nthe new service. In this case the caller cannot assume that the\nparameter \u0027priv\u0027 has been taken in consideration and it should\ntake care of free() it.\nTo avoid a double free(), add_service() should not free() the\nparameter \u0027priv\u0027 if it exits with error.\n\nReplace the call to free_service() with a dedicated exit path on\nerror.\n\nChange-Id: I340ec3ee46f471f31170c6717ed74fb632f0da20\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Palsson \u003ckarlp@tweak.au\u003e\nFixes: 171454fffad3 (\"server: fix a new double free()\")\nFixes: 5ff384be086a (\"semihosting: fix memory leak and double free\")\nReviewed-on: https://review.openocd.org/c/openocd/+/9372\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"fac38d9c8777a713a49d61b2b131661d18f07e3c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-01-05 09:56:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/9372/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/9372/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/2 \u0026\u0026 git checkout -b change-9372 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/9372/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/9372/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4593222e857f4f74010e321267cd3a3a12c32740","subject":"target: rework target_checksum_memory()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-04 16:23:12.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-05 09:56:35.000000000","tz":0},"subject":"server: fix double free() on add_service() early return","message":"server: fix double free() on add_service() early return\n\nThe function add_service() can return on error when cannot create\nthe new service. In this case the caller cannot assume that the\nparameter \u0027priv\u0027 has been taken in consideration and it should\ntake care of free() it.\nTo avoid a double free(), add_service() should not free() the\nparameter \u0027priv\u0027 if it exits with error.\n\nReplace the call to free_service() with a dedicated exit path on\nerror.\n\nChange-Id: I340ec3ee46f471f31170c6717ed74fb632f0da20\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Palsson \u003ckarlp@tweak.au\u003e\nFixes: 171454fffad3 (\"server: fix a new double free()\")\nFixes: 5ff384be086a (\"semihosting: fix memory leak and double free\")\n"},"description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}