)]}'
{"id":"openocd~master~Ie22f5816819bc77ec611c3f251373d026ed9f784","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-02-15 18:14:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie22f5816819bc77ec611c3f251373d026ed9f784","subject":"target: clean up return value of target_type::blank_check_memory()","status":"MERGED","created":"2026-01-11 18:37:51.000000000","updated":"2026-02-15 18:14:12.000000000","submitted":"2026-02-15 18:14:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9386","meta_rev_id":"b3be75f8973662e5d7c42adcdccbb14e735e46f0","_number":9386,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-15 18:14:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-02-15 18:14:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-11 19:47:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-01-11 21:38:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-01-12 13:23:00.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"0f9666cddc61de0d8304349a96a59836ec7cb214","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-01-11 18:37:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3bdc799df480a286bbe4ab9a463dd0f40b3f1fda","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-01-11 21:38:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21643/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22531/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dea34ea6c67a5f7ca7d08fae388c5eb1ee775882","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-01-12 13:23:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b3be75f8973662e5d7c42adcdccbb14e735e46f0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:14:12.000000000","message":"Change has been successfully cherry-picked as 3c1bd502177ddb1af7e1df3b4d11fa0dd3a0fc27","accounts_in_message":[],"_revision_number":2}],"current_revision":"3c1bd502177ddb1af7e1df3b4d11fa0dd3a0fc27","revisions":{"93cef15efda8b0bac32440667fbb97dee34c481e":{"kind":"REWORK","_number":1,"created":"2026-01-11 18:37:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/9386/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/9386/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/1 \u0026\u0026 git checkout -b change-9386 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/9386/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e19f9f9a7661cb85d452becffd7750be8c494868","subject":"flash: virtual: simplify error checking"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-12-25 14:53:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-01-11 18:37:16.000000000","tz":60},"subject":"target: clean up return value of target_type::blank_check_memory()","message":"target: clean up return value of target_type::blank_check_memory()\n\nThe functions in struct target_type::blank_check_memory() return\neither an OpenOCD error or a positive value that indicates the\nnumber of blocks checked.\n\nTo prevent the mix of error codes and returned values, return the\nvalue through an additional parameter \u0027checked\u0027 and then return\nERROR_OK.\n\nWhile there:\n- change to unsigned int the parameter \u0027num_blocks\u0027;\n- in armv7m_blank_check_memory() verify that the working area can\n  contain at least two \u0027algo_block\u0027.\n\nChange-Id: Ie22f5816819bc77ec611c3f251373d026ed9f784\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"3c1bd502177ddb1af7e1df3b4d11fa0dd3a0fc27":{"kind":"REWORK","_number":2,"created":"2026-02-15 18:14:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/9386/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/9386/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/2 \u0026\u0026 git checkout -b change-9386 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/9386/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/9386/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5151c9845581ccd17e3ca3b9024f287f3f6c43de","subject":"flash: virtual: simplify error checking"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-12-25 14:53:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-15 18:14:12.000000000","tz":0},"subject":"target: clean up return value of target_type::blank_check_memory()","message":"target: clean up return value of target_type::blank_check_memory()\n\nThe functions in struct target_type::blank_check_memory() return\neither an OpenOCD error or a positive value that indicates the\nnumber of blocks checked.\n\nTo prevent the mix of error codes and returned values, return the\nvalue through an additional parameter \u0027checked\u0027 and then return\nERROR_OK.\n\nWhile there:\n- change to unsigned int the parameter \u0027num_blocks\u0027;\n- in armv7m_blank_check_memory() verify that the working area can\n  contain at least two \u0027algo_block\u0027.\n\nChange-Id: Ie22f5816819bc77ec611c3f251373d026ed9f784\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9386\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
