)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"f77ac4a919910f7f4e96952a0d4c914757339193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b10a45c4_a606fc1f","updated":"2026-02-11 10:05:44.000000000","message":"Hi Henrik,\n\nShould this feature also be documented here? https://www.openocd.org/doc/html/Flash-Commands.html","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8e3e4d1_33ab671d","updated":"2026-02-23 10:53:32.000000000","message":"Hi Mark,\n\nThank you very much for your review.  I will get the simple fixes done and submitted and will await your suggestion on the best path for sharing header files.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"6c8a1fb7582f4ecb10edc7e6dd2cccb0ccb55936","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70bc4be9_f0efabf1","in_reply_to":"24564397_cf903701","updated":"2026-02-23 18:59:44.000000000","message":"The HACKING file mentions: When adding a new command, the corresponding documentation should be added to doc/openocd.texi in the same commit.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"15258382f0bd566f1e7368a78235c8db07db397c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09230fbf_5bc04666","in_reply_to":"2bb9f2db_645dfaab","updated":"2026-02-25 20:50:32.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"7e5b456d1643f89e3ce626120a50c1a668bb12ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2bb9f2db_645dfaab","in_reply_to":"70bc4be9_f0efabf1","updated":"2026-02-25 10:35:07.000000000","message":"Section added to openocd.texi.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24564397_cf903701","in_reply_to":"b10a45c4_a606fc1f","updated":"2026-02-23 10:53:32.000000000","message":"That seems like a good idea.  How are changes to that submitted?","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"d5cf4595edba291d0552fdbb6239437404dce753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c750962_c03f8131","updated":"2026-02-25 11:36:37.000000000","message":"Updated the commit message in an attempt to kick off another build as the previous one timed out.","commit_id":"856641f1ba812b9dc8b82084f89e3104d848bb1e"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"f84daa53ab3d8ef4975e0e1fc3ba15809e534e43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad7ba5af_5d981be4","updated":"2026-03-12 09:17:46.000000000","message":"Adding Tomas as reviewer.","commit_id":"44abe3d3f0e5d29cdef83570575303be6c22480e"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"15258382f0bd566f1e7368a78235c8db07db397c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad2a7e68_dcde0553","updated":"2026-02-25 20:50:32.000000000","message":"Looks good.\nJust noting that the contrib/loaders/flash/max32xxx_qspi/ directory is not built by default.\nMultiple others aren\u0027t also, but if it should be it should be added in contrib/loaders/Makefile","commit_id":"44abe3d3f0e5d29cdef83570575303be6c22480e"}],"contrib/loaders/flash/max32xxx_qspi/algo_options.h":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"96dabd49b980c819d239f6c9d502167cc75d5669","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"87543b13_d9f96195","line":2,"updated":"2026-02-10 22:56:02.000000000","message":"A very similar file already exists in ./contrib/loaders/flash/max32xxx/algo_options.h\n\nWould it make sense to merge?\nThis is also the 4th definition of these options in this codebase.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"6c8a1fb7582f4ecb10edc7e6dd2cccb0ccb55936","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8e594bbf_d992cf7b","line":2,"in_reply_to":"3fac38be_c1ff6285","updated":"2026-02-23 18:59:44.000000000","message":"Hopefully one of the maintainers can chime in but current practice seems to be relative paths:\nsrc/flash/nor/max32xxx.c:#include \"../../../contrib/loaders/flash/max32xxx/max32xxx_write_arm.inc\"\ncontrib/loaders/flash/stm32/stm32l4x.c:#include \"../../../../src/flash/nor/stm32l4x.h\"","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3fac38be_c1ff6285","line":2,"in_reply_to":"87543b13_d9f96195","updated":"2026-02-23 10:53:32.000000000","message":"I prefer the code reuse that you suggest, but posted this patchset as is to keep an already large patch simpler.\nIs there a recommended way of sharing these values between contrib code and src code? There is no generic include folder after all where I could put the relevant header files","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"7e5b456d1643f89e3ce626120a50c1a668bb12ac","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d9e7f801_bea567a6","line":2,"in_reply_to":"8e594bbf_d992cf7b","updated":"2026-02-25 10:35:07.000000000","message":"I have moved the header file to src/flash/nor matching the structure for stm32l4x and removed the duplicate definitions.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"15258382f0bd566f1e7368a78235c8db07db397c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8fc4d26f_fe1e5056","line":2,"in_reply_to":"d9e7f801_bea567a6","updated":"2026-02-25 20:50:32.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"}],"contrib/loaders/flash/max32xxx_qspi/bin2c.py":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"96dabd49b980c819d239f6c9d502167cc75d5669","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"# Convert binary file to a hex encoded array for inclusion in C projects"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"import os"},{"line_number":5,"context_line":"import struct"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"import logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"8af7b8e8_f79cae1b","line":4,"updated":"2026-02-10 22:56:02.000000000","message":"This file seems to be python 2. It should really be using python 3 at this stage","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"888dbbf95763dd18a7bd2366747492fb715c60b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"# Convert binary file to a hex encoded array for inclusion in C projects"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"import os"},{"line_number":5,"context_line":"import struct"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"import logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"74bb6d2f_95d1e391","line":4,"in_reply_to":"8af7b8e8_f79cae1b","updated":"2026-02-23 22:25:19.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"7e5b456d1643f89e3ce626120a50c1a668bb12ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":"# Convert binary file to a hex encoded array for inclusion in C projects"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"import os"},{"line_number":5,"context_line":"import struct"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"import logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"f97e0e89_3e0fd73b","line":4,"in_reply_to":"8af7b8e8_f79cae1b","updated":"2026-02-25 10:35:07.000000000","message":"Removed from the patchset.  It was essentially providing the same functionality as the the bin2char.sh helper script.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"96dabd49b980c819d239f6c9d502167cc75d5669","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":118,"context_line":"    import getopt"},{"line_number":119,"context_line":"    import os"},{"line_number":120,"context_line":"    import sys"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    usage \u003d \u0027\u0027\u0027Bin2C python converting utility."}],"source_content_type":"text/x-python","patch_set":1,"id":"334e56ea_4e391786","line":119,"updated":"2026-02-10 22:56:02.000000000","message":"The os module was already imported at the top of the file.\nThere is also an \"import os.path\" statement below that is probably not needed also.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"888dbbf95763dd18a7bd2366747492fb715c60b3","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":118,"context_line":"    import getopt"},{"line_number":119,"context_line":"    import os"},{"line_number":120,"context_line":"    import sys"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    usage \u003d \u0027\u0027\u0027Bin2C python converting utility."}],"source_content_type":"text/x-python","patch_set":1,"id":"519c90dc_a574d593","line":119,"in_reply_to":"334e56ea_4e391786","updated":"2026-02-23 22:25:19.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"7e5b456d1643f89e3ce626120a50c1a668bb12ac","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":118,"context_line":"    import getopt"},{"line_number":119,"context_line":"    import os"},{"line_number":120,"context_line":"    import sys"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    usage \u003d \u0027\u0027\u0027Bin2C python converting utility."}],"source_content_type":"text/x-python","patch_set":1,"id":"9e4fa8c5_658e3144","line":119,"in_reply_to":"334e56ea_4e391786","updated":"2026-02-25 10:35:07.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"}],"contrib/loaders/flash/max32xxx_qspi/flc_regs.h":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"96dabd49b980c819d239f6c9d502167cc75d5669","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"83b18699_cdc7ce49","line":2,"updated":"2026-02-10 22:56:02.000000000","message":"This file and gcr_regs.h and tpu_regs.h already exists in contrib/loaders/flash/max32xxx/\n\nIs it possible to use those?","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a5cb3fc1_c56b508d","line":2,"in_reply_to":"83b18699_cdc7ce49","updated":"2026-02-23 10:53:32.000000000","message":"I can pull these out for now and refer to the existing files in the folder mentioned for now or would it be preferred to have a separate shared folder for header files?","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"7e5b456d1643f89e3ce626120a50c1a668bb12ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* SPDX-License-Identifier: GPL-2.0-or-later */"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/***************************************************************************"},{"line_number":4,"context_line":" *   Copyright (C) 2016 by Maxim Integrated                                *"},{"line_number":5,"context_line":" *   Copyright (C) 2025-2026 Analog Devices, Inc.                          *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"63cdacae_dcfa0aa9","line":2,"in_reply_to":"a5cb3fc1_c56b508d","updated":"2026-02-25 10:35:07.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"}],"src/flash/nor/max32xxx_qspi.c":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"96dabd49b980c819d239f6c9d502167cc75d5669","unresolved":true,"context_lines":[{"line_number":1187,"context_line":"\t.commands \u003d max32xxx_qspi_command_handlers,"},{"line_number":1188,"context_line":"\t.flash_bank_command \u003d max32xxx_qspi_flash_bank_command,"},{"line_number":1189,"context_line":"\t.erase \u003d max32xxx_qspi_erase,"},{"line_number":1190,"context_line":"\t.protect \u003d max32xxx_qspi_protect,"},{"line_number":1191,"context_line":"\t.write \u003d max32xxx_qspi_write,"},{"line_number":1192,"context_line":"\t.read \u003d default_flash_read,"},{"line_number":1193,"context_line":"\t.verify \u003d default_flash_verify,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"78fa5a6d_45144ed6","line":1190,"updated":"2026-02-10 22:56:02.000000000","message":"The protect and protect_check pointers should likely be NULL as there is no real implementation","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":true,"context_lines":[{"line_number":1187,"context_line":"\t.commands \u003d max32xxx_qspi_command_handlers,"},{"line_number":1188,"context_line":"\t.flash_bank_command \u003d max32xxx_qspi_flash_bank_command,"},{"line_number":1189,"context_line":"\t.erase \u003d max32xxx_qspi_erase,"},{"line_number":1190,"context_line":"\t.protect \u003d max32xxx_qspi_protect,"},{"line_number":1191,"context_line":"\t.write \u003d max32xxx_qspi_write,"},{"line_number":1192,"context_line":"\t.read \u003d default_flash_read,"},{"line_number":1193,"context_line":"\t.verify \u003d default_flash_verify,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"796e47d2_6a25e1ad","line":1190,"in_reply_to":"78fa5a6d_45144ed6","updated":"2026-02-23 10:53:32.000000000","message":"Agreed.  I will get that changed.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"888dbbf95763dd18a7bd2366747492fb715c60b3","unresolved":false,"context_lines":[{"line_number":1187,"context_line":"\t.commands \u003d max32xxx_qspi_command_handlers,"},{"line_number":1188,"context_line":"\t.flash_bank_command \u003d max32xxx_qspi_flash_bank_command,"},{"line_number":1189,"context_line":"\t.erase \u003d max32xxx_qspi_erase,"},{"line_number":1190,"context_line":"\t.protect \u003d max32xxx_qspi_protect,"},{"line_number":1191,"context_line":"\t.write \u003d max32xxx_qspi_write,"},{"line_number":1192,"context_line":"\t.read \u003d default_flash_read,"},{"line_number":1193,"context_line":"\t.verify \u003d default_flash_verify,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"17592653_45352fd0","line":1190,"in_reply_to":"796e47d2_6a25e1ad","updated":"2026-02-23 22:25:19.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"}],"tcl/target/max32690.cfg":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"f77ac4a919910f7f4e96952a0d4c914757339193","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Set the reset pin configuration"},{"line_number":5,"context_line":"reset_config srst_only"},{"line_number":6,"context_line":"adapter srst delay 2"},{"line_number":7,"context_line":"adapter srst pulse_width 2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Set flash parameters"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"8379c09b_129046f1","line":6,"updated":"2026-02-11 10:05:44.000000000","message":"I was told to remove this as it should not be necessary on swd transport: https://review.openocd.org/c/openocd/+/9323/comment/0fa5511c_4502246d/","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"888dbbf95763dd18a7bd2366747492fb715c60b3","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Set the reset pin configuration"},{"line_number":5,"context_line":"reset_config srst_only"},{"line_number":6,"context_line":"adapter srst delay 2"},{"line_number":7,"context_line":"adapter srst pulse_width 2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Set flash parameters"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"69345351_69af411c","line":6,"in_reply_to":"56f4565d_ea2a080c","updated":"2026-02-23 22:25:19.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"7e5b456d1643f89e3ce626120a50c1a668bb12ac","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Set the reset pin configuration"},{"line_number":5,"context_line":"reset_config srst_only"},{"line_number":6,"context_line":"adapter srst delay 2"},{"line_number":7,"context_line":"adapter srst pulse_width 2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Set flash parameters"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"82389830_858b4db2","line":6,"in_reply_to":"69345351_69af411c","updated":"2026-02-25 10:35:07.000000000","message":"I have removed lines 6 and 7 as they are not required.","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Set the reset pin configuration"},{"line_number":5,"context_line":"reset_config srst_only"},{"line_number":6,"context_line":"adapter srst delay 2"},{"line_number":7,"context_line":"adapter srst pulse_width 2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Set flash parameters"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"56f4565d_ea2a080c","line":6,"in_reply_to":"8379c09b_129046f1","updated":"2026-02-23 10:53:32.000000000","message":"We\u0027ll test with this removed and update","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"96dabd49b980c819d239f6c9d502167cc75d5669","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"   if {$QSPI_VDDIOH !\u003d 0} {"},{"line_number":126,"context_line":"   # Use VDDIOH"},{"line_number":127,"context_line":"   mww $GPIO0_VSSEL_ADDR $TEMP_MOD"},{"line_number":128,"context_line":"   } else {"},{"line_number":129,"context_line":"   # Use VDDIO"},{"line_number":130,"context_line":"   mww $GPIO0_VSSEL_ADDR [expr { !($TEMP_MOD) } ]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"13341e0f_e43bfccc","line":127,"updated":"2026-02-10 22:56:02.000000000","message":"Indentation here and in else section","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"   if {$QSPI_VDDIOH !\u003d 0} {"},{"line_number":126,"context_line":"   # Use VDDIOH"},{"line_number":127,"context_line":"   mww $GPIO0_VSSEL_ADDR $TEMP_MOD"},{"line_number":128,"context_line":"   } else {"},{"line_number":129,"context_line":"   # Use VDDIO"},{"line_number":130,"context_line":"   mww $GPIO0_VSSEL_ADDR [expr { !($TEMP_MOD) } ]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"e9b6c34d_cee98490","line":127,"in_reply_to":"13341e0f_e43bfccc","updated":"2026-02-23 10:53:32.000000000","message":"Will fix","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"888dbbf95763dd18a7bd2366747492fb715c60b3","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"   if {$QSPI_VDDIOH !\u003d 0} {"},{"line_number":126,"context_line":"   # Use VDDIOH"},{"line_number":127,"context_line":"   mww $GPIO0_VSSEL_ADDR $TEMP_MOD"},{"line_number":128,"context_line":"   } else {"},{"line_number":129,"context_line":"   # Use VDDIO"},{"line_number":130,"context_line":"   mww $GPIO0_VSSEL_ADDR [expr { !($TEMP_MOD) } ]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"0a9a6037_ea9dc952","line":127,"in_reply_to":"e9b6c34d_cee98490","updated":"2026-02-23 22:25:19.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"96dabd49b980c819d239f6c9d502167cc75d5669","unresolved":true,"context_lines":[{"line_number":146,"context_line":"   # Initialize the flash bank"},{"line_number":147,"context_line":"   flash bank $_CHIPNAME.qspi_flash max32xxx_qspi $QSPI_ADDR_BASE $QSPI_ADDR_SIZE \\"},{"line_number":148,"context_line":"      0 0 $_CHIPNAME.cpu $QSPI_OPTIONS"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"}"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"703e51a3_bf753a90","line":149,"updated":"2026-02-10 22:56:02.000000000","message":"2 blank lines here can be removed","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"524779f16333152ca0057d298a96064039ef5fd6","unresolved":true,"context_lines":[{"line_number":146,"context_line":"   # Initialize the flash bank"},{"line_number":147,"context_line":"   flash bank $_CHIPNAME.qspi_flash max32xxx_qspi $QSPI_ADDR_BASE $QSPI_ADDR_SIZE \\"},{"line_number":148,"context_line":"      0 0 $_CHIPNAME.cpu $QSPI_OPTIONS"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"}"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c967997c_4799152c","line":149,"in_reply_to":"703e51a3_bf753a90","updated":"2026-02-23 10:53:32.000000000","message":"Will fix","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"888dbbf95763dd18a7bd2366747492fb715c60b3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"   # Initialize the flash bank"},{"line_number":147,"context_line":"   flash bank $_CHIPNAME.qspi_flash max32xxx_qspi $QSPI_ADDR_BASE $QSPI_ADDR_SIZE \\"},{"line_number":148,"context_line":"      0 0 $_CHIPNAME.cpu $QSPI_OPTIONS"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"}"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"219fc4de_231c9801","line":149,"in_reply_to":"c967997c_4799152c","updated":"2026-02-23 22:25:19.000000000","message":"Done","commit_id":"b12679b46afff26fd54cdc18cc943990f24e72f9"}]}