)]}'
{"id":"openocd~master~I1d452af115355bc4949b1616648fe6544cc48318","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-02-15 18:23:26.000000000","reason":"removed on reply"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-02-03 07:40:58.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2026-02-15 18:23:30.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1d452af115355bc4949b1616648fe6544cc48318","subject":"configure: silent MacOS clang warning gnu-folding-constant","status":"MERGED","created":"2026-02-02 14:30:35.000000000","updated":"2026-02-15 18:23:30.000000000","submitted":"2026-02-15 18:23:30.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9431","meta_rev_id":"3ebc653a6c936593aa1cfdb4b61e4a8bf03c3541","_number":9431,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-15 18:23:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-02-15 18:23:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-15 18:23:30.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-02 14:30:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2026-02-02 14:30:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2026-02-02 14:39:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-02-02 15:32:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fd060da5939873f7fec2176d6472afa50100b43a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-02 14:30:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c32652f8aaf512f2d33210ca8d0ab9346b4a8b52","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-02-02 15:32:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21729/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22617/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"094fd0cb8ddb96999f889fdc42afea5b82ef9fc7","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-02-03 07:40:58.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8ebaccdf92f5003ff31f9bf9c7d27d271bbd1ac0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:23:26.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3ebc653a6c936593aa1cfdb4b61e4a8bf03c3541","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:23:30.000000000","message":"Change has been successfully cherry-picked as aaceff81f064107537c7706dc19ca6ff80ca12c8","accounts_in_message":[],"_revision_number":2}],"current_revision":"aaceff81f064107537c7706dc19ca6ff80ca12c8","revisions":{"aaceff81f064107537c7706dc19ca6ff80ca12c8":{"kind":"REWORK","_number":2,"created":"2026-02-15 18:23:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/9431/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/9431/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/2 \u0026\u0026 git checkout -b change-9431 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/9431/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9e1db0e8c7cf7a81f75457e5181e5045a5c245f5","subject":"transport: don\u0027t warn when a transport is selected twice"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-02 13:52:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-15 18:23:30.000000000","tz":0},"subject":"configure: silent MacOS clang warning gnu-folding-constant","message":"configure: silent MacOS clang warning gnu-folding-constant\n\nOn the specific fork of clang for MacOS, the compiler gets more\nstrict on the use of GNU folding constants, generating warnings\nthat halts the build of OpenOCD.\nThe GNU folding constants are highlighted by upstream clang only\nfor global variables. E.g.:\n\tconst int len \u003d 10;\n\tint array[len];\ngenerates the warning on:\n\tclang -c x.c\n\tx.c:2:5: warning: variable length array folded to constant\n\t\t array as an extension [-Wgnu-folding-constant]\n\tint array[len];\n\t    ^\nApparently only the MacOS fork generates warning for folded\nconstants inside a function. E.g.:\n\tint a(int *x);\n\tint b(void)\n\t{\n\t\tconst int len \u003d 10;\n\t\tint array[len];\n\t\treturn a*array);\n\t}\ndoes not return error even forcing -Wgnu-folding-constant on clang\nupstream.\n\nCurrent code triggers warning on the following lines due to the\nsize of the array being computed from a const variable:\n\tjtag/drivers/xds110.c:354         unsigned char data[max_data + 1];\n\tflash/nor/dw-spi.c:950            uint8_t buffer[buffer_size];\n\tflash/nor/dw-spi.c:980            uint8_t buffer[buffer_size];\n\tflash/nor/dw-spi.c:1034           uint8_t buffer[buffer_size];\n\tflash/nor/dw-spi.c:1065           uint8_t buffer[buffer_size];\n\tflash/nor/jtagspi.c:364           uint8_t ..., write_buffer[max], ...;\n\tflash/nor/stmqspi.c:778           char ..., output[(2 + max + 256) * 3 + 8];\n\tflash/nor/xcf.c:392               uint8_t reference[L];\n\ttarget/target.c:3303              char output[line_bytecnt * 4 + 1];\n\ttarget/semihosting_common.c:1787  char buf[buf_len];\n\ttarget/smp.c:59                   char hex_buffer[len * 2 + 1];\n\ttarget/smp.c:60                   uint8_t buffer[len];\n\ttarget/cortex_m.c:296             uint32_t r_vals[n_r32];\n\ttarget/cortex_m.c:297             uint32_t dhcsr[n_r32];\n\ttarget/x86_32_common.c:1337       char output[line_bytecnt * 4 + 1];\n\ttarget/riscv/riscv.c:2377         uint8_t buffer[length];\n\ttarget/xtensa/xtensa.c:536        uint8_t ops_padded[max_oplen];\n\nWhile some of the const variable above could be replaced by macros,\nfor the majority of them I don\u0027t see such need, and the use of\nconst looks to me correct.\n\nSilent the warning adding the clang flag -Wno-gnu-folding-constant.\nThe flag is not recognized by GCC, but it\u0027s silently ignored.\n\nChange-Id: I1d452af115355bc4949b1616648fe6544cc48318\nReported-by: Frank Zeyda \u003cfrank.zeyda@gmail.com\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9431\nTested-by: jenkins\nReviewed-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"85582bbe4c98b85a5f6f49d922b855ebafb0107f":{"kind":"REWORK","_number":1,"created":"2026-02-02 14:30:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/9431/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/9431/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/1 \u0026\u0026 git checkout -b change-9431 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/9431/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/9431/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"db34f6f0a71baa9c97794cb347dc3c74b3ef729d","subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-02 13:52:45.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-02 14:23:56.000000000","tz":60},"subject":"configure: silent MacOS clang warning gnu-folding-constant","message":"configure: silent MacOS clang warning gnu-folding-constant\n\nOn the specific fork of clang for MacOS, the compiler gets more\nstrict on the use of GNU folding constants, generating warnings\nthat halts the build of OpenOCD.\nThe GNU folding constants are highlighted by upstream clang only\nfor global variables. E.g.:\n\tconst int len \u003d 10;\n\tint array[len];\ngenerates the warning on:\n\tclang -c x.c\n\tx.c:2:5: warning: variable length array folded to constant\n\t\t array as an extension [-Wgnu-folding-constant]\n\tint array[len];\n\t    ^\nApparently only the MacOS fork generates warning for folded\nconstants inside a function. E.g.:\n\tint a(int *x);\n\tint b(void)\n\t{\n\t\tconst int len \u003d 10;\n\t\tint array[len];\n\t\treturn a*array);\n\t}\ndoes not return error even forcing -Wgnu-folding-constant on clang\nupstream.\n\nCurrent code triggers warning on the following lines due to the\nsize of the array being computed from a const variable:\n\tjtag/drivers/xds110.c:354         unsigned char data[max_data + 1];\n\tflash/nor/dw-spi.c:950            uint8_t buffer[buffer_size];\n\tflash/nor/dw-spi.c:980            uint8_t buffer[buffer_size];\n\tflash/nor/dw-spi.c:1034           uint8_t buffer[buffer_size];\n\tflash/nor/dw-spi.c:1065           uint8_t buffer[buffer_size];\n\tflash/nor/jtagspi.c:364           uint8_t ..., write_buffer[max], ...;\n\tflash/nor/stmqspi.c:778           char ..., output[(2 + max + 256) * 3 + 8];\n\tflash/nor/xcf.c:392               uint8_t reference[L];\n\ttarget/target.c:3303              char output[line_bytecnt * 4 + 1];\n\ttarget/semihosting_common.c:1787  char buf[buf_len];\n\ttarget/smp.c:59                   char hex_buffer[len * 2 + 1];\n\ttarget/smp.c:60                   uint8_t buffer[len];\n\ttarget/cortex_m.c:296             uint32_t r_vals[n_r32];\n\ttarget/cortex_m.c:297             uint32_t dhcsr[n_r32];\n\ttarget/x86_32_common.c:1337       char output[line_bytecnt * 4 + 1];\n\ttarget/riscv/riscv.c:2377         uint8_t buffer[length];\n\ttarget/xtensa/xtensa.c:536        uint8_t ops_padded[max_oplen];\n\nWhile some of the const variable above could be replaced by macros,\nfor the majority of them I don\u0027t see such need, and the use of\nconst looks to me correct.\n\nSilent the warning adding the clang flag -Wno-gnu-folding-constant.\nThe flag is not recognized by GCC, but it\u0027s silently ignored.\n\nChange-Id: I1d452af115355bc4949b1616648fe6544cc48318\nReported-by: Frank Zeyda \u003cfrank.zeyda@gmail.com\u003e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}