)]}'
{"id":"openocd~master~I002ce7029936f56b1d8b41505bca8dc771c33187","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2026-02-15 18:18:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I002ce7029936f56b1d8b41505bca8dc771c33187","subject":"tcl/target/klx, ke0x: drop swj on swd only targets","status":"MERGED","created":"2026-02-03 20:53:06.000000000","updated":"2026-02-15 18:18:45.000000000","submitted":"2026-02-15 18:18:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9434","meta_rev_id":"c4091799fbaf57ba891750d7e69d7f7293b1229d","_number":9434,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-15 18:18:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-02-15 18:18:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-03 20:55:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-02-03 21:21:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-02-04 15:22:33.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"e2ba2ec39efb7aa047b9ff3de0ba9ab75acb5ac2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-02-03 20:53:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c22223d92c78eff92b23bd4fdee4fee4cd41f2c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-02-03 21:21:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21735/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22623/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cb3377f544aa173741e297d244a6e92adab513a3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-04 15:22:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7306859068804e337acb687a332249c8d5b76ab2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:18:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c4091799fbaf57ba891750d7e69d7f7293b1229d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:18:45.000000000","message":"Change has been successfully cherry-picked as a7d31c87e1c5893bd6e1f409e66e1132863553a0","accounts_in_message":[],"_revision_number":2}],"current_revision":"a7d31c87e1c5893bd6e1f409e66e1132863553a0","revisions":{"f32442d3aec1eba85b6db81555207636eec236cf":{"kind":"REWORK","_number":1,"created":"2026-02-03 20:53:06.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/34/9434/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/9434/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/1 \u0026\u0026 git checkout -b change-9434 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/9434/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15ce2ab85723a3a440c5f6f922da5c0d11a28546","subject":"tcl/target/at91samd, atsame5x: drop swj on swd only targets"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-02-03 20:24:17.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-02-03 20:51:44.000000000","tz":60},"subject":"tcl/target/klx, ke0x: drop swj on swd only targets","message":"tcl/target/klx, ke0x: drop swj on swd only targets\n\nHistorically swj_newdap was necessary to handle HLA properly.\nSince commit 60f104f45013 (\"hla_transport: split command\nregistration per transport\") there is no point in using\nswj_newdap on SWD only devices.\n\nNo board files referring these targets select swd transport.\n\nChange-Id: I002ce7029936f56b1d8b41505bca8dc771c33187\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"a7d31c87e1c5893bd6e1f409e66e1132863553a0":{"kind":"REWORK","_number":2,"created":"2026-02-15 18:18:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/9434/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/9434/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/2 \u0026\u0026 git checkout -b change-9434 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/9434/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/9434/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2374db956b0fb280c98653c0af9551ba69b5c7d5","subject":"tcl/target/at91samd, atsame5x: drop swj on swd only targets"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-02-03 20:24:17.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-15 18:18:45.000000000","tz":0},"subject":"tcl/target/klx, ke0x: drop swj on swd only targets","message":"tcl/target/klx, ke0x: drop swj on swd only targets\n\nHistorically swj_newdap was necessary to handle HLA properly.\nSince commit 60f104f45013 (\"hla_transport: split command\nregistration per transport\") there is no point in using\nswj_newdap on SWD only devices.\n\nNo board files referring these targets select swd transport.\n\nChange-Id: I002ce7029936f56b1d8b41505bca8dc771c33187\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9434\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}